New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 907562 link

Starred by 1 user
Status: Assigned
Owner:
hinoka@chromium.org
Cc:
jchin...@chromium.org
█ dpranke@google.com
hinoka@chromium.org
efoo@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

"WebKit Win Builder" and "WebKit Mac Builder" bots are on main waterfall but 404

Project Member Reported by thakis@chromium.org, Nov 21 
I'm writing a change to infra/config/global/lint-luci-milo-cfg.py that sends a http request to all bots on the main waterfall and checks that it doesn't 404. For most bots, this does work.

But these two bots do 404:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win%20Builder/
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac%20Builder/

(https://ci.chromium.org/p/chromium/g/main/console -> chromium.webkit->win->bld->32 and https://ci.chromium.org/p/chromium/g/main/console->mac->bld)


I'm not sure what the state of these two bots is supposed to be, with the LUCI migration going on. Should they just be removed from luci-milo.cfg? Are they supposed to exist and them not existing is a bug?



(And given the win builder 404, what produces the binaries tested by e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Win10 ?)

Comment 1 by dpranke@chromium.org, Nov 26

Cc: jchin...@chromium.org hinoka@chromium.org
Owner: hinoka@chromium.org
Good question, this is a confusing area.

IIRC, the plan was (is?) to migrate all of the .webkit builders to non-.webkit waterfalls as part of the LUCI migration. As a part of that, those two builders became no longer needed as they were purely redundant copies of the builders on the .win and .mac waterfalls.

For example, jchinlee@ added a "WebKit Win10" builder onto chromium.win in bug 790343 (so, for example, the "WebKit Win10" builder is triggered by "Win Builder". 

I think at this point all of the *.webkit builders are redundant and should be gone.

However, I think what has happened is that we didn't get rid of all of the references, and so you're still seeing the stale console and waterfall pages. And, because a builder name has to be unique in a project I think the LUCI links you're finding that do work are working somewhat by accident.

reassigning to hinoka@ to confirm my guesses, and then someone (hinoka/jchinlee/efoo) can probably clean up the remaining references.

Comment 2 by thakis@chromium.org, Nov 26 

(I meant to link to https://chromium-review.googlesource.com/c/chromium/src/+/1347332 in comment 0; mostly unrelated to the main thrust here though)

Comment 3 by jchin...@chromium.org, Nov 26 

https://chromium-review.googlesource.com/c/chromium/src/+/1284769

Those builders (WebKit Win/Mac Builder) are supposed to be removed. IIRC I left the references for chromium.webkit consoles because *technically*, if we care about that "master", those builders are still on that master... but that's confusing :) I'll switch them over to the LUCI builder.

Comment 4 by dpranke@chromium.org, Nov 26 

We should just get rid of any references to that master altogether.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07a35565db36c832ebaef138b86d2b3c0b0a4f92

commit 07a35565db36c832ebaef138b86d2b3c0b0a4f92
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Tue Nov 27 01:03:07 2018

Remove WebKit Win/Mac Builder from Milo config.

Bug: 907562
Change-Id: Iffe499a9329501cf0a1e439be29f606c746737a6
Reviewed-on: https://chromium-review.googlesource.com/c/1351096
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610984}
[modify] https://crrev.com/07a35565db36c832ebaef138b86d2b3c0b0a4f92/infra/config/global/luci-milo.cfg

Comment 7 by philip.j...@gmail.com, Nov 28 

Is this fixed now?

Comment 8 by jchin...@chromium.org, Nov 28 

WebKit Win Builder and WebKit Mac Builder are no longer present on the main waterfall (trying to access links to them directly will still 404, which is WAI because those builders no longer exist).

Dirk --- do we need to communicate the below transitions explicitly somewhere
WebKit Win10 -> chromium.win "master"
WebKit Mac10.13 (retina) -> chromium.mac "master"
WebKit Linux Trusty ASAN/MSAN/Leak -> chromium.memory "master"
so that folks know where to find those builders and don't get confused?

I was planning on doing the Milo changes once the latter three builders are migrated.

Comment 9 by dpranke@chromium.org, Nov 29 

Yes, once chromium.webkit is finally gone it'd probably be good to send a note to blink-dev@ announcing that.
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e344b825ce176ac87ee11002379f235eae7f436e

commit e344b825ce176ac87ee11002379f235eae7f436e
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Wed Dec 19 20:28:24 2018

Remove WebKit builders and reorganize console view.

BUG= 818301 ,790309,790294,790286,907562

Change-Id: Ia6a8617575d650f81f5367725d05b97b95e2c3b4
Reviewed-on: https://chromium-review.googlesource.com/c/1381717
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617930}
[modify] https://crrev.com/e344b825ce176ac87ee11002379f235eae7f436e/infra/config/global/luci-milo.cfg
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9daa3ffd692bd1e09f1adc094179988a888cd79d

commit 9daa3ffd692bd1e09f1adc094179988a888cd79d
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Wed Dec 19 20:31:28 2018

Revert "Remove WebKit builders and reorganize console view."

This reverts commit e344b825ce176ac87ee11002379f235eae7f436e.

Reason for revert: "error console not found"

Original change's description:
> Remove WebKit builders and reorganize console view.
> 
> BUG= 818301 ,790309,790294,790286,907562
> 
> Change-Id: Ia6a8617575d650f81f5367725d05b97b95e2c3b4
> Reviewed-on: https://chromium-review.googlesource.com/c/1381717
> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#617930}

TBR=jchinlee@chromium.org,jbudorick@chromium.org

Change-Id: Ia14ffb037ed036aea47b29017244bff45a2db4c4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  818301 , 790309, 790294, 790286, 907562
Reviewed-on: https://chromium-review.googlesource.com/c/1385009
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617934}
[modify] https://crrev.com/9daa3ffd692bd1e09f1adc094179988a888cd79d/infra/config/global/luci-milo.cfg
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c59af03d523766b9b34c29335b2df172de3cc14d

commit c59af03d523766b9b34c29335b2df172de3cc14d
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Wed Dec 19 21:17:59 2018

Reland "Remove WebKit builders and reorganize console view."

This reverts commit 9daa3ffd692bd1e09f1adc094179988a888cd79d.

Reason for revert: fix dangling reference

Original change's description:
> Revert "Remove WebKit builders and reorganize console view."
> 
> This reverts commit e344b825ce176ac87ee11002379f235eae7f436e.
> 
> Reason for revert: "error console not found"
> 
> Original change's description:
> > Remove WebKit builders and reorganize console view.
> > 
> > BUG= 818301 ,790309,790294,790286,907562
> > 
> > Change-Id: Ia6a8617575d650f81f5367725d05b97b95e2c3b4
> > Reviewed-on: https://chromium-review.googlesource.com/c/1381717
> > Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
> > Reviewed-by: John Budorick <jbudorick@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#617930}
> 
> TBR=jchinlee@chromium.org,jbudorick@chromium.org
> 
> Change-Id: Ia14ffb037ed036aea47b29017244bff45a2db4c4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  818301 , 790309, 790294, 790286, 907562
> Reviewed-on: https://chromium-review.googlesource.com/c/1385009
> Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#617934}

TBR=jchinlee@chromium.org,jbudorick@chromium.org

Change-Id: I2e4efb4fc923a4da5cdb87e24115d028084a31c8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  818301 , 790309, 790294, 790286, 907562
Reviewed-on: https://chromium-review.googlesource.com/c/1384991
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617947}
[modify] https://crrev.com/c59af03d523766b9b34c29335b2df172de3cc14d/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/c59af03d523766b9b34c29335b2df172de3cc14d/infra/config/global/luci-milo.cfg
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/a26a582c17d3352ce9eb3c7cc3dea9cdd055e6f3

commit a26a582c17d3352ce9eb3c7cc3dea9cdd055e6f3
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Thu Dec 20 02:01:57 2018

Remove chromium.webkit master.

Bug:  818301 ,790309,790294,790286,907562
Change-Id: I485021b3fcfd8c29e18fa4f360d9d48884631d88
Reviewed-on: https://chromium-review.googlesource.com/c/1381712
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>

[delete] https://crrev.com/85ec97a85ef6ad642afb6481a495797eacc25a47/masters/master.chromium.webkit/templates/tree_status.html
[modify] https://crrev.com/a26a582c17d3352ce9eb3c7cc3dea9cdd055e6f3/tests/masters_test.py
[delete] https://crrev.com/85ec97a85ef6ad642afb6481a495797eacc25a47/masters/master.chromium.webkit/templates/change_macros.html
[delete] https://crrev.com/85ec97a85ef6ad642afb6481a495797eacc25a47/masters/master.chromium.webkit/slaves.cfg
[delete] https://crrev.com/85ec97a85ef6ad642afb6481a495797eacc25a47/masters/master.chromium.webkit/master_source_cfg.py
[delete] https://crrev.com/85ec97a85ef6ad642afb6481a495797eacc25a47/masters/master.chromium.webkit/Makefile
[delete] https://crrev.com/85ec97a85ef6ad642afb6481a495797eacc25a47/masters/master.chromium.webkit/master_site_config.py
[delete] https://crrev.com/85ec97a85ef6ad642afb6481a495797eacc25a47/masters/master.chromium.webkit/master_linux_webkit_latest_cfg.py
[delete] https://crrev.com/85ec97a85ef6ad642afb6481a495797eacc25a47/masters/master.chromium.webkit/master.cfg

Comment 14 by benhenry@google.com, Jan 11

Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.
►

Sign in to add a comment