New issue
Advanced search Search tips

Issue 907556 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 21
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----



Sign in to add a comment

Menu items are requested twice for app list item view onlong press

Project Member Reported by newcomer@chromium.org, Nov 21

Issue description

This shouldn't happen.
 
Labels: M-72 Pri-2
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9877705b67742e02ca11053e3f3ffd3d7fddb296

commit 9877705b67742e02ca11053e3f3ffd3d7fddb296
Author: Alex Newcomer <newcomer@chromium.org>
Date: Wed Nov 21 19:06:38 2018

cros: Don't request menu items twice.

During long press, we request menu options twice. Avoid making this
expensive call twice.

Before, we returned early on the callback. Keep that incase race
conditions, but also return early before the request if a menu already
exists.

Bug:  907556 
Change-Id: Ie7798e25faea5128651f4a06415d978a5a6cbe35
Reviewed-on: https://chromium-review.googlesource.com/c/1347090
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610113}
[modify] https://crrev.com/9877705b67742e02ca11053e3f3ffd3d7fddb296/ash/app_list/views/app_list_item_view.cc

Status: Fixed (was: Started)

Sign in to add a comment