New issue
Advanced search Search tips

Issue 907554 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocking:
issue 907133



Sign in to add a comment

layout_flexible_box DCHECK breaking leak_detection_linux bot

Project Member Reported by huangdarwin@chromium.org, Nov 21

Issue description

Chrome Version: 70

A layout_flexible_box DCHECK being hit is failing the leak_detection_linux bot. The leak_detection_linux bot checks for leaks on the top 100 alexa websites, as far as I understand.

from apple.com:

  [1:1:1119/110816.522488:FATAL:layout_flexible_box.cc(1011)] Check failed: content_size >= LayoutUnit() ("-2.1875" vs. "0")

  https://codesearch.chromium.org/chromium/src/third_party/blink/renderer/core/layout/layout_flexible_box.cc?rcl=622c02f9a7e9fe8d55bab94de43b3dab30b8b9b8&l=1011


What steps will reproduce the problem?
Create a CL branched from master, with minimal code changes. Some sort of change is necessary, otherwise the bot will simply “succeed” and not run due to no diff from master.
Run the leak_detection_linux bot and check error logs

What is the expected result?
No failures

What happens instead?
Failure, from DCHECK being hit

Example failures:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/leak_detection_linux/25 for https://crrev.com/c/1341145 (small change)

https://ci.chromium.org/p/chromium/builders/luci.chromium.try/leak_detection_linux/24 for https://crrev.com/c/1336440 (larger/different change, but same errors)

1 error will be from goal.com, and one from apple.com. This DCHECK is causing apple.com to fail on leak_detection_linux.

 
Blocking: 907133
Owner: cbiesin...@chromium.org
Status: Assigned (was: Untriaged)
LayoutFlexibleBox::ComputeMainAxisExtentForChild() is able to return negative values somehow.

Couldn't reproduce with my own build. Tried to load both sites.
Cc: pwnall@chromium.org
Labels: OS-Linux
Yeah sorry, I'm not sure exactly how the leak_detection_linux bot works, but seems it's running a "story", or sequence of user-actions, somehow via story_runner.py, and the story being run triggers the DCHECK. I'm also unsure how to trigger the DCHECK without use of the bot, which likely triggers it via the story it loads.

Sign in to add a comment