New issue
Advanced search Search tips

Issue 907540 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 3
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 903857
issue 910203



Sign in to add a comment

Determine solution for clients that use both ProfileOAuth2TokenService and DeviceOAuth2TokenService

Project Member Reported by blundell@chromium.org, Nov 21

Issue description

PrintPreviewHandler is one. The issue is that we will port PO2TS to IdentityManager but not DeviceO2TS. Currently these clients use a common flow for fetching access tokens for both (since they're both subclasses of O2TS).
 
Blocking: 910203
Status: Fixed (was: Available)
From an investigation, it looks like the two bugs blocked on this one are the only clients in the codebase that use both DeviceO2TS and ProfileOAuth2TokenService, and they both use DeviceO2TS only to fetch access tokens. Given that information, we can just handle these two clients inline, i.e. keep their usage of DeviceO2TS as-is and change them to use AccessTokenFetcher where they are now using PO2TS to fetch access tokens.

It's possible that there are other clients that use both DeviceO2TS and ProfileOAuth2TokenService that I missed; if we need to, we can always extend/generalize this solution later. 

Sign in to add a comment