New issue
Advanced search Search tips

Issue 907535 link

Starred by 1 user
Status: Fixed
Owner:
peconn@chromium.org
Closed: Nov 23
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

TWAs should return to verified origin when Close Button pressed

Project Member Reported by peconn@chromium.org, Nov 21 
When a TWA leaves the verified origin, it shows the Custom Tabs top bar which has a close button on it. This close button currently closes the Activity, which is undesirable.

Instead it should navigate back to the last page that was on the verified origin (as this will get rid of the top bar).

There's already code to do this for dynamic modules.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fadba0e69e32a1ed0ff4241fc6a0adc2cd7610df

commit fadba0e69e32a1ed0ff4241fc6a0adc2cd7610df
Author: Peter E Conn <peconn@chromium.org>
Date: Thu Nov 22 13:48:39 2018

🤝 Return to verified origin when close button pressed.

When a TWA leaves the verified origin, the Custom Tabs top bar is
displayed and the user can see a close button. This close button would
on a normal custom tab close the Activity.

On Trusted Web Activities, this should return us to the verified
origin instead.

Bug:  907535 
Change-Id: I9f652a3255afdd23072b32c44db5680172ea33f2
Reviewed-on: https://chromium-review.googlesource.com/c/1346463
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610399}
[modify] https://crrev.com/fadba0e69e32a1ed0ff4241fc6a0adc2cd7610df/chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/TrustedWebActivityCoordinator.java
[modify] https://crrev.com/fadba0e69e32a1ed0ff4241fc6a0adc2cd7610df/chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityVerifier.java
[add] https://crrev.com/fadba0e69e32a1ed0ff4241fc6a0adc2cd7610df/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CloseButtonNavigator.java
[modify] https://crrev.com/fadba0e69e32a1ed0ff4241fc6a0adc2cd7610df/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/fadba0e69e32a1ed0ff4241fc6a0adc2cd7610df/chrome/android/java/src/org/chromium/chrome/browser/customtabs/dependency_injection/CustomTabActivityComponent.java
[modify] https://crrev.com/fadba0e69e32a1ed0ff4241fc6a0adc2cd7610df/chrome/android/java_sources.gni
[add] https://crrev.com/fadba0e69e32a1ed0ff4241fc6a0adc2cd7610df/chrome/android/junit/src/org/chromium/chrome/browser/customtabs/CloseButtonNavigatorTest.java
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce90afbf3a77f73b9c43e5fe461b26127130efb4

commit ce90afbf3a77f73b9c43e5fe461b26127130efb4
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Thu Nov 22 15:51:03 2018

Revert "🤝 Return to verified origin when close button pressed."

This reverts commit fadba0e69e32a1ed0ff4241fc6a0adc2cd7610df.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 610399 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZhZGJhMGU2OWUzMmExZWQwZmY0MjQxZmM2YTBhZGMyY2Q3NjEwZGYM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/android-rel/4725

Sample Failed Step: compile

Original change's description:
> 🤝 Return to verified origin when close button pressed.
> 
> When a TWA leaves the verified origin, the Custom Tabs top bar is
> displayed and the user can see a close button. This close button would
> on a normal custom tab close the Activity.
> 
> On Trusted Web Activities, this should return us to the verified
> origin instead.
> 
> Bug:  907535 
> Change-Id: I9f652a3255afdd23072b32c44db5680172ea33f2
> Reviewed-on: https://chromium-review.googlesource.com/c/1346463
> Commit-Queue: Peter Conn <peconn@chromium.org>
> Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610399}

Change-Id: If37c325c51b92f414d1bab5fff65946954cfe754
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  907535 
Reviewed-on: https://chromium-review.googlesource.com/c/1348209
Cr-Commit-Position: refs/heads/master@{#610418}
[modify] https://crrev.com/ce90afbf3a77f73b9c43e5fe461b26127130efb4/chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/TrustedWebActivityCoordinator.java
[modify] https://crrev.com/ce90afbf3a77f73b9c43e5fe461b26127130efb4/chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityVerifier.java
[delete] https://crrev.com/3a64405fc3b7268b60051779deed86d09990533e/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CloseButtonNavigator.java
[modify] https://crrev.com/ce90afbf3a77f73b9c43e5fe461b26127130efb4/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/ce90afbf3a77f73b9c43e5fe461b26127130efb4/chrome/android/java/src/org/chromium/chrome/browser/customtabs/dependency_injection/CustomTabActivityComponent.java
[modify] https://crrev.com/ce90afbf3a77f73b9c43e5fe461b26127130efb4/chrome/android/java_sources.gni
[delete] https://crrev.com/3a64405fc3b7268b60051779deed86d09990533e/chrome/android/junit/src/org/chromium/chrome/browser/customtabs/CloseButtonNavigatorTest.java
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef64951d3a3f424b607782d40be60d585aa48244

commit ef64951d3a3f424b607782d40be60d585aa48244
Author: Peter E Conn <peconn@chromium.org>
Date: Fri Nov 23 10:17:39 2018

Reland "🤝 Return to verified origin when close button pressed."

This is a reland of fadba0e69e32a1ed0ff4241fc6a0adc2cd7610df

Original change's description:
> 🤝 Return to verified origin when close button pressed.
> 
> When a TWA leaves the verified origin, the Custom Tabs top bar is
> displayed and the user can see a close button. This close button would
> on a normal custom tab close the Activity.
> 
> On Trusted Web Activities, this should return us to the verified
> origin instead.
> 
> Bug:  907535 
> Change-Id: I9f652a3255afdd23072b32c44db5680172ea33f2
> Reviewed-on: https://chromium-review.googlesource.com/c/1346463
> Commit-Queue: Peter Conn <peconn@chromium.org>
> Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610399}

Bug:  907535 
Change-Id: If6e17630d50ac283e91809f9f1b497b73e466e6b
Reviewed-on: https://chromium-review.googlesource.com/c/1348469
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610560}
[modify] https://crrev.com/ef64951d3a3f424b607782d40be60d585aa48244/chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/TrustedWebActivityCoordinator.java
[modify] https://crrev.com/ef64951d3a3f424b607782d40be60d585aa48244/chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityVerifier.java
[add] https://crrev.com/ef64951d3a3f424b607782d40be60d585aa48244/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CloseButtonNavigator.java
[modify] https://crrev.com/ef64951d3a3f424b607782d40be60d585aa48244/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/ef64951d3a3f424b607782d40be60d585aa48244/chrome/android/java/src/org/chromium/chrome/browser/customtabs/dependency_injection/CustomTabActivityComponent.java
[modify] https://crrev.com/ef64951d3a3f424b607782d40be60d585aa48244/chrome/android/java_sources.gni
[add] https://crrev.com/ef64951d3a3f424b607782d40be60d585aa48244/chrome/android/junit/src/org/chromium/chrome/browser/customtabs/CloseButtonNavigatorTest.java

Comment 4 by peconn@chromium.org, Nov 23

Status: Fixed (was: Started)
►

Sign in to add a comment