New issue
Advanced search Search tips

Issue 907533 link

Starred by 1 user
Status: Fixed
Owner:
toniki...@chromium.org
Closed: Nov 21
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Convert save_card_bubble_controller_impl.cc to IdentityManager API

Project Member Reported by sdefresne@chromium.org, Nov 21 
API used
- SigninManagerBase::GetAuthenticatedAccountId

Also, we can remove the check that AccountTrackerServiceFactory::GetForProfile() returns a non-null instance, since 1. the code does not use the AccountTrackerService, 2. it is not possible to create an IdentityManager with null AccountTrackerService.

Comment 1 by sdefresne@chromium.org, Nov 21

Components: Internals>Services>Identity

Comment 2 by toniki...@chromium.org, Nov 21

Owner: toniki...@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb2a31ffcdc73b831b7692cdcbffa9fcc258e701

commit cb2a31ffcdc73b831b7692cdcbffa9fcc258e701
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Wed Nov 21 22:57:48 2018

[s13n] Convert save_card_bubble_controller_impl.cc to IdentityManager

BUG= 907533 

Change-Id: Ib8714aa26040bbfb9338454c5c327f9194a20d32
Reviewed-on: https://chromium-review.googlesource.com/c/1347149
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#610248}
[modify] https://crrev.com/cb2a31ffcdc73b831b7692cdcbffa9fcc258e701/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc

Comment 4 by toniki...@chromium.org, Nov 21

Status: Fixed (was: Started)
►

Sign in to add a comment