New issue
Advanced search Search tips

Issue 907529 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 22
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Convert safe_search_url_reporter.cc to IdentityManager API

Project Member Reported by sdefresne@chromium.org, Nov 21

Issue description

API used
- SigninManagerBase::GetAuthenticatedAccountId()
 
Owner: toniki...@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77d581a5a54e903303a8e24140affb4957fb1c08

commit 77d581a5a54e903303a8e24140affb4957fb1c08
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Thu Nov 22 20:14:22 2018

[s13n] Convert safe_search_url_reporter.cc to IdentityManager

CL replaces the Use of OAuth2TokenService, OAuth2TokenService::Consumer
and SigninManager APIs with the corresponding IdentityManager counterparts.

The unittests could not be only minimally adapted, and converted on a
follow up pass, given that CL needed to replace the uses of
FakeProfileOAuth2TokenService with IdentityTestEnvironment upfront.

TBR=blundell@chromium.org,treib@chromium.org (both have already approved
the previously incarnation of this CL. The CL was accidentally deleted
when being sent to CQ).

BUG= 907529 

Change-Id: If359e0a0728f87281a9f0c6bbe09ee10db2c82d3
Reviewed-on: https://chromium-review.googlesource.com/c/1348670
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#610480}
[modify] https://crrev.com/77d581a5a54e903303a8e24140affb4957fb1c08/chrome/browser/supervised_user/experimental/safe_search_url_reporter.cc
[modify] https://crrev.com/77d581a5a54e903303a8e24140affb4957fb1c08/chrome/browser/supervised_user/experimental/safe_search_url_reporter.h
[modify] https://crrev.com/77d581a5a54e903303a8e24140affb4957fb1c08/chrome/browser/supervised_user/experimental/safe_search_url_reporter_unittest.cc

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Today (12 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d91eed89cc6a3d3cbe61104f1f6dcb29336b4ef6

commit d91eed89cc6a3d3cbe61104f1f6dcb29336b4ef6
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Tue Jan 22 18:49:32 2019

Use identity::PrimaryAccountAccessTokenFetcher SafeSearchURLReporter & PermissionRequestCreatorApiary

Since production code of both classes operate solely fetching the
access token of the primary account, this CL:

- uses the class designed for the task in both classes:
PrimaryAccountAccessTokenFetcher.
- changes the both classes unittests to reflect the production code.

BUG= 907529 , 907526 

Change-Id: Ie85a98ca5e44dff6d63f33a4b3de6a16b3cc92f1
Reviewed-on: https://chromium-review.googlesource.com/c/1426759
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#624846}
[modify] https://crrev.com/d91eed89cc6a3d3cbe61104f1f6dcb29336b4ef6/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc
[modify] https://crrev.com/d91eed89cc6a3d3cbe61104f1f6dcb29336b4ef6/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.h
[modify] https://crrev.com/d91eed89cc6a3d3cbe61104f1f6dcb29336b4ef6/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary_unittest.cc
[modify] https://crrev.com/d91eed89cc6a3d3cbe61104f1f6dcb29336b4ef6/chrome/browser/supervised_user/experimental/safe_search_url_reporter.cc
[modify] https://crrev.com/d91eed89cc6a3d3cbe61104f1f6dcb29336b4ef6/chrome/browser/supervised_user/experimental/safe_search_url_reporter.h
[modify] https://crrev.com/d91eed89cc6a3d3cbe61104f1f6dcb29336b4ef6/chrome/browser/supervised_user/experimental/safe_search_url_reporter_unittest.cc

Sign in to add a comment