[libchrome] Libchrome has stopped building on the asan and ubsan builders. |
|||
Issue descriptionAs of a few hours ago the asan and ubsan builders both started failing in BuildPackages, while building libchrome. The error message is * Failed Patch: libchrome-456626-Disable-memory-allocator.patch ! This is probably due to the recent uprev of libchrome here: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1239834 The BuildPackages logs for the failed builds can be found here: https://luci-logdog.appspot.com/logs/chromeos/buildbucket/cr-buildbucket.appspot.com/8929245125123971792/+/steps/BuildPackages/0/stdout https://luci-logdog.appspot.com/logs/chromeos/buildbucket/cr-buildbucket.appspot.com/8929251038758180480/+/steps/BuildPackages/0/stdout https://luci-logdog.appspot.com/logs/chromeos/buildbucket/cr-buildbucket.appspot.com/8929248981125227776/+/steps/BuildPackages/0/stdout Please fix this asap. Thanks!
,
Nov 21
Fixing...
,
Nov 21
Issue 907546 has been merged into this issue.
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/bfed19d59635c1cd61c2bf05fb673fd47bf25e90 commit bfed19d59635c1cd61c2bf05fb673fd47bf25e90 Author: Hidehiko Abe <hidehiko@chromium.org> Date: Wed Nov 21 19:54:57 2018 libchrome: Fix ASAN build. BUG= chromium:907523 TEST=Build locally. Change-Id: Ie8c2c43cff0f71e2a040d3ace1a5dc38c2bd0d26 Reviewed-on: https://chromium-review.googlesource.com/c/1346591 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Tested-by: Hidehiko Abe <hidehiko@chromium.org> Trybot-Ready: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> [modify] https://crrev.com/bfed19d59635c1cd61c2bf05fb673fd47bf25e90/chromeos-base/libchrome/files/libchrome-456626-Disable-memory-allocator.patch [rename] https://crrev.com/bfed19d59635c1cd61c2bf05fb673fd47bf25e90/chromeos-base/libchrome/libchrome-456626-r2.ebuild
,
Nov 21
asan builder is still failing unit tests. https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8929215007414050528 For the failures in dir_reader_linux.h, the patch https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/920385 was dropped in libchrome uprev. It needs to be ported back to libchrome. chromeos-config-tools-0.0.2-r1150: * ASAN error detected: chromeos-config-tools-0.0.2-r1150: * base/files/dir_reader_linux.h:79:20: runtime error: member access within misaligned address 0x7ffcad4e8c24 for type 'const base::linux_dirent', which requires 8 byte alignment chromeos-config-tools-0.0.2-r1150: * 0x7ffcad4e8c24: note: pointer points here chromeos-config-tools-0.0.2-r1150: * 04 00 00 00 6f 92 50 00 00 00 00 00 01 00 00 00 00 00 00 00 18 00 04 2e 00 00 00 00 6e 92 50 00 chromeos-config-tools-0.0.2-r1150: * ^ chromeos-config-tools-0.0.2-r1150: * #0 0x7f2fd381a56a in base::DirReaderLinux::name() const /build/amd64-generic/tmp/portage/chromeos-base/libchrome-456626-r2/work/libchrome-456626/./base/files/dir_reader_linux.h:79:20 chromeos-config-tools-0.0.2-r1150: * #1 0x7f2fd381a56a in base::CloseSuperfluousFds(std::__1::vector<base::InjectionArc, std::__1::allocator<base::InjectionArc> > const&) /build/amd64-generic/tmp/portage/chromeos-base/libchrome-456626-r2/work/libchrome-456626/base/process/launch_posix.cc:267:0 chromeos-config-tools-0.0.2-r1150: * #2 0x7f2fd381fac7 in base::GetAppOutputInternal(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&, char* const*, bool, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*, bool, int*) /build/amd64-generic/tmp/portage/chromeos-base/libchrome-456626-r2/work/libchrome-456626/base/process/launch_posix.cc:613:9
,
Nov 23
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/682e8aba99ce03c74353fd8a1f82c1333ac90d2d commit 682e8aba99ce03c74353fd8a1f82c1333ac90d2d Author: Hidehiko Abe <hidehiko@chromium.org> Date: Fri Nov 23 03:08:05 2018 libchrome: Re-cherry pick r534999. The patch was accidentally dropped in the libchrome uprev. Re cherry-pick with comment when we can drop it. BUG= chromium:907523 TEST=Build locally. Change-Id: I82266879093a1db5fd081036e82d625684e1df7c Reviewed-on: https://chromium-review.googlesource.com/1347530 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> [rename] https://crrev.com/682e8aba99ce03c74353fd8a1f82c1333ac90d2d/chromeos-base/libchrome/libchrome-456626-r3.ebuild [modify] https://crrev.com/682e8aba99ce03c74353fd8a1f82c1333ac90d2d/chromeos-base/libchrome/libchrome-456626.ebuild [add] https://crrev.com/682e8aba99ce03c74353fd8a1f82c1333ac90d2d/chromeos-base/libchrome/files/libchrome-456626-Base-DirReader-Alignment.patch
,
Nov 27
can this be closed now?
,
Nov 27
Yes, this appears to be fixed (the builders are no longer dying in BuildPackages).
,
Nov 28
|
|||
►
Sign in to add a comment |
|||
Comment 1 by cmtice@google.com
, Nov 21