New issue
Advanced search Search tips

Issue 907520 link

Starred by 3 users
Status: Started
Owner:
paulhsia@chromium.org
Cc:
chromeos-audio-bugs@google.com
cychiang@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocked on:
issue 916921


Sign in to add a comment

Create a rust version libcras to support Corstini audio

Project Member Reported by paulhsia@chromium.org, Nov 21 
Crostini is one of the important features in ChromeOS but it does not support audio functions now. Since Crostini virtual hardware is using Rust lang and libcras only has a C library, we need to implement a Rust version libcras to support its audio functionality.
 
Short term goals for this project
1. Write a rust version libcras
2. Support Crostini audio playback functionality
3. Support Crostini audio capture functionality with permission

Long term goals for this project
4. Refactor legacy libcras API
5. Replace legacy libcras

Comment 1 by paulhsia@chromium.org, Dec 20

Labels: OS-Chrome

Comment 2 by paulhsia@chromium.org, Dec 20

Blockedon: 916921
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/1d44223f9d75419cd3e4dc4773a7dcfdcc099478

commit 1d44223f9d75419cd3e4dc4773a7dcfdcc099478
Author: paulhsia <paulhsia@chromium.org>
Date: Thu Jan 10 21:58:41 2019

sys_util: Add net module includes UnixSeqpacket

std::os::net only supprts UnixDatagram and UnixStream, so we need this to
support the connection to socket opened with SOCK_SEQPACKET flag.
It only supports public API connect, write, try_clone, and read now.

BUG=chromium:907520
TEST=Use
     $ FEATURES=test emerge-eve sys_util
     to run unit tests.

Change-Id: I61a9acd4fa2e601e93b1f76dc1758cb61a433205
Reviewed-on: https://chromium-review.googlesource.com/1390077
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/1d44223f9d75419cd3e4dc4773a7dcfdcc099478/sys_util/src/lib.rs
[add] https://crrev.com/1d44223f9d75419cd3e4dc4773a7dcfdcc099478/sys_util/src/net.rs
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/4b95c40d576d3a1acc4df63afd320eac51d83537

commit 4b95c40d576d3a1acc4df63afd320eac51d83537
Author: paulhsia <paulhsia@chromium.org>
Date: Sun Jan 13 21:52:18 2019

CRAS: cras-sys crate generated from adhd/cras/common

Use bindgen to generate C structure and enum for rust version libcras.

Generated from upstream with commit
5fd5e32c111ad28da0bb860d023b281ae16c2094

with steps in generator/README.md

BUG=chromium:907520
TEST=Apply full patch set to test
     $ cras_tests /path/to/playback.raw
CQ-DEPEND=CL:1386286

Change-Id: I129fc7a28de4af767c8b87162357f02ec0141c7f
Reviewed-on: https://chromium-review.googlesource.com/1314275
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[add] https://crrev.com/4b95c40d576d3a1acc4df63afd320eac51d83537/cras/client/cras-sys/generator/README.md
[add] https://crrev.com/4b95c40d576d3a1acc4df63afd320eac51d83537/cras/client/cras-sys/src/lib.rs
[add] https://crrev.com/4b95c40d576d3a1acc4df63afd320eac51d83537/cras/client/cras-sys/generator/src/main.rs
[add] https://crrev.com/4b95c40d576d3a1acc4df63afd320eac51d83537/cras/client/cras-sys/src/gen.rs
[add] https://crrev.com/4b95c40d576d3a1acc4df63afd320eac51d83537/cras/client/cras-sys/.gitignore
[add] https://crrev.com/4b95c40d576d3a1acc4df63afd320eac51d83537/cras/client/cras-sys/generator/Cargo.toml
[add] https://crrev.com/4b95c40d576d3a1acc4df63afd320eac51d83537/cras/client/cras-sys/.rustfmt.toml
[add] https://crrev.com/4b95c40d576d3a1acc4df63afd320eac51d83537/cras/client/cras-sys/generator/.gitignore
[add] https://crrev.com/4b95c40d576d3a1acc4df63afd320eac51d83537/cras/client/cras-sys/Cargo.toml
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/41efb2fa573efd5f27926ee81b07ed4d3175a9b3

commit 41efb2fa573efd5f27926ee81b07ed4d3175a9b3
Author: paulhsia <paulhsia@chromium.org>
Date: Mon Jan 14 08:39:03 2019

media-sound/cras-sys: Add cros_workon ebuild

Add ebuild for crate cras-sys, which provides CRAS C-structures
generated from bindgen.

BUG=chromium:907520
TEST=$ FEATURES=test emerge-eve cras-sys
CQ-DEPEND=CL:1314275

Change-Id: Ia1d1b16ff049ef25a67982ef08abb1600eeee3b2
Reviewed-on: https://chromium-review.googlesource.com/1400331
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/41efb2fa573efd5f27926ee81b07ed4d3175a9b3/media-sound/cras-sys/cras-sys-9999.ebuild
[add] https://crrev.com/41efb2fa573efd5f27926ee81b07ed4d3175a9b3/media-sound/cras-sys/files/chromeos-version.sh
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/9c710fe47fc9451ce9c8e588e971f5f9c4b403bf

commit 9c710fe47fc9451ce9c8e588e971f5f9c4b403bf
Author: paulhsia <paulhsia@chromium.org>
Date: Mon Jan 14 11:31:38 2019

CRAS: cras_shm module in libcras crate

cras_shm is a module for shared memory resources between cras_client and
cras_server, which are cras_server_state and cras_audio_shm_area.

BUG=chromium:907520
TEST=Run unit tests in modules by
     $ cargo test
TEST=Apply full patch set to test
     $ cras_tests /path/to/playback.raw

Change-Id: I927e5e2f24d794fc808396cc716d069bea3d0a4d
Reviewed-on: https://chromium-review.googlesource.com/1314276
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[add] https://crrev.com/9c710fe47fc9451ce9c8e588e971f5f9c4b403bf/cras/client/libcras/src/lib.rs
[add] https://crrev.com/9c710fe47fc9451ce9c8e588e971f5f9c4b403bf/cras/client/libcras/.rustfmt.toml
[add] https://crrev.com/9c710fe47fc9451ce9c8e588e971f5f9c4b403bf/cras/client/libcras/src/cras_shm.rs
[add] https://crrev.com/9c710fe47fc9451ce9c8e588e971f5f9c4b403bf/cras/client/libcras/Cargo.toml
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 19 (3 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/76e471c69ac96a73b0e7e19c324cf14bde25e554

commit 76e471c69ac96a73b0e7e19c324cf14bde25e554
Author: paulhsia <paulhsia@chromium.org>
Date: Sat Jan 19 08:13:38 2019

CRAS: cras_server_socket module for CrasServerSocket

CrasServerSocket is used by CRAS client and it contains UnixSeqpacket
implemented in sys_util::net.

We also extend CrasServerSocket to ScmSocket, which support sending
sockfds with message.

BUG=chromium:907520
TEST=Run unit tests in modules by
     $ cargo test
TEST=Apply full patch set to test
     $ cras_tests /path/to/playback.raw
CQ-DEPEND=CL:1390077

Change-Id: I1a36c6a12baba50efd285d8562dd276c6cd82199
Reviewed-on: https://chromium-review.googlesource.com/1314277
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[add] https://crrev.com/76e471c69ac96a73b0e7e19c324cf14bde25e554/cras/client/libcras/src/cras_server_socket.rs
[modify] https://crrev.com/76e471c69ac96a73b0e7e19c324cf14bde25e554/cras/client/libcras/src/lib.rs
[modify] https://crrev.com/76e471c69ac96a73b0e7e19c324cf14bde25e554/cras/client/libcras/Cargo.toml
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 19 (3 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/d8726a46c2ed9efe786b7171a442665ee06a5d29

commit d8726a46c2ed9efe786b7171a442665ee06a5d29
Author: paulhsia <paulhsia@chromium.org>
Date: Sat Jan 19 08:13:39 2019

CRAS: audio_socket module for audio message

AudioSocket is a structure for handling audio messages between client
audio thread and server audio thread.

BUG=chromium:907520
TEST=Run unit tests in modules by
     $ cargo test
TEST=Apply full patch set to test
     $ cras_tests /path/to/playback.raw

Change-Id: Ia79ed7bc004107970dae2554ec1768b7804b92c0
Reviewed-on: https://chromium-review.googlesource.com/1341709
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[add] https://crrev.com/d8726a46c2ed9efe786b7171a442665ee06a5d29/cras/client/libcras/src/audio_socket.rs
[modify] https://crrev.com/d8726a46c2ed9efe786b7171a442665ee06a5d29/cras/client/libcras/src/lib.rs
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 19 (3 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c6f4b9e64da61ff86cce337ae30583b6afde3767

commit c6f4b9e64da61ff86cce337ae30583b6afde3767
Author: paulhsia <paulhsia@chromium.org>
Date: Sat Jan 19 08:13:31 2019

dev-rust: Add ebuilds for byteorder and related crates

To support eclass migration for crosvm ebuild from crate to cros-rust

Since quickcheck and rand are crates in dev-dependencies, we added empty
crates for them.

BUG=chromium:781398
BUG=chromium:907520
TEST=Run $ emerge-eve dev-rust/byteorder
     in a clean chroot

Change-Id: Ife9f7f8a87ec2ac3c9376949bc9183f80494c8bb
Reviewed-on: https://chromium-review.googlesource.com/1421297
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: David Tolnay <dtolnay@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/c6f4b9e64da61ff86cce337ae30583b6afde3767/dev-rust/rand/Manifest
[add] https://crrev.com/c6f4b9e64da61ff86cce337ae30583b6afde3767/dev-rust/rand/rand-0.3.20.ebuild
[add] https://crrev.com/c6f4b9e64da61ff86cce337ae30583b6afde3767/dev-rust/byteorder/byteorder-1.1.0.ebuild
[add] https://crrev.com/c6f4b9e64da61ff86cce337ae30583b6afde3767/dev-rust/byteorder/Manifest
[add] https://crrev.com/c6f4b9e64da61ff86cce337ae30583b6afde3767/dev-rust/quickcheck/quickcheck-0.4.2.ebuild
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 19 (3 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/aaca62babcdb713d785e8fbf958443fd3358dd47

commit aaca62babcdb713d785e8fbf958443fd3358dd47
Author: paulhsia <paulhsia@chromium.org>
Date: Sat Jan 19 08:13:31 2019

dev-rust: Add ebuilds for protobuf and related crates

To support eclass migration for crosvm ebuild from crate to cros-rust

Since bytes is an optional crate, we added an empty crate for it.

BUG=chromium:781398
BUG=chromium:907520
TEST=Run $ emerge-eve protobuf
     in a clean chroot

Change-Id: Ia2347cd2ae008d9eb8c511575511ad6bd4c13a3a
Reviewed-on: https://chromium-review.googlesource.com/1421299
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: David Tolnay <dtolnay@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/aaca62babcdb713d785e8fbf958443fd3358dd47/dev-rust/protobuf/protobuf-1.4.3.ebuild
[add] https://crrev.com/aaca62babcdb713d785e8fbf958443fd3358dd47/dev-rust/bytes/bytes-0.4.11.ebuild
[add] https://crrev.com/aaca62babcdb713d785e8fbf958443fd3358dd47/dev-rust/protobuf/Manifest
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 19 (3 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a1e117a8d2add179ac15846a35e277b336be8268

commit a1e117a8d2add179ac15846a35e277b336be8268
Author: paulhsia <paulhsia@chromium.org>
Date: Sat Jan 19 08:13:32 2019

dev-rust: Add ebuilds for protoc-rust and related crates

To support eclass migration for crosvm ebuild from crate to cros-rust

BUG=chromium:781398
BUG=chromium:907520
TEST=Run $ emerge-eve dev-rust/protoc-rust
     from a clean chroot

Change-Id: Icb5c72c1e733b909d3cb2635cdf4a8086f030020
Reviewed-on: https://chromium-review.googlesource.com/1421300
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/a1e117a8d2add179ac15846a35e277b336be8268/dev-rust/protoc/protoc-1.4.3.ebuild
[add] https://crrev.com/a1e117a8d2add179ac15846a35e277b336be8268/dev-rust/protoc-rust/Manifest
[add] https://crrev.com/a1e117a8d2add179ac15846a35e277b336be8268/dev-rust/protoc-rust/protoc-rust-1.4.3.ebuild
[add] https://crrev.com/a1e117a8d2add179ac15846a35e277b336be8268/dev-rust/protoc/Manifest
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 19 (3 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/43a270f3248f29538f56fe298cb7bde62891bc71

commit 43a270f3248f29538f56fe298cb7bde62891bc71
Author: paulhsia <paulhsia@chromium.org>
Date: Sat Jan 19 08:13:32 2019

dev-rust: Add ebuilds for pkg-config and related crates

To support eclass migration for crosvm ebuild from crate to cros-rust

Since lazy_static is a crate used in pkg-config's dev-dependencies only, we
added an empty crate for it.

BUG=chromium:781398
BUG=chromium:907520
TEST=Run $ emerge-eve dev-rust/pkg-config
     in a clean chroot

Change-Id: I7f8d6df39254563618bb0c31705fd6276ec4fe5e
Reviewed-on: https://chromium-review.googlesource.com/1421301
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: David Tolnay <dtolnay@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/43a270f3248f29538f56fe298cb7bde62891bc71/dev-rust/lazy_static/lazy_static-1.2.0.ebuild
[add] https://crrev.com/43a270f3248f29538f56fe298cb7bde62891bc71/dev-rust/pkg-config/Manifest
[add] https://crrev.com/43a270f3248f29538f56fe298cb7bde62891bc71/dev-rust/pkg-config/pkg-config-0.3.11.ebuild
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 19 (3 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/48489cbf620fbc34da757c7ab0fbfbdb775787ea

commit 48489cbf620fbc34da757c7ab0fbfbdb775787ea
Author: paulhsia <paulhsia@chromium.org>
Date: Sat Jan 19 08:13:33 2019

dev-rust: Add ebuilds for num_cpus crates

To support eclass migration for crosvm ebuild from crate to
cros-rust

BUG=chromium:781398
BUG=chromium:907520
TEST=Run $ emerge-eve dev-rust/num_cpus
     in a clean chroot

Change-Id: I16f871ec5586e8a458831cc922c66bd0d6d1376b
Reviewed-on: https://chromium-review.googlesource.com/1421302
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: David Tolnay <dtolnay@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/48489cbf620fbc34da757c7ab0fbfbdb775787ea/dev-rust/num_cpus/Manifest
[add] https://crrev.com/48489cbf620fbc34da757c7ab0fbfbdb775787ea/dev-rust/num_cpus/num_cpus-1.9.0.ebuild
Project Member

Comment 14 by bugdroid, Today (6 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/b6d842fa56f0ccb9e5084d0e06100c53170d46f7

commit b6d842fa56f0ccb9e5084d0e06100c53170d46f7
Author: paulhsia <paulhsia@chromium.org>
Date: Wed Jan 23 00:53:13 2019

crosvm: Support cros-rust version crosvm ebuild

To support eclass migration for crosvm ebuild from crate to cros-rust.
This CL need to be built with cros-rust version crosvm ebuild.

- Upgrage crate cc from 1.0.15 to 1.0.25.
- Change local tempdir version from 0.3.5 to 0.3.7 for ebuild
integration.
- Remove 9s directory since it's moved to platform2.

BUG=chromium:781398
BUG=chromium:907520
TEST=Run $ FEATURES=test emerge-eve crosvm
     in a clean chroot
CQ-DEPEND=CL:1421303

Change-Id: Iab615b555a51f8020e5efae1cc40ac6b54ea87f2
Reviewed-on: https://chromium-review.googlesource.com/1421237
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/x86_64/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/plugin_proto/Cargo.toml
[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/src/main.rs
[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/src/vsock.rs
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/Cargo.lock
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/gpu_display/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/tempdir/Cargo.toml
Project Member

Comment 15 by bugdroid, Today (6 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/799ed9fbf429b82d395645d3d02accd218e05d8a

commit 799ed9fbf429b82d395645d3d02accd218e05d8a
Author: paulhsia <paulhsia@chromium.org>
Date: Wed Jan 23 00:53:13 2019

crosvm: Migrate ebuild from crate.eclass to cros-rust.eclass

To support the flexibility of installing local crate, we need to let
crosvm's ebuild inherit cros-rust.eclass instead of crate.eclass.

BUG=chromium:781398
BUG=chromium:907520
TEST=Remove dev-rust packages by
     $ emerge-${BOARD} -Cav dev-rust/*
     And run
     $ FEATURES=test emerge-${BOARD} crosvm
CQ-DEPEND=CL:1421237

Change-Id: Ib9961d83a5f40b45541a9024d5ee391a3a31bc02
Reviewed-on: https://chromium-review.googlesource.com/1421303
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org>

[modify] https://crrev.com/799ed9fbf429b82d395645d3d02accd218e05d8a/chromeos-base/crosvm/crosvm-9999.ebuild
Project Member

Comment 16 by bugdroid, Today (6 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/b6d842fa56f0ccb9e5084d0e06100c53170d46f7

commit b6d842fa56f0ccb9e5084d0e06100c53170d46f7
Author: paulhsia <paulhsia@chromium.org>
Date: Wed Jan 23 00:53:13 2019

crosvm: Support cros-rust version crosvm ebuild

To support eclass migration for crosvm ebuild from crate to cros-rust.
This CL need to be built with cros-rust version crosvm ebuild.

- Upgrage crate cc from 1.0.15 to 1.0.25.
- Change local tempdir version from 0.3.5 to 0.3.7 for ebuild
integration.
- Remove 9s directory since it's moved to platform2.

BUG=chromium:781398
BUG=chromium:907520
TEST=Run $ FEATURES=test emerge-eve crosvm
     in a clean chroot
CQ-DEPEND=CL:1421303

Change-Id: Iab615b555a51f8020e5efae1cc40ac6b54ea87f2
Reviewed-on: https://chromium-review.googlesource.com/1421237
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/x86_64/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/plugin_proto/Cargo.toml
[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/src/main.rs
[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/src/vsock.rs
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/Cargo.lock
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/gpu_display/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/tempdir/Cargo.toml
Project Member

Comment 17 by bugdroid, Today (6 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/799ed9fbf429b82d395645d3d02accd218e05d8a

commit 799ed9fbf429b82d395645d3d02accd218e05d8a
Author: paulhsia <paulhsia@chromium.org>
Date: Wed Jan 23 00:53:13 2019

crosvm: Migrate ebuild from crate.eclass to cros-rust.eclass

To support the flexibility of installing local crate, we need to let
crosvm's ebuild inherit cros-rust.eclass instead of crate.eclass.

BUG=chromium:781398
BUG=chromium:907520
TEST=Remove dev-rust packages by
     $ emerge-${BOARD} -Cav dev-rust/*
     And run
     $ FEATURES=test emerge-${BOARD} crosvm
CQ-DEPEND=CL:1421237

Change-Id: Ib9961d83a5f40b45541a9024d5ee391a3a31bc02
Reviewed-on: https://chromium-review.googlesource.com/1421303
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org>

[modify] https://crrev.com/799ed9fbf429b82d395645d3d02accd218e05d8a/chromeos-base/crosvm/crosvm-9999.ebuild
Project Member

Comment 18 by bugdroid, Today (6 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/b6d842fa56f0ccb9e5084d0e06100c53170d46f7

commit b6d842fa56f0ccb9e5084d0e06100c53170d46f7
Author: paulhsia <paulhsia@chromium.org>
Date: Wed Jan 23 00:53:13 2019

crosvm: Support cros-rust version crosvm ebuild

To support eclass migration for crosvm ebuild from crate to cros-rust.
This CL need to be built with cros-rust version crosvm ebuild.

- Upgrage crate cc from 1.0.15 to 1.0.25.
- Change local tempdir version from 0.3.5 to 0.3.7 for ebuild
integration.
- Remove 9s directory since it's moved to platform2.

BUG=chromium:781398
BUG=chromium:907520
TEST=Run $ FEATURES=test emerge-eve crosvm
     in a clean chroot
CQ-DEPEND=CL:1421303

Change-Id: Iab615b555a51f8020e5efae1cc40ac6b54ea87f2
Reviewed-on: https://chromium-review.googlesource.com/1421237
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/x86_64/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/plugin_proto/Cargo.toml
[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/src/main.rs
[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/src/vsock.rs
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/Cargo.lock
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/gpu_display/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/tempdir/Cargo.toml
Project Member

Comment 19 by bugdroid, Today (6 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/799ed9fbf429b82d395645d3d02accd218e05d8a

commit 799ed9fbf429b82d395645d3d02accd218e05d8a
Author: paulhsia <paulhsia@chromium.org>
Date: Wed Jan 23 00:53:13 2019

crosvm: Migrate ebuild from crate.eclass to cros-rust.eclass

To support the flexibility of installing local crate, we need to let
crosvm's ebuild inherit cros-rust.eclass instead of crate.eclass.

BUG=chromium:781398
BUG=chromium:907520
TEST=Remove dev-rust packages by
     $ emerge-${BOARD} -Cav dev-rust/*
     And run
     $ FEATURES=test emerge-${BOARD} crosvm
CQ-DEPEND=CL:1421237

Change-Id: Ib9961d83a5f40b45541a9024d5ee391a3a31bc02
Reviewed-on: https://chromium-review.googlesource.com/1421303
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org>

[modify] https://crrev.com/799ed9fbf429b82d395645d3d02accd218e05d8a/chromeos-base/crosvm/crosvm-9999.ebuild
Project Member

Comment 20 by bugdroid, Today (5 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/b6d842fa56f0ccb9e5084d0e06100c53170d46f7

commit b6d842fa56f0ccb9e5084d0e06100c53170d46f7
Author: paulhsia <paulhsia@chromium.org>
Date: Wed Jan 23 00:53:13 2019

crosvm: Support cros-rust version crosvm ebuild

To support eclass migration for crosvm ebuild from crate to cros-rust.
This CL need to be built with cros-rust version crosvm ebuild.

- Upgrage crate cc from 1.0.15 to 1.0.25.
- Change local tempdir version from 0.3.5 to 0.3.7 for ebuild
integration.
- Remove 9s directory since it's moved to platform2.

BUG=chromium:781398
BUG=chromium:907520
TEST=Run $ FEATURES=test emerge-eve crosvm
     in a clean chroot
CQ-DEPEND=CL:1421303

Change-Id: Iab615b555a51f8020e5efae1cc40ac6b54ea87f2
Reviewed-on: https://chromium-review.googlesource.com/1421237
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/x86_64/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/plugin_proto/Cargo.toml
[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/src/main.rs
[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/src/vsock.rs
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/Cargo.lock
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/gpu_display/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/tempdir/Cargo.toml
Project Member

Comment 21 by bugdroid, Today (5 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/799ed9fbf429b82d395645d3d02accd218e05d8a

commit 799ed9fbf429b82d395645d3d02accd218e05d8a
Author: paulhsia <paulhsia@chromium.org>
Date: Wed Jan 23 00:53:13 2019

crosvm: Migrate ebuild from crate.eclass to cros-rust.eclass

To support the flexibility of installing local crate, we need to let
crosvm's ebuild inherit cros-rust.eclass instead of crate.eclass.

BUG=chromium:781398
BUG=chromium:907520
TEST=Remove dev-rust packages by
     $ emerge-${BOARD} -Cav dev-rust/*
     And run
     $ FEATURES=test emerge-${BOARD} crosvm
CQ-DEPEND=CL:1421237

Change-Id: Ib9961d83a5f40b45541a9024d5ee391a3a31bc02
Reviewed-on: https://chromium-review.googlesource.com/1421303
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org>

[modify] https://crrev.com/799ed9fbf429b82d395645d3d02accd218e05d8a/chromeos-base/crosvm/crosvm-9999.ebuild
Project Member

Comment 22 by bugdroid, Today (5 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/b6d842fa56f0ccb9e5084d0e06100c53170d46f7

commit b6d842fa56f0ccb9e5084d0e06100c53170d46f7
Author: paulhsia <paulhsia@chromium.org>
Date: Wed Jan 23 00:53:13 2019

crosvm: Support cros-rust version crosvm ebuild

To support eclass migration for crosvm ebuild from crate to cros-rust.
This CL need to be built with cros-rust version crosvm ebuild.

- Upgrage crate cc from 1.0.15 to 1.0.25.
- Change local tempdir version from 0.3.5 to 0.3.7 for ebuild
integration.
- Remove 9s directory since it's moved to platform2.

BUG=chromium:781398
BUG=chromium:907520
TEST=Run $ FEATURES=test emerge-eve crosvm
     in a clean chroot
CQ-DEPEND=CL:1421303

Change-Id: Iab615b555a51f8020e5efae1cc40ac6b54ea87f2
Reviewed-on: https://chromium-review.googlesource.com/1421237
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/x86_64/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/plugin_proto/Cargo.toml
[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/src/main.rs
[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/src/vsock.rs
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/Cargo.lock
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/gpu_display/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/tempdir/Cargo.toml
Project Member

Comment 23 by bugdroid, Today (5 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/799ed9fbf429b82d395645d3d02accd218e05d8a

commit 799ed9fbf429b82d395645d3d02accd218e05d8a
Author: paulhsia <paulhsia@chromium.org>
Date: Wed Jan 23 00:53:13 2019

crosvm: Migrate ebuild from crate.eclass to cros-rust.eclass

To support the flexibility of installing local crate, we need to let
crosvm's ebuild inherit cros-rust.eclass instead of crate.eclass.

BUG=chromium:781398
BUG=chromium:907520
TEST=Remove dev-rust packages by
     $ emerge-${BOARD} -Cav dev-rust/*
     And run
     $ FEATURES=test emerge-${BOARD} crosvm
CQ-DEPEND=CL:1421237

Change-Id: Ib9961d83a5f40b45541a9024d5ee391a3a31bc02
Reviewed-on: https://chromium-review.googlesource.com/1421303
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org>

[modify] https://crrev.com/799ed9fbf429b82d395645d3d02accd218e05d8a/chromeos-base/crosvm/crosvm-9999.ebuild
►

Sign in to add a comment