New issue
Advanced search Search tips

Issue 907518 link

Starred by 1 user
Status: Assigned
Owner:
georgesak@chromium.org
Cc:
bheenan@chromium.org
privard@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Add SysInfo::DeviceSerialNumber in base/system

Project Member Reported by georgesak@chromium.org, Nov 21 
Currently there's no API in base to get the device serial number. This is needed for enrolling in cloud management on Windows/Mac/Linux.

We should add one:
- For Windows/Linux, we'll use the BIOS serial number
- For Mac, we'll use the system's serial number
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dcdac245ccfd15644984141c7499931f51333c9

commit 4dcdac245ccfd15644984141c7499931f51333c9
Author: Georges Khalil <georgesak@chromium.org>
Date: Wed Nov 28 14:22:56 2018

Add serial_number to base::SysInfo::HardwareInfo (Windows only).

This patch adds the serial number to base::SysInfo::HardwareInfo on
Windows only, where it represents the BIOS serial number. This is
grabbed through a WMI call.

Other platforms will follow.

Bug: 907518
Change-Id: I1b2b23c00cda286f325a0a09722dbfc5e974eb77
Reviewed-on: https://chromium-review.googlesource.com/c/1346869
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Georges Khalil <georgesak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611685}
[modify] https://crrev.com/4dcdac245ccfd15644984141c7499931f51333c9/base/system/sys_info.h
[modify] https://crrev.com/4dcdac245ccfd15644984141c7499931f51333c9/base/system/sys_info_unittest.cc
[modify] https://crrev.com/4dcdac245ccfd15644984141c7499931f51333c9/base/system/sys_info_win.cc
[modify] https://crrev.com/4dcdac245ccfd15644984141c7499931f51333c9/base/win/wmi.cc
[modify] https://crrev.com/4dcdac245ccfd15644984141c7499931f51333c9/base/win/wmi.h
►

Sign in to add a comment