[Unified Plan] SDP without a=msid should create a default stream |
|||||||||||
Issue descriptionsetRemoteDescription with an SDP without a=msid lines should trigger ontrack with a default stream. This makes Unified Plan fail RTCPeerConnection-setRemoteDescription-nomsid.html. The test works in Plan B because it always created default streams.
,
Nov 29
,
Nov 29
,
Nov 29
,
Nov 29
,
Nov 30
,
Dec 3
,
Dec 5
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/5b1477839d8569291b88dfe950089d0ebf34bc8f commit 5b1477839d8569291b88dfe950089d0ebf34bc8f Author: Henrik Boström <hbos@webrtc.org> Date: Wed Dec 05 09:53:21 2018 [Unified Plan] If "a=msid" is missing, create default stream. Prior to this CL, if the "a=msid" attribute was missing it was treated the same as if "no streams" were explicitly signaled (a=msid:-); the receivers would not be associated with any streams. In order to support legacy endpoints that don't recognize "a=msid" that assume the Plan B behavior of a stream being created anyway, this CL creates a stream with a random ID in such cases. For background, see https://github.com/web-platform-tests/wpt/pull/14054. Bug: chromium:907508 Change-Id: I9d9dd0e4ba8f9941f8652f4d7873adc560777cd9 Reviewed-on: https://webrtc-review.googlesource.com/c/112900 Reviewed-by: Seth Hampson <shampson@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25901} [modify] https://crrev.com/5b1477839d8569291b88dfe950089d0ebf34bc8f/api/rtpreceiverinterface.h [modify] https://crrev.com/5b1477839d8569291b88dfe950089d0ebf34bc8f/pc/peerconnection.cc [modify] https://crrev.com/5b1477839d8569291b88dfe950089d0ebf34bc8f/pc/peerconnection.h [modify] https://crrev.com/5b1477839d8569291b88dfe950089d0ebf34bc8f/pc/peerconnection_integrationtest.cc [modify] https://crrev.com/5b1477839d8569291b88dfe950089d0ebf34bc8f/pc/webrtcsdp_unittest.cc
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac4b24325571ba37f7393deeccf199acbd75e5c7 commit ac4b24325571ba37f7393deeccf199acbd75e5c7 Author: Henrik Boström <hbos@chromium.org> Date: Wed Dec 05 10:35:35 2018 Expect "nomsid" test to either PASS or FAIL to unblock roll. A third_party/webrtc CL is about to make this test go from FAIL to PASS (https://webrtc-review.googlesource.com/c/src/+/112900). To unblock the webrtc roll we temporarily expect it to either pass or fail. When the roll is done we can expect it to always pass. TBR=guidou@chromium.org NOTRY=True Bug: 907508 Change-Id: Ied472e116587f35e647d5b5f60147a65557c9a66 Reviewed-on: https://chromium-review.googlesource.com/c/1362895 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#613929} [modify] https://crrev.com/ac4b24325571ba37f7393deeccf199acbd75e5c7/third_party/blink/web_tests/TestExpectations [delete] https://crrev.com/b876b1c3ff1639a37451f31a97b8f1fab5a81b37/third_party/blink/web_tests/platform/linux/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-nomsid-expected.txt [delete] https://crrev.com/b876b1c3ff1639a37451f31a97b8f1fab5a81b37/third_party/blink/web_tests/platform/mac/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-nomsid-expected.txt [delete] https://crrev.com/b876b1c3ff1639a37451f31a97b8f1fab5a81b37/third_party/blink/web_tests/platform/win7/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-nomsid-expected.txt
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b91d919ade43762e2577ec3c11a72de60e24fe0 commit 4b91d919ade43762e2577ec3c11a72de60e24fe0 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Dec 05 15:02:24 2018 Roll src/third_party/webrtc 04744aee2f32..b819ed6df05a (4 commits) https://webrtc.googlesource.com/src.git/+log/04744aee2f32..b819ed6df05a git log 04744aee2f32..b819ed6df05a --date=short --no-merges --format='%ad %ae %s' 2018-12-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2e285ebae2..92bac9a669 (613019:613922) 2018-12-05 solenberg@webrtc.org Reland "Remove CodecInst pt.1" 2018-12-05 hbos@webrtc.org [Unified Plan] If "a=msid" is missing, create default stream. 2018-12-05 artit@webrtc.org Roll chromium_revision 3546854f59..2e285ebae2 (612694:613019) + fix JNI Created with: gclient setdep -r src/third_party/webrtc@b819ed6df05a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:907508,chromium:898660 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia79e53f78d65c77d2d2b2b5a2eab772b5c0de678 Reviewed-on: https://chromium-review.googlesource.com/c/1363234 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613965} [modify] https://crrev.com/4b91d919ade43762e2577ec3c11a72de60e24fe0/DEPS
,
Dec 5
Requesting third_party/webrtc CL in comment 8 (https://webrtc-review.googlesource.com/c/src/+/112900) be merged into M72.
,
Dec 5
Pls apply appropriate OSs label.
,
Dec 5
,
Dec 5
This bug requires manual review: DEPS changes referenced in bugdroid comments. Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 5
Pls update bug with canary result for CL (https://webrtc-review.googlesource.com/c/src/+/112900).
,
Dec 7
The NextAction date has arrived: 2018-12-07
,
Dec 7
hbos@ any update on the test results in canary?
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8e1f9602afa7602824e9d04049b624d464dfcec commit b8e1f9602afa7602824e9d04049b624d464dfcec Author: Henrik Boström <hbos@chromium.org> Date: Mon Dec 10 13:23:34 2018 Reenable "nomsid" test, expecting it to PASS. This was fixed by CL https://webrtc-review.googlesource.com/c/src/+/112900 which was rolled in to chromium by CL https://chromium-review.googlesource.com/c/1363234 TBR=guidou@chromium.org Bug: 907508 Change-Id: I1835b8ff73826aae4b7745dc82b17adb71c12901 Reviewed-on: https://chromium-review.googlesource.com/c/1369932 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#615104} [modify] https://crrev.com/b8e1f9602afa7602824e9d04049b624d464dfcec/third_party/blink/web_tests/TestExpectations
,
Dec 10
Confirmed on Canary using https://codepen.io/anon/pen/yGyyNL?editors=0010. Before the fix (current Stable), console logs "[]". After the fix (current Canary), console logs "[MediaStream]". Requesting to proceed with the merge of https://webrtc-review.googlesource.com/c/src/+/112900.
,
Dec 10
,
Dec 10
,
Dec 10
This is already merge to M72 at #21. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by hbos@chromium.org
, Nov 21