UserContext::IsUsingOAuth is set for Active Directory users on non-initial logins |
||||||||
Issue descriptionUserContext::IsUsingOAuth is set for Active Directory users on non-inital/subsequent/offline logins which has the side effect of https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/session/user_session_manager.cc?l=1375&rcl=317f58e2a231c8d2a36b7c8572b700d01e0e8fc5 being executed. This does not do anything harmful right now but is erroneous.
,
Nov 22
,
Nov 22
Tried above but doesnt work. Please checkout/apply the attached patch.
,
Nov 23
it's actually supposed to be in login_display_host_mojo.cc see https://chromium-review.googlesource.com/c/chromium/src/+/1349323
,
Nov 29
,
Nov 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8bfcaa5334715870513339becc0d38c4db218451 commit 8bfcaa5334715870513339becc0d38c4db218451 Author: Roman Sorokin <rsorokin@chromium.org> Date: Thu Nov 29 10:44:07 2018 Chromad: Set proper IsUsingOAuth in UserContext BUG= chromium:907504 TEST=manual Change-Id: I8b9bad1f16fe539b7e25134b5fdc0d7dd63094a8 Reviewed-on: https://chromium-review.googlesource.com/c/1349323 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#612136} [modify] https://crrev.com/8bfcaa5334715870513339becc0d38c4db218451/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc [modify] https://crrev.com/8bfcaa5334715870513339becc0d38c4db218451/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by ljusten@chromium.org
, Nov 22Owner: rsorokin@chromium.org