New issue
Advanced search Search tips

Issue 907495 link

Starred by 1 user
Status: Assigned
Owner:
sczs@chromium.org
Cc:
mastiz@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Check logic in RecentTabsTableCoordinatorTest

Project Member Reported by olivierrobin@chromium.org, Nov 21 
After https://chromium-review.googlesource.com/c/chromium/src/+/1235278/, all the tests have been removed from recent_tabs_table_coordinator_test.
What remains does not actually test anything.

Check the code, what should be tested and rewrite the tests (or delete them) with the new logic.

Also it is not clear where the logic that was in RecentTabsTableCoordinatorTest is checked now.

Comment 1 by sczs@chromium.org, Nov 27

Status: Assigned (was: Untriaged)
Thanks Olivier!

I think we need to create some new unit_test for recents_tabs_table_view_controller for the logic of what was deleted on the CL you mentioned.

The current recent_tabs_coordinator.h tests are still the same as before, and the SetupSyncState and CreateController method has some EXPECT_CALL calls, where the services and observers setup are being tested. Maybe we need to refactor this so we improve readability? Or maybe I'm completely missing something.
►

Sign in to add a comment