[Tab loading animation] Fade in the favicon placeholder when starting the connecting state |
||||||
Issue descriptionTo reduce visual flicker in instances like reloading a page. Try fading in the favicon placeholder. Opacity 0 to 1, starting with a longer duration like 500ms, standard ease material curve - cubic-bezier(0.4, 0.0, 0.2, 1) Feel free to play with the duration.
,
Nov 22
Let's try the cross fade. With the current favicon faded out faster - 200ms. Helen, please feel free to chime in.
,
Nov 23
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76e02a5b59bd965376946da324fcabd671c12ee2 commit 76e02a5b59bd965376946da324fcabd671c12ee2 Author: Peter Boström <pbos@chromium.org> Date: Tue Dec 04 19:46:57 2018 Add fade-in/fade-out to the favicon placeholder Bug: chromium:903806 , chromium:907494 Change-Id: Iad7e8f22630b842071e16f606a9fb2632415d967 Reviewed-on: https://chromium-review.googlesource.com/c/1359300 Reviewed-by: Sidney San Martín <sdy@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#613655} [modify] https://crrev.com/76e02a5b59bd965376946da324fcabd671c12ee2/chrome/browser/ui/views/tabs/tab_icon.cc [modify] https://crrev.com/76e02a5b59bd965376946da324fcabd671c12ee2/chrome/browser/ui/views/tabs/tab_icon.h
,
Dec 5
Hi pbos@: I checked it in Canary. Now there is a blank gap for a short time to see between the placeholder and the favicon. Before this change there was a nicer transition. Just only wanted to mention it. Probably you are already tuning this - thanks :)
,
Dec 5
Yep, the fade-out should start when the favicon fade-in starts, not when connecting ends. :\
,
Dec 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9b7993b62b6fc90ce6610f65ee59d53d5deedc2 commit b9b7993b62b6fc90ce6610f65ee59d53d5deedc2 Author: Peter Boström <pbos@chromium.org> Date: Thu Dec 06 17:54:45 2018 Add fade-in/fade-out to the favicon placeholder Bug: chromium:903806 , chromium:907494 Change-Id: Iad7e8f22630b842071e16f606a9fb2632415d967 Reviewed-on: https://chromium-review.googlesource.com/c/1359300 Reviewed-by: Sidney San Martín <sdy@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#613655}(cherry picked from commit 76e02a5b59bd965376946da324fcabd671c12ee2) Reviewed-on: https://chromium-review.googlesource.com/c/1365978 Reviewed-by: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#116} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/b9b7993b62b6fc90ce6610f65ee59d53d5deedc2/chrome/browser/ui/views/tabs/tab_icon.cc [modify] https://crrev.com/b9b7993b62b6fc90ce6610f65ee59d53d5deedc2/chrome/browser/ui/views/tabs/tab_icon.h
,
Dec 6
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a225eda5340164ef234ab075631ff5ea09dc2b85 commit a225eda5340164ef234ab075631ff5ea09dc2b85 Author: Peter Boström <pbos@chromium.org> Date: Wed Dec 12 01:49:21 2018 Align favicon fade-in with placeholder fade-out Bug: chromium:907494 Change-Id: I123ff28187f2cc482ae89453e2bd79a2414f9e04 Reviewed-on: https://chromium-review.googlesource.com/c/1372895 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#615773} [modify] https://crrev.com/a225eda5340164ef234ab075631ff5ea09dc2b85/chrome/browser/ui/views/tabs/tab_icon.cc
,
Dec 12
#5 should be fixed now. mehmet@ I'm adding a chrome://flags entry for the flag if you want to keep testing it. See crrev.com/c/1372550
,
Dec 12
,
Dec 12
Thanks, okay. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by pbos@chromium.org
, Nov 21