[Tab loading animation] Make the transition from connecting to loading smoother |
||||||
Issue descriptionCurrently we switch the back and forth connecting animation immediately to the determinate progress. If the bar is all the way to the right, this feels jumpy. We should complete the current cycle of back and forth so the bar returns to the left the make a natural change to the determinate progress bar.
,
Dec 6
Requesting merge for this since the CL for disabling the tab animation is on top of it and they have only been tested in Canary together. :\
,
Dec 6
,
Dec 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6785660439ad65a829f77e2ef3e705e9a315acf8 commit 6785660439ad65a829f77e2ef3e705e9a315acf8 Author: Peter Boström <pbos@chromium.org> Date: Thu Dec 06 18:07:52 2018 Transition between waiting and loading states Changes the tab-loading animation to switch over to the loading-progress bar only after the previous throbber cycle has finished. Bug: chromium:907490 Change-Id: Ie38cec22935c1418f44cfb7760d22886464f3a75 Reviewed-on: https://chromium-review.googlesource.com/c/1361621 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Sidney San Martín <sdy@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#613769}(cherry picked from commit 6d9bc09a9a220ba33492b907a273c6b7d7537510) Reviewed-on: https://chromium-review.googlesource.com/c/1365981 Reviewed-by: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#117} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/6785660439ad65a829f77e2ef3e705e9a315acf8/chrome/browser/ui/views/tabs/tab_icon.cc [modify] https://crrev.com/6785660439ad65a829f77e2ef3e705e9a315acf8/chrome/browser/ui/views/tabs/tab_icon.h [modify] https://crrev.com/6785660439ad65a829f77e2ef3e705e9a315acf8/chrome/browser/ui/views/tabs/tab_unittest.cc [modify] https://crrev.com/6785660439ad65a829f77e2ef3e705e9a315acf8/ui/gfx/paint_throbber.cc [modify] https://crrev.com/6785660439ad65a829f77e2ef3e705e9a315acf8/ui/gfx/paint_throbber.h
,
Dec 6
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6785660439ad65a829f77e2ef3e705e9a315acf8 Commit: 6785660439ad65a829f77e2ef3e705e9a315acf8 Author: pbos@chromium.org Commiter: pbos@chromium.org Date: 2018-12-06 18:07:52 +0000 UTC Transition between waiting and loading states Changes the tab-loading animation to switch over to the loading-progress bar only after the previous throbber cycle has finished. Bug: chromium:907490 Change-Id: Ie38cec22935c1418f44cfb7760d22886464f3a75 Reviewed-on: https://chromium-review.googlesource.com/c/1361621 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Sidney San Martín <sdy@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#613769}(cherry picked from commit 6d9bc09a9a220ba33492b907a273c6b7d7537510) Reviewed-on: https://chromium-review.googlesource.com/c/1365981 Reviewed-by: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#117} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Dec 4