New issue
Advanced search Search tips

Issue 907486 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 731073



Sign in to add a comment

Convert arc_auth_service.cc to use IdentityManager API

Project Member Reported by sdefresne@chromium.org, Nov 21

Issue description

API used
- SigninManagerBase::GetAuthenticatedAccountId()
- signin_ui_util::GetAuthenticatedUsername()
 
Owner: toniki...@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb012abfe8bf1ea39b0e2cf5115849cafb78ab0a

commit bb012abfe8bf1ea39b0e2cf5115849cafb78ab0a
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Mon Nov 26 23:41:21 2018

[s13n] Convert arc_auth_service.cc to use IdentityManager

CL also partially needed to touch bits on signin_ui_util.cc|h
and people_handler.cc, both files properly listed on the BUG=
line below.

BUG= 907486 , 898810 , 890796 

Change-Id: Ic0d39cb14e100ae10375f66ca51fd526f3b2d64a
Reviewed-on: https://chromium-review.googlesource.com/c/1348674
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#610979}
[modify] https://crrev.com/bb012abfe8bf1ea39b0e2cf5115849cafb78ab0a/chrome/browser/chromeos/arc/auth/arc_auth_service.cc
[modify] https://crrev.com/bb012abfe8bf1ea39b0e2cf5115849cafb78ab0a/chrome/browser/signin/signin_ui_util.cc
[modify] https://crrev.com/bb012abfe8bf1ea39b0e2cf5115849cafb78ab0a/chrome/browser/signin/signin_ui_util.h
[modify] https://crrev.com/bb012abfe8bf1ea39b0e2cf5115849cafb78ab0a/chrome/browser/ui/webui/settings/people_handler.cc

Status: Fixed (was: Started)
Cc: sdefresne@chromium.org
 Issue 731073  has been merged into this issue.

Sign in to add a comment