New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 907476 link

Starred by 1 user
Status: Assigned
Owner:
jkrcal@chromium.org
Cc:
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Typed URL sync] Get rid of trivial "if (row.typed_count() >= 0)"

Project Member Reported by jkrcal@chromium.org, Nov 21 
The code in typed_url_sync_bridge has many places where it checks that typed_count read from local database is *not negative* (and silently skips the operation if it is).

I checked the code in the history DB and see no indication that typed_count can ever become negative.

We should replace it by DCHECKs and eventually get rid of it.

Comment 1 by treib@chromium.org, Nov 21 

 Bug 84258  seems to be the cause for adding those checks. Don't know if it still applies.

Comment 2 by jkrcal@chromium.org, Nov 21 

I would understand if the bug were the cause for checking:
  "if (row.typed_count() > 0)".

However, I do not understand how the bug may lead to negative values.

Comment 3 by jkrcal@chromium.org, Yesterday (43 hours ago) 

No progress here.
►

Sign in to add a comment