New issue
Advanced search Search tips

Issue 907422 link

Starred by 2 users
Status: Fixed
Owner:
pbos@chromium.org
Closed: Nov 21
Cc:
pbos@chromium.org
edwardjung@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Tab loading animation] Use a regular rect for throbber

Project Member Reported by pbos@chromium.org, Nov 21 
Now that the throbber is not displayed on top of the placeholder it makes more sense to use a rect for the throbber. Also a round rect inside 2dp is very hard to spot and possibly less performant, though not sure it matters at this resolution.
rect-throbber.mov
84.2 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dcc7f3cd8e708b83eb3cf3886ef4a21039e6a9d

commit 1dcc7f3cd8e708b83eb3cf3886ef4a21039e6a9d
Author: Peter Boström <pbos@chromium.org>
Date: Wed Nov 21 16:00:58 2018

Update the tab-animation throbber style

Removes the round-rect end caps in favor of a rectangular throbber.

The throbber size and timings are also updated. See chromium:907435.

Bug:  chromium:907422 ,  chromium:907435 
Change-Id: I7d7a18a4d19b18361db84de829a93475a57efa44
Reviewed-on: https://chromium-review.googlesource.com/c/1346091
Reviewed-by: Edward Jung <edwardjung@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610083}
[modify] https://crrev.com/1dcc7f3cd8e708b83eb3cf3886ef4a21039e6a9d/chrome/browser/ui/views/tabs/tab_icon.cc
[modify] https://crrev.com/1dcc7f3cd8e708b83eb3cf3886ef4a21039e6a9d/ui/gfx/paint_throbber.cc

Comment 2 by pbos@chromium.org, Nov 21

Status: Fixed (was: Started)

Comment 3 by pbos@chromium.org, Nov 21

Cc: pbos@chromium.org
 Issue 907641  has been merged into this issue.
►

Sign in to add a comment