New issue
Advanced search Search tips

Issue 907402 link

Starred by 1 user
Status: Duplicate
Merged: issue 902685
Owner:
lukasza@chromium.org
Closed: Nov 21
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: virtual/not-site-per-process/http/tests/devtools/isolated-code-cache/same-origin-test.js



Sign in to add a comment

virtual/not-site-per-process/http/tests/devtools/isolated-code-cache/same-origin-test.js is flaky

Project Member Reported by Findit, Nov 21 

Flaky test: virtual/not-site-per-process/http/tests/devtools/isolated-code-cache/same-origin-test.js
Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests%20%28dbg%29/6648
Test output log: https://chromium-swarm.appspot.com/task?id=414d76a6401f3610
Culprit (100.0% confidence): r609379
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy_wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCLIAWNocm9taXVtLm1hYy9NYWMxMC4xMyBUZXN0cyAoZGJnKS82NjQ4L3dlYmtpdF9sYXlvdXRfdGVzdHMgb24gKG5vbmUpIEdQVSBvbiBNYWMvZG1seWRIVmhiQzl1YjNRdGMybDBaUzF3WlhJdGNISnZZMlZ6Y3k5b2RIUndMM1JsYzNSekwyUmxkblJ2YjJ4ekwybHpiMnhoZEdWa0xXTnZaR1V0WTJGamFHVXZjMkZ0WlMxdmNtbG5hVzR0ZEdWemRDNXFjdz09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20virtual/not-site-per-process/http/tests/devtools/isolated-code-cache/same-origin-test.js&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy_wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCLIAWNocm9taXVtLm1hYy9NYWMxMC4xMyBUZXN0cyAoZGJnKS82NjQ4L3dlYmtpdF9sYXlvdXRfdGVzdHMgb24gKG5vbmUpIEdQVSBvbiBNYWMvZG1seWRIVmhiQzl1YjNRdGMybDBaUzF3WlhJdGNISnZZMlZ6Y3k5b2RIUndMM1JsYzNSekwyUmxkblJ2YjJ4ekwybHpiMnhoZEdWa0xXTnZaR1V0WTJGamFHVXZjMkZ0WlMxdmNtbG5hVzR0ZEdWemRDNXFjdz09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).

Comment 1 by andruud@chromium.org, Nov 21

Owner: andruud@chromium.org

Comment 2 by andruud@chromium.org, Nov 21

Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0c7b70288c85be0ee9e91aa0bb7ed68a3058b25

commit f0c7b70288c85be0ee9e91aa0bb7ed68a3058b25
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Wed Nov 21 09:46:40 2018

Mark virtual/.../same-origin-test.js as flaky.

TBR=lukasza@chromium.org

Bug:  907402 
Change-Id: I939381e79f68c912b70207c9412b42d65e74f3a3
Reviewed-on: https://chromium-review.googlesource.com/c/1345077
Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609971}
[modify] https://crrev.com/f0c7b70288c85be0ee9e91aa0bb7ed68a3058b25/third_party/WebKit/LayoutTests/TestExpectations

Comment 5 by andruud@chromium.org, Nov 21

Cc: lukasza@chromium.org
Components: Platform>DevTools
Labels: -Sheriff-Chromium
Owner: ----
Status: Available (was: Started)

Comment 6 by lukasza@chromium.org, Nov 21 

 Issue 907301  has been merged into this issue.

Comment 7 by lukasza@chromium.org, Nov 21

Cc: -lukasza@chromium.org
Owner: lukasza@chromium.org
Status: Started (was: Available)
I think the test is simply slow:

- https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http%2Ftests%2Fdevtools%2Fisolated-code-cache%2Fsame-origin-test.js

  says that the test can take ~3-4 seconds on a release bot
  (e.g. Mac10.13 Tests, Win7 Tests (1))
  and 20+ seconds on a debug or specialized bot
  (e.g. Mac10.13 Tests (dbg), WebKit Linux Trusty ASAN, Win7 Tests (dbg)(1))

- third_party/WebKit/LayoutTests/SlowTests already lists the tests for some configurations
  (but not for the new virtual/not-site-per-process virtual test suite):

  crbug.com/902685 http/tests/devtools/isolated-code-cache/cross-origin-test.js [ Slow ]
  crbug.com/902685 virtual/site-isolated-code-cache/http/tests/devtools/isolated-code-cache/same-origin-test.js [ Slow ]

I'll add appropriate test expectations.
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8164901d8d42f2c4ef636c3068350ce98940b97b

commit 8164901d8d42f2c4ef636c3068350ce98940b97b
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Wed Nov 21 19:30:38 2018

Extend isolated-code-cache=[Slow] to the not-site-per-process suite.

Bug:  907402 , 902685
Change-Id: Ifa530668be9f322a2ae5d92692298c20f98da828
Reviewed-on: https://chromium-review.googlesource.com/c/1347089
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610156}
[modify] https://crrev.com/8164901d8d42f2c4ef636c3068350ce98940b97b/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/8164901d8d42f2c4ef636c3068350ce98940b97b/third_party/WebKit/LayoutTests/TestExpectations

Comment 9 by lukasza@chromium.org, Nov 21

Mergedinto: 902685
Status: Duplicate (was: Started)
►

Sign in to add a comment