Add "open in window" checkbox to non-PWA Create Shortcut dialog |
|||
Issue descriptionChrome Version: 72 OS: Linux, Windows, Chrome OS What steps will reproduce the problem? (1) Go to non-PWA site (this one will do). (2) Menu > More tools > Create shortcut... What is the expected result? Option to open shortcut in its own window. What happens instead? No option to set launch behaviour. Shortcut will open in a tab. We removed this check box from Linux and Windows in Chrome 70 with the launch of PWAs on those platforms. One of the biggest user complaints was the removal of the checkbox to enable shortcuts to open in their own window. Previously we were moving towards opening in a window being a PWA only feature so it made sense to remove it from the Create (non-PWA) shortcut dialog. Now that we're no longer going to make the feature set available to PWAs distinguishable from non-PWAs should we put the checkbox back in Create shortcut?
,
Nov 23
OK, assigning to Alan, when you get time.
,
Nov 23
,
Nov 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4a21288c503b4cf16e0a26a98687cd048bfc814 commit b4a21288c503b4cf16e0a26a98687cd048bfc814 Author: Alan Cutter <alancutter@chromium.org> Date: Mon Nov 26 03:29:20 2018 Add "Open as window" checkbox back to Create shortcut Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=368714&signed_aid=jxynzMCcaUtxgGB-6k_3_w==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=368715&signed_aid=lXnbrTuQdIjEmsYnpGspxA==&inline=1 Bug: 907339 Change-Id: I8ed455084acc4d85f96ecbd3e124c13773bf3e25 Reviewed-on: https://chromium-review.googlesource.com/c/1349136 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#610758} [modify] https://crrev.com/b4a21288c503b4cf16e0a26a98687cd048bfc814/chrome/browser/extensions/bookmark_app_helper.cc [modify] https://crrev.com/b4a21288c503b4cf16e0a26a98687cd048bfc814/chrome/browser/extensions/bookmark_app_helper_unittest.cc [modify] https://crrev.com/b4a21288c503b4cf16e0a26a98687cd048bfc814/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc
,
Nov 26
|
|||
►
Sign in to add a comment |
|||
Comment 1 by hwi@chromium.org
, Nov 22