New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 907326 link

Starred by 1 user
Status: Fixed
Owner:
norvez@chromium.org
Closed: Nov 28
Cc:
█ hllee@chromium.org
norvez@chromium.org
zalcorn@chromium.org
jessejames@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature
Proj-Fingerprints



Sign in to add a comment

Logs of fingerprints matches and enrollments should be human-readable

Project Member Reported by norvez@chromium.org, Nov 21 

For example, instead of:
"
DoMatchEvent result: 3
"

We should log a human-readable string.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/271c6c94a45ad3094ad735c28e50cc957851c1b5

commit 271c6c94a45ad3094ad735c28e50cc957851c1b5
Author: Nicolas Norvez <norvez@chromium.org>
Date: Wed Nov 28 20:47:57 2018

biod: human-readable matcher logs

biod now logs a string detailing the match event instead of the return
code. Same for enrollment events.

BUG= chromium:907326 
TEST=deploy on DUT, verify log entries on match and enroll

Change-Id: I7e4af7ff6d4ccd2476ae70620d1c03eb1c67ed61
Reviewed-on: https://chromium-review.googlesource.com/1351241
Commit-Ready: Nicolas Norvez <norvez@chromium.org>
Tested-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-by: Prashant Malani <pmalani@google.com>

[modify] https://crrev.com/271c6c94a45ad3094ad735c28e50cc957851c1b5/biod/cros_fp_biometrics_manager.cc

Comment 2 by norvez@chromium.org, Nov 28

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 8

Labels: merge-merged-factory-nami-10715.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8f1b61a63244fe7ae96bdd5a5eda8c745af596c5

commit 8f1b61a63244fe7ae96bdd5a5eda8c745af596c5
Author: Nicolas Norvez <norvez@chromium.org>
Date: Sat Dec 08 02:09:23 2018

biod: human-readable matcher logs

biod now logs a string detailing the match event instead of the return
code. Same for enrollment events.

BUG= chromium:907326 
TEST=deploy on DUT, verify log entries on match and enroll

Change-Id: I7e4af7ff6d4ccd2476ae70620d1c03eb1c67ed61
Reviewed-on: https://chromium-review.googlesource.com/1351241
Commit-Ready: Nicolas Norvez <norvez@chromium.org>
Tested-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-by: Prashant Malani <pmalani@google.com>
(cherry picked from commit 271c6c94a45ad3094ad735c28e50cc957851c1b5)
Reviewed-on: https://chromium-review.googlesource.com/c/1362369
Reviewed-by: YH Lin <yueherngl@chromium.org>
Commit-Queue: YH Lin <yueherngl@chromium.org>
Tested-by: YH Lin <yueherngl@chromium.org>

[modify] https://crrev.com/8f1b61a63244fe7ae96bdd5a5eda8c745af596c5/biod/cros_fp_biometrics_manager.cc
►

Sign in to add a comment