desktopui_MashLogin crashes when we switch to MojoVideoDecoder |
|||
Issue descriptionBackground: crbug.com/902870 When we switch from GpuVideoDecoder to MojoVideoDecoder, we hit the crash when running desktopui_MashLogin. https://cs.chromium.org/chromium/src/content/browser/gpu/compositor_util.cc?q=compositor_util.cc&sq=package:chromium&dr&l=86 ImageTransportFactory::GetInstance() return nullptr after switching to MojoVideoDecoder. We need to handle nullptr first before calling its method. Confirm this issue not happen again when we enable MojoVideoDecoder again.
,
Nov 30
gpu triage: moving to assigned as this seems to have an owner.
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b461e376e824c72fec1d6d91cd6633ba344dd55 commit 8b461e376e824c72fec1d6d91cd6633ba344dd55 Author: Chih-Yu Huang <akahuang@google.com> Date: Wed Dec 05 02:13:19 2018 compositor_util: Fix the crash when querying Gpu status. ImageTransportFactory::GetInstance() might return a nullptr. To avoid this, we always return Enabled for mash. BUG= chromium:907320 TEST=Turn on feature 'MojoVideoDecoder' and run autotest 'desktopui_MashLogin' Change-Id: Ic71fd4db266d5f871b27b973a883098db8389f7b Reviewed-on: https://chromium-review.googlesource.com/c/1341781 Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#613819} [modify] https://crrev.com/8b461e376e824c72fec1d6d91cd6633ba344dd55/content/browser/gpu/compositor_util.cc
,
Dec 5
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sande...@chromium.org
, Nov 21