New issue
Advanced search Search tips

Issue 907316 link

Starred by 0 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Remove overview text field.

Project Member Reported by sammiequon@chromium.org, Nov 21

Issue description

Waiting on UI review for final confirmation.


 
Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4406472eab212408729a2ac4a6358529b34a87a

commit c4406472eab212408729a2ac4a6358529b34a87a
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Jan 16 01:44:55 2019

overview: Removes text selector.

This is not used much in its current form according to UMA stats. May be
readded in the future.

The text selector used to handle key events, so make window selector a
event handler to handle the key events now.

The text selector used to also grab focus on entering overview, a new
|overview_focus_window_| does that now. We need that because accessiblity
needs a focused window to work, and we cannot use one of the transformed
windows or else activation will not work. I'll look into perhaps focusing
the tab highlight window in a later patch.

Test: manual
Bug: 907316, 914147
Change-Id: I7d1e292b440edd4ec1c724297b10d9307041c96c
Reviewed-on: https://chromium-review.googlesource.com/c/1391738
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622995}
[modify] https://crrev.com/c4406472eab212408729a2ac4a6358529b34a87a/ash/ash_strings.grd
[modify] https://crrev.com/c4406472eab212408729a2ac4a6358529b34a87a/ash/resources/vector_icons/BUILD.gn
[delete] https://crrev.com/9cd665ec7aad53bd72476bb3bde8ed8eb78b9da9/ash/resources/vector_icons/overview_text_filter_search.icon
[modify] https://crrev.com/c4406472eab212408729a2ac4a6358529b34a87a/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/c4406472eab212408729a2ac4a6358529b34a87a/ash/wm/overview/window_grid.h
[modify] https://crrev.com/c4406472eab212408729a2ac4a6358529b34a87a/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/c4406472eab212408729a2ac4a6358529b34a87a/ash/wm/overview/window_selector.h
[modify] https://crrev.com/c4406472eab212408729a2ac4a6358529b34a87a/ash/wm/overview/window_selector_item.cc
[modify] https://crrev.com/c4406472eab212408729a2ac4a6358529b34a87a/ash/wm/overview/window_selector_item.h
[modify] https://crrev.com/c4406472eab212408729a2ac4a6358529b34a87a/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/c4406472eab212408729a2ac4a6358529b34a87a/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/c4406472eab212408729a2ac4a6358529b34a87a/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fa565d9a9d1b5acaf75e6819978198161114a80

commit 4fa565d9a9d1b5acaf75e6819978198161114a80
Author: Sammie Quon <sammiequon@chromium.org>
Date: Wed Jan 16 02:22:29 2019

Revert "overview: Removes text selector."

This reverts commit c4406472eab212408729a2ac4a6358529b34a87a.

Reason for revert: Did not mean to land without CQ

Original change's description:
> overview: Removes text selector.
> 
> This is not used much in its current form according to UMA stats. May be
> readded in the future.
> 
> The text selector used to handle key events, so make window selector a
> event handler to handle the key events now.
> 
> The text selector used to also grab focus on entering overview, a new
> |overview_focus_window_| does that now. We need that because accessiblity
> needs a focused window to work, and we cannot use one of the transformed
> windows or else activation will not work. I'll look into perhaps focusing
> the tab highlight window in a later patch.
> 
> Test: manual
> Bug: 907316, 914147
> Change-Id: I7d1e292b440edd4ec1c724297b10d9307041c96c
> Reviewed-on: https://chromium-review.googlesource.com/c/1391738
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622995}

TBR=oshima@chromium.org,afakhry@chromium.org,sammiequon@chromium.org

Change-Id: If1fc415fe51084e5caf0b7f68b50db34c9e4c876
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 907316, 914147
Reviewed-on: https://chromium-review.googlesource.com/c/1414011
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623048}
[modify] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/ash/ash_strings.grd
[modify] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/ash/resources/vector_icons/BUILD.gn
[add] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/ash/resources/vector_icons/overview_text_filter_search.icon
[modify] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/ash/wm/overview/window_grid.h
[modify] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/ash/wm/overview/window_selector.h
[modify] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/ash/wm/overview/window_selector_item.cc
[modify] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/ash/wm/overview/window_selector_item.h
[modify] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/4fa565d9a9d1b5acaf75e6819978198161114a80/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ce9898d72e8892db1303dd0f774fc944f05fcb5

commit 8ce9898d72e8892db1303dd0f774fc944f05fcb5
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Jan 16 04:36:44 2019

Reland "overview: Removes text selector."

This is a reland of c4406472eab212408729a2ac4a6358529b34a87a

Original change's description:
> overview: Removes text selector.
>
> This is not used much in its current form according to UMA stats. May be
> readded in the future.
>
> The text selector used to handle key events, so make window selector a
> event handler to handle the key events now.
>
> The text selector used to also grab focus on entering overview, a new
> |overview_focus_window_| does that now. We need that because accessiblity
> needs a focused window to work, and we cannot use one of the transformed
> windows or else activation will not work. I'll look into perhaps focusing
> the tab highlight window in a later patch.
>
> Test: manual
> Bug: 907316, 914147
> Change-Id: I7d1e292b440edd4ec1c724297b10d9307041c96c
> Reviewed-on: https://chromium-review.googlesource.com/c/1391738
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622995}

TBR=oshima@chromium.org

Bug: 907316, 914147
Change-Id: I7f55cc0ea6ca70ed02fbf78c64c190ffb2fef667
Reviewed-on: https://chromium-review.googlesource.com/c/1414430
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623106}
[modify] https://crrev.com/8ce9898d72e8892db1303dd0f774fc944f05fcb5/ash/ash_strings.grd
[modify] https://crrev.com/8ce9898d72e8892db1303dd0f774fc944f05fcb5/ash/resources/vector_icons/BUILD.gn
[delete] https://crrev.com/7ab8a0d8db39581d6320ccacf990da413a9a2f45/ash/resources/vector_icons/overview_text_filter_search.icon
[modify] https://crrev.com/8ce9898d72e8892db1303dd0f774fc944f05fcb5/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/8ce9898d72e8892db1303dd0f774fc944f05fcb5/ash/wm/overview/window_grid.h
[modify] https://crrev.com/8ce9898d72e8892db1303dd0f774fc944f05fcb5/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/8ce9898d72e8892db1303dd0f774fc944f05fcb5/ash/wm/overview/window_selector.h
[modify] https://crrev.com/8ce9898d72e8892db1303dd0f774fc944f05fcb5/ash/wm/overview/window_selector_item.cc
[modify] https://crrev.com/8ce9898d72e8892db1303dd0f774fc944f05fcb5/ash/wm/overview/window_selector_item.h
[modify] https://crrev.com/8ce9898d72e8892db1303dd0f774fc944f05fcb5/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/8ce9898d72e8892db1303dd0f774fc944f05fcb5/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/8ce9898d72e8892db1303dd0f774fc944f05fcb5/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc

Sign in to add a comment