New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 907312 link

Starred by 1 user
Status: Fixed
Owner:
hansberry@chromium.org
Closed: Nov 26
Cc:
█ jlklein@chromium.org
hsuregan@chromium.org
nohle@chromium.org
khorimoto@chromium.org
█ jhawkins@chromium.org
hansberry@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Spammy debug info eats terminal

Project Member Reported by michae...@chromium.org, Nov 21 
In Chrome OS on Linux, when signing in from the login screen or OOBE, cryptauth_api_call_flow.cc prints out an error message that takes up more than my visible terminal space.

This particular call was upgraded from INFO to ERROR in https://chromium-review.googlesource.com/c/1313762. Does it really need to be printed? Can it be suppressed if not running on CrOS?

Steps:
1. build on linux with target_os = "chromeos"
2. launch with --login-manager --login-profile=user
3. complete OOBE and sign into a google account OR sign into an already set up account

Output: https://paste.googleplex.com/6506009023479808

Comment 1 by hansberry@chromium.org, Nov 21

Cc: jhawkins@chromium.org jlklein@chromium.org khorimoto@chromium.org nohle@chromium.org hsuregan@chromium.org hansberry@chromium.org
Components: UI>Multidevice
Status: Started (was: Assigned)
Yeah, that's gross. Thanks for filing this issue. Fix at https://chromium-review.googlesource.com/c/chromium/src/+/1345126
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30cdf72f4c40590d5b1d84c664962f0db0551b8e

commit 30cdf72f4c40590d5b1d84c664962f0db0551b8e
Author: Ryan Hansberry <hansberry@chromium.org>
Date: Wed Nov 21 23:07:04 2018

[CrOS MultiDevice] Make spammy log in CryptAuthApiCallFlow more useful.

Bug:  907312 
Change-Id: If3efbb895fa8ed77330e5879c8608ee92b8497ef
Reviewed-on: https://chromium-review.googlesource.com/c/1345126
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610255}
[modify] https://crrev.com/30cdf72f4c40590d5b1d84c664962f0db0551b8e/components/cryptauth/cryptauth_api_call_flow.cc

Comment 3 by jhawkins@chromium.org, Nov 26 

Fixed?

Comment 4 by hansberry@chromium.org, Nov 26

Status: Fixed (was: Started)
Fixed. :)
►

Sign in to add a comment