DevTools: Add column for "Resource size" |
|||
Issue descriptionCurrently the "size" column reflects "transfer size", but this is confusing if items are cached, or delivered more interesting ways. (service worker, or from chrome:// pages) Of course one can toggle the "large request rows" button, but then you can't sort by transfer size. Proposal: * Rename 'size' to 'transfer size' * Add 'resource size' column, which is hidden by default.
,
Nov 21
hey all, I think just accounting for the resource size (the semi-hidden subitem) in the SizeComparator and possibly adding a "resource size" summary item (like the transfer size summary) should be sufficient. i've implemented that here: https://chromium-review.googlesource.com/c/chromium/src/+/1345232 screenshot: https://imgur.com/XQRYtWj let me know what you think.
,
Dec 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9db071326bddef09abe1ac7a2d149e2a346be724 commit 9db071326bddef09abe1ac7a2d149e2a346be724 Author: Dan Beam <dbeam@chromium.org> Date: Sat Dec 01 18:41:20 2018 devtools: make Network more useful for internal (e.g. chrome://) URLs The Size column of Network panel shows "0 B" for every request when no bytes are actually transferred over the network. Enabling "large rows" is great as it shows the resource size as well, but sorting doesn't take the resource size into account as a secondary factor. This CL fixes that. I also added a summary view of the resource sizes (very similar to the network bytes transferred summary) to the bottom start end of network tab. Screenshot: https://imgur.com/XQRYtWj R=alph@chromium.org BUG= 907289 Change-Id: I35d69cb617113b0094f6cc2a368b6180c90c2772 Reviewed-on: https://chromium-review.googlesource.com/c/1345232 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Paul Irish <paulirish@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#612937} [modify] https://crrev.com/9db071326bddef09abe1ac7a2d149e2a346be724/third_party/blink/renderer/devtools/front_end/network/NetworkDataGridNode.js [modify] https://crrev.com/9db071326bddef09abe1ac7a2d149e2a346be724/third_party/blink/renderer/devtools/front_end/network/NetworkLogView.js
,
Dec 5
,
Dec 6
by the way, I don't think folks working on chrome:// pages need a separate "resource size" column now that there's a secondary sort key on resource size (if transfer sizes are the same, i.e. both 0).
,
Dec 6
sg |
|||
►
Sign in to add a comment |
|||
Comment 1 by dbeam@chromium.org
, Nov 21