New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 907288 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit 20 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Youtube fullscreen regression

Project Member Reported by dongseon...@intel.com, Nov 21

Issue description

Youtube fullscreen video used to have a bunch of black color quads and video quad, which allows EliminateOrCropPrimary optimization (i.e. minimize black primary plane).
However, recent Youtube UI update causes Youtube fullscreen video has strange TILED_CONTENT quads whose opacity is unfortunately 1.0 but just transparent.

e.g. fullscreen in https://youtu.be/LXb3EKWsInQ 
[3821:3821:1120/161229.284068:ERROR:overlay_processor.cc(283)] material:TILED_CONTENT rect:0,0 2400x130 opacity:1
[3821:3821:1120/161229.284854:ERROR:overlay_processor.cc(283)] material:TILED_CONTENT rect:0,0 2400x415 opacity:1
[3821:3821:1120/161229.285463:ERROR:overlay_processor.cc(283)] material:TILED_CONTENT rect:0,1243 2400x357 opacity:1

As it's TILED_CONTENT quad, viz compositor cannot optimize further. I think Google Chrome team should give the guide to Youtube team to avoid this regression.
 
I'm trying to reland Kristian's crop patch https://chromium-review.googlesource.com/c/chromium/src/+/1346997
Even though this optimization, youtube fullscreen still require full 2 planes because of the transparent TILED_CONTENT quads.
I think there are 2 options.
1. youtube fullscreen fixes it.
2. skia is smart enough to notify "it's nothing" to the viz compositor.
Hi Dongseong, thanks for taking a look at this. When the CL was reverted there were a lot of regressions reported and it coincided with another CL that was reverted. It was never clear to me which CL caused the problem, but we should double check the issues that popped up last time:

  https://bugs.chromium.org/p/chromium/issues/detail?id=901055
  https://bugs.chromium.org/p/chromium/issues/detail?id=900373
  https://bugs.chromium.org/p/chromium/issues/detail?id=900744


#12 - yes, I check new patch set fixed all of the issues. As the CL mentioned, the root issue is in the following code.

  OverlayCandidateList new_candidate_list;
  if (candidate_list->size() == 1) {
    OverlayProcessor::EliminateOrCropPrimary(*quad_list, best_quad_it, &candidate_list->back(),
                                             &new_candidate_list);
  } else {
    new_candidate_list = *candidate_list;
  }

  // Check for support.
  capability_checker_->CheckOverlaySupport(&new_candidate_list);

Blackout happened because overlay strategy cropped the primary plane, no matter the overlay attempt succeed or not. See OverlayProcessor::EliminateOrCropPrimary changes |uv_rect| of candidate_list->back().

SingleOnTop or Underlay fails overlay for 2k or 4k video or something big resolution layer and vis compositor renders the primary plane with stale |uv_rect|. Users see blackout.
I see, thanks for the explanation.
Owner: dongseon...@intel.com
Status: Assigned (was: Untriaged)
Marking assigned as Dongseong appears to be investigating. If you are no longer investigating, please mark as Untriaged and we'll re-assign.

Sign in to add a comment