Crostini: Download shared files are still accessible after deleting from settings |
|||
Issue descriptionChrome Version: 72.0.3612.0 Chrome OS Version: 11280.0.0 Chrome OS Platform: Eve Network info: WiFi Please specify Cr-* of the system to which this bug/feature applies (add the label below). Steps To Reproduce: (1) Install linux from settings. (2) Open Files app (3) Right click on Downloads and select shares with linux. (4) Open Linux terminal and run "ls /mnt/chromeos/MyFiles/Downloads/" (5) Observe Downloads files. (6) Open chrome://settings/crostini/sharedPaths?search=linux in browser. (7) Observe shared folders. (8) Delete Downloads shared file. (9)Open Linux terminal and run "ls /mnt/chromeos/MyFiles/Downloads/" (10) Observe Downloads files. Expected Result: - Deleted shared files no longer available Actual Result: - Files are still accessible and available for use. How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always Please check below observation video. Feedback report : https://listnr.corp.google.com/report/85798936396
,
Nov 21
Thanks Avinash, I've got a fix for this coming soon.
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5953386cf86a633063215375318db5834939ccd3 commit 5953386cf86a633063215375318db5834939ccd3 Author: Joel Hockey <joelhockey@chromium.org> Date: Wed Nov 21 01:55:12 2018 Settings WebUI: Log error in C++ backend when crostini unshare path fails. Bug: 907256 Change-Id: If223956a330497b4b0318f91e4ea6c941d94b5aa Reviewed-on: https://chromium-review.googlesource.com/c/1345377 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#609890} [modify] https://crrev.com/5953386cf86a633063215375318db5834939ccd3/chrome/browser/ui/webui/settings/chromeos/crostini_handler.cc
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d63b5ff7164488c7d24d1b1a5df6df7c4af7301 commit 6d63b5ff7164488c7d24d1b1a5df6df7c4af7301 Author: Joel Hockey <joelhockey@chromium.org> Date: Wed Nov 21 02:13:18 2018 Crostini share: fix unshare to work for filesystem roots Fixed file_manager::path_util::ConvertFileSystemURLToPathsInsideCrostini to correctly handle filesystem roots. Added tests for path_util, and crostini unshare. Bug: 907256 Change-Id: I0397c45330dae0d2a88f3d1f83c0a9c3a1349337 Reviewed-on: https://chromium-review.googlesource.com/c/1345379 Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#609900} [modify] https://crrev.com/6d63b5ff7164488c7d24d1b1a5df6df7c4af7301/chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc [modify] https://crrev.com/6d63b5ff7164488c7d24d1b1a5df6df7c4af7301/chrome/browser/chromeos/file_manager/path_util.cc [modify] https://crrev.com/6d63b5ff7164488c7d24d1b1a5df6df7c4af7301/chrome/browser/chromeos/file_manager/path_util_unittest.cc
,
Nov 21
,
Nov 21
Avinash, please verify the fix! Joel, when you add a tast test for this particular unmount case, please reference to this bug for better tracking.
,
Jan 7
This feature is now available in M73. I'll verify this in M73. |
|||
►
Sign in to add a comment |
|||
Comment 1 by avkodipelli@chromium.org
, Nov 20