New issue
Advanced search Search tips

Issue 907245 link

Starred by 1 user
Status: Fixed
Owner:
abhishekbh@chromium.org
Closed: Nov 27
Cc:
hugobenichi@google.com
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Removed deprecated GetNetworksDeprecated API

Project Member Reported by abhishekbh@chromium.org, Nov 20 
Removed deprecated GetNetworksDeprecated API
from components/arc/net/arc_net_host_impl.cc.

No ARC++ version in the wild should be using this now.

Comment 2 by hugobenichi@google.com, Nov 20

Cc: hugobenichi@google.com
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06de9b74b555c612be347352445fb8dc5344cb45

commit 06de9b74b555c612be347352445fb8dc5344cb45
Author: Abhishek Bhardwaj <abhishekbh@chromium.org>
Date: Tue Nov 27 03:20:02 2018

arc: Remove deprecated GetNetworks API

This changes removes the deprecated GetNetworks API.

BUG= 907245 
TEST=Boot and test ARC++ WiFi apps.

Change-Id: Iec0f9e18ba6a709af6e40d205503e5c1bf2545cb
Reviewed-on: https://chromium-review.googlesource.com/c/1344991
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611013}
[modify] https://crrev.com/06de9b74b555c612be347352445fb8dc5344cb45/components/arc/common/net.mojom
[modify] https://crrev.com/06de9b74b555c612be347352445fb8dc5344cb45/components/arc/net/arc_net_host_impl.cc
[modify] https://crrev.com/06de9b74b555c612be347352445fb8dc5344cb45/components/arc/net/arc_net_host_impl.h

Comment 4 by abhishekbh@chromium.org, Nov 27

Status: Fixed (was: Assigned)

Comment 5 by hugobenichi@google.com, Nov 27 

We should clean up the code on the arc-nyc-mr1 branch as well. Is that done
?

On Tue, Nov 27, 2018, 12:25 PM abhishekbh via monorail <
monorail+v2.1020923372@chromium.org wrote:
►

Sign in to add a comment