Browser.Tabs.SelectionToVisibilityRequestTime metric is broken |
||
Issue descriptionThe metric Browser.Tabs.SelectionToVisibilityRequestTime is not reported anymore. The culprit CL is https://chromium-review.googlesource.com/c/chromium/src/+/1314508 See notes in https://chromium-review.googlesource.com/c/chromium/src/+/1314508/7#message-8e90e9f8c423e90dd1adf3cbdb86599288533802
,
Nov 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06d779c4cbe9b07663f14915801a037497e40335 commit 06d779c4cbe9b07663f14915801a037497e40335 Author: sangwoo.ko <sangwoo.ko@navercorp.com> Date: Mon Nov 26 18:10:11 2018 Use RenderWidgetHostVisibilityTracker correctly RenderWidgetHostVisibilityTracker should outlive OnTabStripModelChanged(). Bug: 907237 Change-Id: I784140523076ba2472a04b98b0840f0bd75ba50d Reviewed-on: https://chromium-review.googlesource.com/c/1345750 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#610888} [modify] https://crrev.com/06d779c4cbe9b07663f14915801a037497e40335/chrome/browser/ui/tabs/tab_strip_model.cc [modify] https://crrev.com/06d779c4cbe9b07663f14915801a037497e40335/chrome/browser/ui/tabs/tab_strip_model.h
,
Nov 29
I can see rowser.Tabs.SelectionToVisibilityRequestTime on chrome://histograms. (72.0.3624.0 canary) please let me know if it's still reproducible. Thanks :) |
||
►
Sign in to add a comment |
||
Comment 1 by sangwoo108@chromium.org
, Nov 21