AEC3 Metrics are missing for the API call jitter |
||
Issue descriptionIn AEC3, the value of the API call jitter is important as it has an impact of the performance. It furthermore has an impact of the call experience as it is an indicator of the size of the audio buffers. Because of that, it is important to have proper logging of this, which currently is missing.
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3f9b27fbe6ff3ef5bf6fe209698d2741476b253 commit c3f9b27fbe6ff3ef5bf6fe209698d2741476b253 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Nov 28 06:34:08 2018 Roll src/third_party/webrtc 59cfd3543875..0d007d7c4f11 (10 commits) https://webrtc.googlesource.com/src.git/+log/59cfd3543875..0d007d7c4f11 git log 59cfd3543875..0d007d7c4f11 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision aed902039c..b04e513f82 (611312:611432) 2018-11-28 jeroendb@webrtc.org Fix raddr on srflx and relay candidates 2018-11-27 qingsi@webrtc.org Revert "Delay call to Destroy until after SignalDone has finished firing." 2018-11-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 81c26a093b..aed902039c (611047:611312) 2018-11-27 zstein@webrtc.org Delay call to Destroy until after SignalDone has finished firing. 2018-11-27 peah@webrtc.org AEC3: Add metrics for API call jitter 2018-11-27 jakobi@webrtc.org Add PeerConnection option to configure minimum audio jitter buffer delay. 2018-11-27 artit@webrtc.org Fix webrtc-internal configs to run perf tests on separate bots 2018-11-27 terelius@webrtc.org Batch RTC event log output if using the new wire format. 2018-11-27 jakobi@webrtc.org Expose delayed packet outage as a cumulative metric of samples in the new getStats API. Created with: gclient setdep -r src/third_party/webrtc@0d007d7c4f11 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:905690,chromium:905542,chromium:None,chromium:905542,chromium:907234 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I956aed4c208a54a3ab6446e9ab8780d9f08669f2 Reviewed-on: https://chromium-review.googlesource.com/c/1352608 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611578} [modify] https://crrev.com/c3f9b27fbe6ff3ef5bf6fe209698d2741476b253/DEPS
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86563ef37d719e1c9ae748eacaa1e0a3551cbf1b commit 86563ef37d719e1c9ae748eacaa1e0a3551cbf1b Author: Per Åhgren <peah@chromium.org> Date: Wed Nov 28 08:43:44 2018 Adding histogram for API call jitter in WebRTC/AEC3 This CL adds histograms to monitor the API call jitter that is observed in AEC3 in WebRTC. The WebRTC CL for adding the histograms is https://webrtc-review.googlesource.com/c/src/+/111580 The metrics for the API call jitter is the minimum and maximum calls API calls in a row (in units blocks of 8ms) observed for capture and render. Bug: chromium:907234 Change-Id: I7f6d45b9f5826f6f7706a6ec3644ec0c35a3da00 Reviewed-on: https://chromium-review.googlesource.com/c/1345012 Commit-Queue: Per Åhgren <peah@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611600} [modify] https://crrev.com/86563ef37d719e1c9ae748eacaa1e0a3551cbf1b/tools/metrics/histograms/histograms.xml
,
Nov 29
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Nov 27