New issue
Advanced search Search tips

Issue 907232 link

Starred by 1 user
Status: Fixed
Owner:
iclell...@chromium.org
Closed: Nov 22
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

Feature policy report format is incorrect

Project Member Reported by iclell...@chromium.org, Nov 20 
The reports generated by feature policy violations are incorrect in two ways:

Report type should be "feature-policy-violation" (presently "feature-policy")
Report feature name field should be "featureId" (presently "feature")
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a

commit aa5ddc8f58d3c8a9441def55eaa0996111d8f56a
Author: Ian Clelland <iclelland@chromium.org>
Date: Thu Nov 22 15:55:59 2018

Fix Feature Policy report output

This brings the feature policy report format in line with the spec,
and fixes the tests which were broken by WPT import.

Bug:  907232 
Change-Id: If9d9469956221c18a1aa72ee39debb1340efc01f
Reviewed-on: https://chromium-review.googlesource.com/c/1338167
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610427}
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/content/browser/net/reporting_service_proxy.cc
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/resources/common.js
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/camera-report-only.https.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/camera-reporting.https.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/document-write-report-only.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/document-write-reporting.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/encrypted-media-report-only.https.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/encrypted-media-reporting.https.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/fullscreen-report-only.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/fullscreen-reporting.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/generic-sensor-report-only.https.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/generic-sensor-reporting.https.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/geolocation-report-only.https.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/geolocation-reporting.https.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/microphone-report-only.https.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/microphone-reporting.https.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/midi-report-only.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/midi-reporting.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/payment-report-only.https.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/payment-reporting.https.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/picture-in-picture-report-only.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/picture-in-picture-reporting.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/sync-xhr-report-only.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/sync-xhr-reporting.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/unsized-media-reporting.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/usb-report-only.https.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/usb-reporting.https.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/vr-report-only.https.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/vr-reporting.https.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/xr-report-only.https.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/xr-reporting.https.html
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/blink/public/platform/reporting.mojom
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/blink/renderer/core/frame/feature_policy_violation_report_body.h
[modify] https://crrev.com/aa5ddc8f58d3c8a9441def55eaa0996111d8f56a/third_party/blink/renderer/core/frame/feature_policy_violation_report_body.idl

Comment 2 by iclell...@chromium.org, Nov 22

Status: Fixed (was: Started)
►

Sign in to add a comment