Implement a tast test to verify crostini file sharing for * Downloads * Drive - My Drive - Team Drives - Computers * removable media (if possible) * Android
Targeting M-72 for tast tests.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71a4de04dbef38f74a64cd861b69d53fdba6d5ba commit 71a4de04dbef38f74a64cd861b69d53fdba6d5ba Author: Joel Hockey <joelhockey@chromium.org> Date: Fri Nov 30 04:09:16 2018 FilesApp: utils needed for crostini sharing tast test To be used in tast test: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/1351973 * Added chrome.fileManagerPrivate.unsharePathWithCrostini. This function complements the existing fileManagerPrivate.sharePathsWithCrostini. * Added util.getEntries which returns a Promise with an object of all entries of a provided volume keyed by fullPath. This is a handy wrapper over the existing util.readEntriesRecursively. Bug: 907231 Change-Id: Ieccdc76a6457fed44d85633e9a02c658424b967d Reviewed-on: https://chromium-review.googlesource.com/c/1354755 Reviewed-by: Stuart Langley <slangley@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#612555} [modify] https://crrev.com/71a4de04dbef38f74a64cd861b69d53fdba6d5ba/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc [modify] https://crrev.com/71a4de04dbef38f74a64cd861b69d53fdba6d5ba/chrome/browser/chromeos/extensions/file_manager/private_api_misc.h [modify] https://crrev.com/71a4de04dbef38f74a64cd861b69d53fdba6d5ba/chrome/common/extensions/api/file_manager_private.idl [modify] https://crrev.com/71a4de04dbef38f74a64cd861b69d53fdba6d5ba/chrome/common/extensions/api/file_manager_private_internal.idl [modify] https://crrev.com/71a4de04dbef38f74a64cd861b69d53fdba6d5ba/chrome/renderer/resources/extensions/file_manager_private_custom_bindings.js [modify] https://crrev.com/71a4de04dbef38f74a64cd861b69d53fdba6d5ba/chrome/test/data/extensions/api_test/file_browser/crostini_test/test.js [modify] https://crrev.com/71a4de04dbef38f74a64cd861b69d53fdba6d5ba/extensions/browser/extension_function_histogram_value.h [modify] https://crrev.com/71a4de04dbef38f74a64cd861b69d53fdba6d5ba/third_party/closure_compiler/externs/file_manager_private.js [modify] https://crrev.com/71a4de04dbef38f74a64cd861b69d53fdba6d5ba/tools/metrics/histograms/enums.xml [modify] https://crrev.com/71a4de04dbef38f74a64cd861b69d53fdba6d5ba/ui/file_manager/file_manager/common/js/BUILD.gn [modify] https://crrev.com/71a4de04dbef38f74a64cd861b69d53fdba6d5ba/ui/file_manager/file_manager/common/js/util.js [modify] https://crrev.com/71a4de04dbef38f74a64cd861b69d53fdba6d5ba/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/89d774241f691102c750100831b6404b3e7c8b9b commit 89d774241f691102c750100831b6404b3e7c8b9b Author: Joel Hockey <joelhockey@chromium.org> Date: Tue Dec 04 04:32:07 2018 tast-tests: Test sharing files with crostini * Add chrome.ExtensionBackgrounPageURL * Add static vm.Container.DefaultContainerCommand function to allow reuse of code for running a vsh command in the default container. * vm.CrostiniFiles test updated to create files within Downloads and share/unshare them with the container, and verify files are accessible in the container as expected. BUG= chromium:907231 TEST=vm.CrostiniFiles Change-Id: I2573125da2db8371f0bc181e467d971bfdd0bb44 Reviewed-on: https://chromium-review.googlesource.com/1351973 Commit-Ready: Joel Hockey <joelhockey@chromium.org> Tested-by: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/89d774241f691102c750100831b6404b3e7c8b9b/src/chromiumos/tast/local/vm/vm.go [modify] https://crrev.com/89d774241f691102c750100831b6404b3e7c8b9b/src/chromiumos/tast/local/bundles/cros/vm/crostini_files.go [modify] https://crrev.com/89d774241f691102c750100831b6404b3e7c8b9b/src/chromiumos/tast/local/vm/container.go [modify] https://crrev.com/89d774241f691102c750100831b6404b3e7c8b9b/src/chromiumos/tast/local/chrome/chrome.go [modify] https://crrev.com/89d774241f691102c750100831b6404b3e7c8b9b/src/chromiumos/tast/local/vm/concierge.go
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/43234d41878568112e0c473e77423dcb189a5b7a commit 43234d41878568112e0c473e77423dcb189a5b7a Author: Joel Hockey <joelhockey@chromium.org> Date: Wed Dec 05 09:13:34 2018 tast-tests: Update CrostiniFiles to work with MyFilesVolume Share files from MyFiles rather than Downloads. Fix JS promise rejection in share/unshare BUG= chromium:907231 BUG= chromium:911718 TEST=vm.CrostiniFiles Change-Id: Id4baaa1777bceac2771aaac52059234619139a5d Reviewed-on: https://chromium-review.googlesource.com/1362261 Commit-Ready: Joel Hockey <joelhockey@chromium.org> Tested-by: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/43234d41878568112e0c473e77423dcb189a5b7a/src/chromiumos/tast/local/bundles/cros/vm/crostini_files.go
Still TODO: verify writing a file from container and having it show up in FilesApp.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/e643f6646579eb744b97be319968c79aef236cde commit e643f6646579eb744b97be319968c79aef236cde Author: Joel Hockey <joelhockey@chromium.org> Date: Fri Dec 07 06:06:40 2018 tast-test: write a shared file from crostini container BUG=chromium:891146 BUG= chromium:907231 TEST=vm.CrostiniFiles Change-Id: Iea7404b21f962d28abc229946d4392a8e43ac8a6 Reviewed-on: https://chromium-review.googlesource.com/1364590 Commit-Ready: Joel Hockey <joelhockey@chromium.org> Tested-by: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/e643f6646579eb744b97be319968c79aef236cde/src/chromiumos/tast/local/bundles/cros/vm/crostini_files.go
Comment 1 by joelhockey@chromium.org
, Nov 21