Cros-Adapta: White button borders in dark theme too bright
Reported by
justin.b...@gmail.com,
Nov 20
|
|||||
Issue description
Chrome Version : 72.0.3611.0
OS Version: 11265.0.0
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari:
Firefox:
IE/Edge:
What steps will reproduce the problem?
1. Install Linux for ChromeOS
2. Install any of the following applications: gnome-terminal, terminator, tilix.
3. Launch application.
What is the expected result?
Applications will launch with a consistent UI theme.
What happens instead of that?
There's a white border around application UI controls that seem out of place for the theme - contrast with an install of the same applications in, say, Ubuntu 18.04. Not all UI controls have this border - it seems like a quirk of the in-use theme. If this isn't a defect, it would be helpful to the community to know if there is a setting that adjusts the color of these borders.
Please provide any additional information below. Attach a screenshot if
possible.
UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 11265.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3611.0 Safari/537.36
,
Nov 20
N.B. This was tested on a Pixelbook in current stable and dev channels.
,
Nov 20
Thanks, this is a problem with the dark theme variant. I debated using a darker color when I implemented button borders but had run out of colors in the pallet I was working off. I'll work with our UI designers to find an appropriate grey.
,
Nov 20
Thank you, jopra@chromium.org !
,
Nov 20
Add sgabriel@ to the thread who might have a recommendation here. Thanks!
,
Nov 21
In addition, I am not sure if it's customizable here but the shade of blue we are using when it is displayed on a dark background is #8AB4F8, it enables better contrast.
,
Nov 26
Thanks sgabriel + sbroslawsky. I'll try to get both changes into a single CL (should only be a color scheme update without other code changes).
,
Nov 26
Thanks sgabriel!
,
Nov 28
Better :)
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/cros-adapta/+/eb6d8c1832b9181926df107faf41a80887fd982c commit eb6d8c1832b9181926df107faf41a80887fd982c Author: Josh Pratt <jopra@chromium.org> Date: Tue Dec 04 08:11:39 2018 Cros-Adapta: Update suggestion color, selection color and border colors BUG= chromium:907229 TEST=manual (build_packages, build_image, flash, test) Change-Id: I29cd8b417576caf531e987796fe2c725b23c099d Reviewed-on: https://chromium-review.googlesource.com/1351861 Commit-Ready: Josh Pratt <jopra@chromium.org> Tested-by: Josh Pratt <jopra@chromium.org> Reviewed-by: Raymes Khoury <raymes@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> [modify] https://crrev.com/eb6d8c1832b9181926df107faf41a80887fd982c/gtk-3.0/colors-dark.css
,
Dec 5
Should be fixed in m72 dependant on the timing of Termina updates. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dtapu...@chromium.org
, Nov 20