DCHECK when dragging shelf item |
|||||||
Issue descriptionChrome Version: 72.0.3616.0 OS: Chrome After building chromeos for linux with dchecks enabled: 1. Launch Chrome with a new user data dir 2. Drag an icon on the Chrome shelf to the left of another icon [182792:182792:1120/120751.709513:FATAL:chrome_launcher_prefs.cc(491)] Check failed: position.IsValid(). #0 0x7f7ef44a312f base::debug::StackTrace::StackTrace() #1 0x7f7ef43d286b logging::LogMessage::~LogMessage() #2 0x56344e42971d SetPinPosition() #3 0x56344e43a262 ChromeLauncherController::SyncPinPosition() #4 0x56344e43b940 ChromeLauncherController::ShelfItemMoved() #5 0x7f7eed6e64a9 ash::ShelfModel::Move() #6 0x56344e43afc9 ChromeLauncherController::OnShelfItemMoved() #7 0x7f7eed78433b ash::mojom::ShelfObserverStubDispatch::Accept() #8 0x7f7ef4764ea6 mojo::InterfaceEndpointClient::HandleValidatedMessage() #9 0x7f7ef47647d6 mojo::FilterChain::Accept() #10 0x7f7ef4766235 mojo::InterfaceEndpointClient::HandleIncomingMessage() #11 0x7f7ef476c83b mojo::internal::MultiplexRouter::ProcessIncomingMessage() #12 0x7f7ef476bc60 mojo::internal::MultiplexRouter::Accept() #13 0x7f7ef47647d6 mojo::FilterChain::Accept() #14 0x7f7ef475f639 mojo::Connector::ReadSingleMessage() #15 0x7f7ef4760151 mojo::Connector::ReadAllAvailableMessages() #16 0x7f7ef475fff9 mojo::Connector::OnHandleReadyInternal() #17 0x7f7ef4760847 mojo::SimpleWatcher::DiscardReadyState() #18 0x7f7ef4725c74 mojo::SimpleWatcher::OnHandleReady() #19 0x7f7ef4726181 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJS B_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE
,
Nov 26
,
Dec 3
Bulk moving <p-1's to the next milestone because we branched to M-73.
,
Dec 12
,
Dec 18
Assigning to khmel@ who authored the DCHECK line and can probably explain the reasoning and potential mitigation strategies.
,
Dec 18
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/264bf2822f04ff93989b25e1cb8330ebd48f1b0f commit 264bf2822f04ff93989b25e1cb8330ebd48f1b0f Author: khmel@chromium.org <khmel@chromium.org> Date: Thu Jan 03 01:14:31 2019 shelf: Drop pin import from prefs. We are 2+ years using shelf pins supported by sync. Now we can drop import from prefs code. As a side effect this fixes several DCHECKs. This also makes pin positions for default apps and apps, pinned by policy deterministic and not-dependent from installation order. TEST=Locally + unit_tests. Logic of unit tests is not changed. BUG= 918203 BUG= 907221 Change-Id: I11d1cd7f1f0192719b48adfd3fa9e56c9dc1429b Reviewed-on: https://chromium-review.googlesource.com/c/1392280 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#619552} [modify] https://crrev.com/264bf2822f04ff93989b25e1cb8330ebd48f1b0f/chrome/browser/ui/ash/chrome_launcher_prefs.cc [modify] https://crrev.com/264bf2822f04ff93989b25e1cb8330ebd48f1b0f/chrome/browser/ui/ash/chrome_launcher_prefs.h [modify] https://crrev.com/264bf2822f04ff93989b25e1cb8330ebd48f1b0f/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc [modify] https://crrev.com/264bf2822f04ff93989b25e1cb8330ebd48f1b0f/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h [modify] https://crrev.com/264bf2822f04ff93989b25e1cb8330ebd48f1b0f/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc [modify] https://crrev.com/264bf2822f04ff93989b25e1cb8330ebd48f1b0f/chrome/common/pref_names.cc [modify] https://crrev.com/264bf2822f04ff93989b25e1cb8330ebd48f1b0f/chrome/common/pref_names.h
,
Jan 3
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by newcomer@chromium.org
, Nov 20