The waits/sleeps in extension and component updaters can be simplified. In particular, we do not need to persist and sync extension update periods across browser restarts, nor sleep between component update applications.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc79f390b99cf2764df73feb66ad5a2021f807f6 commit bc79f390b99cf2764df73feb66ad5a2021f807f6 Author: Joshua Pawlicki <waffles@chromium.org> Date: Thu Jan 03 18:00:23 2019 Remove old migrations of old prefs. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1344880 Bug: 907219 Change-Id: Ia855b6ad41bf1a4465233cfd857fae3c1a759c54 Reviewed-on: https://chromium-review.googlesource.com/c/1393403 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#619683} [modify] https://crrev.com/bc79f390b99cf2764df73feb66ad5a2021f807f6/chrome/browser/prefs/browser_prefs.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a1b4fb27a194a6c4ec3fa22040a4e8152cd45bb commit 0a1b4fb27a194a6c4ec3fa22040a4e8152cd45bb Author: Joshua Pawlicki <waffles@chromium.org> Date: Tue Jan 08 19:55:22 2019 Simplify extension update check delay after browser start. Bug: 907219 Change-Id: I067fcb333b43f60441e1789cac8caf5b996b7e5d Reviewed-on: https://chromium-review.googlesource.com/c/1344880 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Sergey Poromov <poromov@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#620845} [modify] https://crrev.com/0a1b4fb27a194a6c4ec3fa22040a4e8152cd45bb/chrome/browser/extensions/updater/extension_updater.cc [modify] https://crrev.com/0a1b4fb27a194a6c4ec3fa22040a4e8152cd45bb/chrome/browser/extensions/updater/extension_updater.h [modify] https://crrev.com/0a1b4fb27a194a6c4ec3fa22040a4e8152cd45bb/chrome/browser/extensions/updater/extension_updater_unittest.cc [modify] https://crrev.com/0a1b4fb27a194a6c4ec3fa22040a4e8152cd45bb/chrome/browser/extensions/updater/update_service_browsertest.cc [modify] https://crrev.com/0a1b4fb27a194a6c4ec3fa22040a4e8152cd45bb/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/0a1b4fb27a194a6c4ec3fa22040a4e8152cd45bb/chrome/browser/prefs/browser_prefs.cc [modify] https://crrev.com/0a1b4fb27a194a6c4ec3fa22040a4e8152cd45bb/extensions/browser/extension_prefs.cc [modify] https://crrev.com/0a1b4fb27a194a6c4ec3fa22040a4e8152cd45bb/extensions/browser/pref_names.cc [modify] https://crrev.com/0a1b4fb27a194a6c4ec3fa22040a4e8152cd45bb/extensions/browser/pref_names.h [modify] https://crrev.com/0a1b4fb27a194a6c4ec3fa22040a4e8152cd45bb/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7a8a7c4f62192d78412a0260db02ab19cdd247c commit c7a8a7c4f62192d78412a0260db02ab19cdd247c Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Wed Jan 09 00:58:03 2019 Revert "Simplify extension update check delay after browser start." This reverts commit 0a1b4fb27a194a6c4ec3fa22040a4e8152cd45bb. Reason for revert: This causes test failures on Mac build bot: crbug.com/920040 Original change's description: > Simplify extension update check delay after browser start. > > Bug: 907219 > Change-Id: I067fcb333b43f60441e1789cac8caf5b996b7e5d > Reviewed-on: https://chromium-review.googlesource.com/c/1344880 > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#620845} TBR=gab@chromium.org,rdevlin.cronin@chromium.org,waffles@chromium.org,bcwhite@chromium.org,poromov@chromium.org Change-Id: I8da444461a2a9c2c3a09abbe94a43bbd053d3b93 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 907219 Reviewed-on: https://chromium-review.googlesource.com/c/1401881 Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#620973} [modify] https://crrev.com/c7a8a7c4f62192d78412a0260db02ab19cdd247c/chrome/browser/extensions/updater/extension_updater.cc [modify] https://crrev.com/c7a8a7c4f62192d78412a0260db02ab19cdd247c/chrome/browser/extensions/updater/extension_updater.h [modify] https://crrev.com/c7a8a7c4f62192d78412a0260db02ab19cdd247c/chrome/browser/extensions/updater/extension_updater_unittest.cc [modify] https://crrev.com/c7a8a7c4f62192d78412a0260db02ab19cdd247c/chrome/browser/extensions/updater/update_service_browsertest.cc [modify] https://crrev.com/c7a8a7c4f62192d78412a0260db02ab19cdd247c/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/c7a8a7c4f62192d78412a0260db02ab19cdd247c/chrome/browser/prefs/browser_prefs.cc [modify] https://crrev.com/c7a8a7c4f62192d78412a0260db02ab19cdd247c/extensions/browser/extension_prefs.cc [modify] https://crrev.com/c7a8a7c4f62192d78412a0260db02ab19cdd247c/extensions/browser/pref_names.cc [modify] https://crrev.com/c7a8a7c4f62192d78412a0260db02ab19cdd247c/extensions/browser/pref_names.h [modify] https://crrev.com/c7a8a7c4f62192d78412a0260db02ab19cdd247c/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/009fb5f11796d3db3acda99fcf72e3b7892c304c commit 009fb5f11796d3db3acda99fcf72e3b7892c304c Author: Joshua Pawlicki <waffles@chromium.org> Date: Fri Jan 18 21:44:47 2019 Reland 0a1b4fb27a194a6c4ec3fa22040a4e8152cd45b (https://chromium-review.googlesource.com/c/chromium/src/+/1344880) Relative to the original CL, this changes the setter for skipping scheduled updates into a global value that can be set by browser tests prior to constructing and kicking off the extension updater. This is the pattern used by content verification and other extension-behavior customization. It's my hope that taking this approach will eliminate a lot of long- standing flakiness in several of the tests, so if this sticks I can follow it up with a CL re-enabling several tests. (Or another person who has a better relationship with extensions can.) OCL description: > Simplify extension update check delay after browser start. > > Bug: 907219 > Change-Id: I067fcb333b43f60441e1789cac8caf5b996b7e5d > Reviewed-on: https://chromium-review.googlesource.com/c/1344880 > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#620845} Bug: 907219, 920040 Change-Id: I35ff0311f84294eca6cd1b23a3fd612d53ea42db Reviewed-on: https://chromium-review.googlesource.com/c/1412796 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: Sergey Poromov <poromov@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#624302} [modify] https://crrev.com/009fb5f11796d3db3acda99fcf72e3b7892c304c/chrome/browser/extensions/extension_browsertest.h [modify] https://crrev.com/009fb5f11796d3db3acda99fcf72e3b7892c304c/chrome/browser/extensions/updater/extension_updater.cc [modify] https://crrev.com/009fb5f11796d3db3acda99fcf72e3b7892c304c/chrome/browser/extensions/updater/extension_updater.h [modify] https://crrev.com/009fb5f11796d3db3acda99fcf72e3b7892c304c/chrome/browser/extensions/updater/extension_updater_unittest.cc [modify] https://crrev.com/009fb5f11796d3db3acda99fcf72e3b7892c304c/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/009fb5f11796d3db3acda99fcf72e3b7892c304c/chrome/browser/prefs/browser_prefs.cc [modify] https://crrev.com/009fb5f11796d3db3acda99fcf72e3b7892c304c/extensions/browser/extension_prefs.cc [modify] https://crrev.com/009fb5f11796d3db3acda99fcf72e3b7892c304c/extensions/browser/pref_names.cc [modify] https://crrev.com/009fb5f11796d3db3acda99fcf72e3b7892c304c/extensions/browser/pref_names.h [modify] https://crrev.com/009fb5f11796d3db3acda99fcf72e3b7892c304c/tools/metrics/histograms/histograms.xml
Comment 1 by karandeepb@chromium.org
, Nov 30