New issue
Advanced search Search tips

Issue 907209 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add PRESUBMIT for layout test path name length

Project Member Reported by hirosh...@chromium.org, Nov 20

Issue description

Long path names can cause test failures on bots,
due to max path name limitations by OS, like  Issue 906964 .

Currently path name lengths are not checked at presubmit for:
- Non-WPT test path names (IIUC), and
- Virtual test path names. Full path name like "virtual/foo/external/wpt/bar/baz.html" should be checked, even if there are no "virtual/foo/external/wpt/bar/baz.html" file in the repository, as the test runner can generate files like "virtual/foo/external/wpt/bar/baz-pretty-diff.html".

Not sure what max length value to be used.
The limit of WPT test path names is 150:
https://web-platform-tests.org/writing-tests/general-guidelines.html
(i.e. max 163 if "external/wpt/" part is included)

In the case of  Issue 906964 , the test name
"virtual\off-main-thread-worker-script-fetch\external\wpt\referrer-policy\no-referrer-when-downgrade\meta-referrer\same-origin\http-http\worker-request\keep-origin-redirect\insecure-protocol.http.html"
(199 chars) caused the path length limit exceeded.

 
Also, due to any.js feature
https://web-platform-tests.org/writing-tests/testharness.html#multi-global-tests
virtual/foo/external/wpt/(143chars).any.js
can be run as
virtual/foo/external/wpt/(143chars).https.any.serviceworker.html
which is 194+(virtual test prefix name length) chars.

So theoretically it is not sufficient to limit the virtual prefix name length.

Probably it is more feasible to list all actual test names (including virtual and .any.* WPT tests) and check their path lengths.

Cc: hirosh...@chromium.org
Components: -Tests Blink>Infra
Labels: Test-Layout
Status: Available (was: Untriaged)

Sign in to add a comment