Issue metadata
Sign in to add a comment
|
Remove Chrome flag for fingerprint |
||||||||||||||||||||||||
Issue descriptionFlag ownership is being revamped: https://sites.google.com/a/chromium.org/dev/developers/contributing-code/flag-ownership The FP UI lives behind the quick-unlock-fingerprint flag, but we don't really use that flag anymore. It is now normally enabled or disabled with a USE flag http://cs/chromeos_public/src/platform2/login_manager/chrome_setup.cc?rcl=763e67284e2b5dcd206030111bb94c413624c9f7&l=436 So I think we can remove the corresponding Chrome flag
,
Nov 20
Yes, iiuc the QuickUnlockFingerprint is either set by chrome_setup (via a USE flag) or in the UI with this flag https://cs.chromium.org/chromium/src/chrome/browser/about_flags.cc?type=cs&q=QuickUnlockFingerprint&sq=package:chromium&g=0&l=2886 So I think we should just remove the latter, ti doesn't seem necessary to have an entry in chrome://flags
,
Nov 20
Ack, removing from chrome://flags SG, but we still need to keep the feature flag around.
,
Nov 20
Yep, agreed :-)
,
Dec 12
yulunwu@: remove these[1] lines so that the fingerprint flag doesn't appear in chrome://flags 1: https://cs.chromium.org/chromium/src/chrome/browser/about_flags.cc?l=2801-2803&rcl=757a6f7d888f2651d8030c3e9adb06d68eac1fb8
,
Jan 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c451aaa76961519bdb91f7c8f14d9abb8bf4dc9d commit c451aaa76961519bdb91f7c8f14d9abb8bf4dc9d Author: Yulun Wu <yulunwu@chromium.org> Date: Wed Jan 16 00:50:46 2019 Removed quick-unlock-fingerprint in about_flags.cc Flag ownership has been revamped and quick-unlock-fingerprint is now managed by: https://cs.corp.google.com/chromeos_public/src/platform2/login_manager/chrome_setup.cc?rcl=763e67284e2b5dcd206030111bb94c413624c9f7&l=436 Bug: 907168 Change-Id: Ia3315636a0f9f006b613ab1d941554cf8874afea Reviewed-on: https://chromium-review.googlesource.com/c/1379067 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#622947} [modify] https://crrev.com/c451aaa76961519bdb91f7c8f14d9abb8bf4dc9d/chrome/browser/about_flags.cc
,
Jan 16
(6 days ago)
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by jdufault@chromium.org
, Nov 20