New issue
Advanced search Search tips

Issue 907158 link

Starred by 2 users
Status: Fixed
Owner:
x...@chromium.org
Closed: Nov 28
Cc:
omrilio@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Add logs for tablet mode detection in Chrome side

Project Member Reported by x...@chromium.org, Nov 20 
Chrome Version: (copy from chrome://version)
OS: Chrome

What steps will reproduce the problem?
We have seen a lot of tablet mode/laptop mode detection issues in Meowth in M71 recently, Some of them were platform/firmware issues, e.g., b/117439202, b/118567558, and some of them were Chrome issues, e.g., b/118515248, b/119020957, b/118317363. However, sometimes we don't have  a consistent repro step (e.g., b/119613410,  issue 905808 ), it's hard to tell where the problem is. In order to better understand and diagnose it for future cases, add logs for tablet mode detection and internal input device blocking in chrome side.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f800b990ebce8cb79b09bc5610d4d55a08ab5857

commit f800b990ebce8cb79b09bc5610d4d55a08ab5857
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Mon Nov 26 21:32:33 2018

Add logs for tablet mode detection and internal event blocking logic.

See the bug description for why we add this.

Bug:  907158 
Change-Id: Ia28c1b5162dcf1e11435a12efdc9c64a3992c86e
Reviewed-on: https://chromium-review.googlesource.com/c/1345011
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610949}
[modify] https://crrev.com/f800b990ebce8cb79b09bc5610d4d55a08ab5857/ash/wm/tablet_mode/internal_input_devices_event_blocker.cc
[modify] https://crrev.com/f800b990ebce8cb79b09bc5610d4d55a08ab5857/ash/wm/tablet_mode/tablet_mode_controller.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b03ab7eb67d4d578db5fec8ac2c01ad641cb245a

commit b03ab7eb67d4d578db5fec8ac2c01ad641cb245a
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Wed Nov 28 03:13:58 2018

login: add vmodule pattern for tablet mode detection on chromeos.

The vmodule pattern is added for debug purpose. See
 https://crbug.com/907158  for why we need this.

BUG= chromium:907158 
TEST=manual: emerged and deployed chromeos-login and verified
             that desired messages are logged

Change-Id: Ic5b343122830bf52d805696abb215bc959d7786d
Reviewed-on: https://chromium-review.googlesource.com/1351670
Commit-Ready: Xiaoqian Dai <xdai@chromium.org>
Tested-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/b03ab7eb67d4d578db5fec8ac2c01ad641cb245a/login_manager/chrome_setup.cc

Comment 3 by x...@chromium.org, Nov 28

Status: Fixed (was: Assigned)
►

Sign in to add a comment