New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 907149 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

[all boards] platform_Flashrom test failing with "Expect (factory_install) completed. in output of Starting firmware updater v5..."

Project Member Reported by ka...@chromium.org, Nov 20

Issue description

Dashboard view: https://screenshot.googleplex.com/uKZSD9LmWWF

11/19 18:34:50.379 INFO | platform_Flashrom:0039| Execute chromeos-firmwareupdate --mode=factory 2>&1
11/19 18:35:16.775 INFO | platform_Flashrom:0041| Output >>> ['Starting firmware updater v5...', '>> futility update -a .  --mode=factory', '>> Firmware updater started.', 'flashrom v0.9.9  : 93107fc : Nov 16 2018 23:10:43 UTC on Linux 3.14.0 (x86_64)', 'Calibrating delay loop... OK.', 'coreboot table found at 0x7ce3c000.', 'spi_block_erase_52 failed during command execution at address 0x0', 'spi_chip_erase_60 failed during command execution', 'spi_chip_erase_c7 failed during command execution', 'Erasing and writing flash chip... Verifying flash... VERIFIED.', 'SUCCESS', 'flashrom v0.9.9  : 93107fc : Nov 16 2018 23:10:43 UTC on Linux 3.14.0 (x86_64)', 'Calibrating delay loop... OK.', 'coreboot table found at 0x7ce3c000.', 'Erasing and writing flash chip... Verifying flash... VERIFIED.', 'SUCCESS', '>> DONE: Firmware updater exited successfully.', '>> Target image: bios.bin (RO:Google_Auron_paine.6301.58.98, RW/A:Google_Auron_paine.6301.58.98, RW/B:Google_Auron_paine.6301.58.98).', 'Loading current system firmware...', '>> Current system: /tmp/fwupdater.55sSXY (RO:Google_Auron_paine.6301.58.98, RW/A:Google_Auron_paine.6301.58.98, RW/B:).', '>> Write protection: 0 (disabled; HW=0, SW=0).', '>> FULL UPDATE: Updating whole firmware image(s), RO+RW.', 'Checking compatibility...', 'Executing: flashrom -w /tmp/fwupdater.8lBA5y -p host', 'Executing: flashrom -w /tmp/fwupdater.12Tc5F -p ec'] <<<
11/19 18:35:16.776 DEBUG|              test:0381| Test failed due to Expect (factory_install) completed. in output of Starting firmware updater v5...

...

11/19 18:35:27.472 WARNI|              test:0606| The test failed with the following exception
Traceback (most recent call last):
  File "/usr/local/autotest/client/common_lib/test.py", line 600, in _exec
    _call_test_function(self.execute, *p_args, **p_dargs)
  File "/usr/local/autotest/client/common_lib/test.py", line 800, in _call_test_function
    return func(*args, **dargs)
  File "/usr/local/autotest/client/common_lib/test.py", line 464, in execute
    postprocess_profiled_run, args, dargs)
  File "/usr/local/autotest/client/common_lib/test.py", line 371, in _call_run_once
    self.run_once(*args, **dargs)
  File "/usr/local/autotest/server/site_tests/platform_Flashrom/platform_Flashrom.py", line 83, in run_once
    '(factory_install) completed.')
  File "/usr/local/autotest/server/site_tests/platform_Flashrom/platform_Flashrom.py", line 44, in run_cmd
    (checkfor, '\n'.join(output)))
TestFail: Expect (factory_install) completed. in output of Starting firmware updater v5...
>> futility update -a .  --mode=factory
>> Firmware updater started.
flashrom v0.9.9  : 93107fc : Nov 16 2018 23:10:43 UTC on Linux 3.14.0 (x86_64)

...



Sample logs at https://stainless.corp.google.com/browse/chromeos-autotest-results/259139113-chromeos-test/
 
In updater 5 the output message is slightly different. I think we should fix the expected string.
Owner: hungte@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cc3204398c75de2c0946bee1ce63c90953a21341

commit cc3204398c75de2c0946bee1ce63c90953a21341
Author: Hung-Te Lin <hungte@chromium.org>
Date: Wed Nov 21 02:27:39 2018

platform_Flashrom: Support firmware updater v5

Starting from go/updater5, the firmware updater no longer prints
'completed' message with mode. Instead we should only track 'SUCCESS' in
output.

BUG= chromium:907149 
TEST=run platform_Flashrom on Eve

Change-Id: If09239f3fa03f1f4fb8b8af06d6d656e47e33532
Reviewed-on: https://chromium-review.googlesource.com/1344469
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>

[modify] https://crrev.com/cc3204398c75de2c0946bee1ce63c90953a21341/server/site_tests/platform_LabFirmwareUpdate/platform_LabFirmwareUpdate.py
[modify] https://crrev.com/cc3204398c75de2c0946bee1ce63c90953a21341/server/site_tests/platform_Flashrom/platform_Flashrom.py

Status: Fixed (was: Started)

Sign in to add a comment