Undefined source in manual translation |
|||||||
Issue descriptionChrome Version: 72.0.3617.0 OS: Android What steps will reproduce the problem? (1) Enable manual translation (chrome://flags #translate-android-manual-trigger). (2) Go to a web page for which we cannot determine the source language (e.g. cnn.com). (3) Trigger manual translation (Apps Menu (3-dots) > Translate ...) What is the expected result? Translation is not offered. What happens instead? - The translate infobar appears with a missing source language. - Sometimes the page loading halts/hangs (in release mode). - Crash (in debug mode - failed DCHECK).
,
Nov 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/622c02f9a7e9fe8d55bab94de43b3dab30b8b9b8 commit 622c02f9a7e9fe8d55bab94de43b3dab30b8b9b8 Author: Alexandre Frechette <frechette@chromium.org> Date: Tue Nov 20 20:22:43 2018 Check source language to determine if page can be manually translated. Bug: 907134 , 902803 Change-Id: Ifb63346572e90a191918bcfe30d24f4362c10b45 Reviewed-on: https://chromium-review.googlesource.com/c/1344256 Reviewed-by: anthonyvd <anthonyvd@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#609789} [modify] https://crrev.com/622c02f9a7e9fe8d55bab94de43b3dab30b8b9b8/components/translate/core/browser/translate_manager.cc [modify] https://crrev.com/622c02f9a7e9fe8d55bab94de43b3dab30b8b9b8/components/translate/core/browser/translate_manager_unittest.cc
,
Nov 21
Verified on Canary. `Translate...` overflow does not appear until page language is determined and valid.
,
Nov 21
,
Nov 21
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 21
Approved for merge to 71, branch 3578.
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef1acbee763ddb43765fecfa1e68f08832335a79 commit ef1acbee763ddb43765fecfa1e68f08832335a79 Author: Alexandre Frechette <frechette@chromium.org> Date: Wed Nov 21 16:45:38 2018 Check source language to determine if page can be manually translated. Bug: 907134 , 902803 Change-Id: Ifb63346572e90a191918bcfe30d24f4362c10b45 Reviewed-on: https://chromium-review.googlesource.com/c/1344256 Reviewed-by: anthonyvd <anthonyvd@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#609789}(cherry picked from commit 622c02f9a7e9fe8d55bab94de43b3dab30b8b9b8) Reviewed-on: https://chromium-review.googlesource.com/c/1346969 Cr-Commit-Position: refs/branch-heads/3578@{#788} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/ef1acbee763ddb43765fecfa1e68f08832335a79/components/translate/core/browser/translate_manager.cc [modify] https://crrev.com/ef1acbee763ddb43765fecfa1e68f08832335a79/components/translate/core/browser/translate_manager_unittest.cc
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef1acbee763ddb43765fecfa1e68f08832335a79 Commit: ef1acbee763ddb43765fecfa1e68f08832335a79 Author: frechette@chromium.org Commiter: anthonyvd@chromium.org Date: 2018-11-21 16:45:38 +0000 UTC Check source language to determine if page can be manually translated. Bug: 907134 , 902803 Change-Id: Ifb63346572e90a191918bcfe30d24f4362c10b45 Reviewed-on: https://chromium-review.googlesource.com/c/1344256 Reviewed-by: anthonyvd <anthonyvd@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#609789}(cherry picked from commit 622c02f9a7e9fe8d55bab94de43b3dab30b8b9b8) Reviewed-on: https://chromium-review.googlesource.com/c/1346969 Cr-Commit-Position: refs/branch-heads/3578@{#788} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by yyushkina@chromium.org
, Nov 20