New issue
Advanced search Search tips

Issue 907131 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Today
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocked on:
issue 883538

Blocking:
issue 903078
issue 883538



Sign in to add a comment

Allow building libFuzzer on Windows with msvc's cl.exe

Project Member Reported by metzman@chromium.org, Nov 20

Issue description

Users of libFuzzer on Windows shouldn't be forced to have clang to build it.
There are two possible fixes for this:
1. Allow libFuzzer to be built directly with MSVC.
2. Change things in cmake to compile libFuzzer with the newly built clang.

I think 1 is easier, but 2 is preferable and probably easier to maintain.
 
Cc: mascasa@google.com
Blockedon: 883538
Blocking: 903078
Cc: kcc@chromium.org
My slight preference is 2, but if it's too complicated in cmake I'd like to see a patch for 1.  
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4a72c1cc2b976973b4df9e4c256a78ecb257c97

commit d4a72c1cc2b976973b4df9e4c256a78ecb257c97
Author: Jonathan Metzman <metzman@chromium.org>
Date: Wed Jan 16 00:32:05 2019

Roll src/third_party/libFuzzer/src/ 2a5309858..ee7a5b85c (4 commits)

Also adjust BUILD.gn to reflect new file names.

https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/2a53098584c4..ee7a5b85c7cf

$ git log 2a5309858..ee7a5b85c --date=short --no-merges --format='%ad %ae %s'
2019-01-15 metzman [libFuzzer][MSVC] Use alternatename for ext functions
2019-01-09 metzman [libfuzzer][MSVC] Make calls to builtin functions work with MSVC
2018-12-14 kcc [libFuzzer] make len_control less aggressive
2018-12-06 mgorny [test] Add missing cmake include for building libFuzzer alone

Created with:
  roll-dep src/third_party/libFuzzer/src

Bug:  907131 
Change-Id: Iee1ca803c2da5b50502a3d9efcd82ff4a1f53954
Reviewed-on: https://chromium-review.googlesource.com/c/1409712
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622926}
[modify] https://crrev.com/d4a72c1cc2b976973b4df9e4c256a78ecb257c97/DEPS
[modify] https://crrev.com/d4a72c1cc2b976973b4df9e4c256a78ecb257c97/third_party/libFuzzer/BUILD.gn

Comment 6 by metzman@chromium.org, Today (7 hours ago)

Comment 7 by metzman@chromium.org, Today (7 hours ago)

Blocking: 883538

Sign in to add a comment