A frame should be able to be frozen so that audio pauses and timers don't run for the frame until it is unfrozen.
Could you help me to understand where is this coming from? Seems like I am missing the context of the change.
We wish to apply https://wicg.github.io/page-lifecycle/spec.html to iframes that are display: none or moved offscreen based on policies.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fc7aad563a27d9dd1bf96eea820b27e5655df45 commit 6fc7aad563a27d9dd1bf96eea820b27e5655df45 Author: Dave Tapuska <dtapuska@chromium.org> Date: Wed Nov 28 21:46:32 2018 Add ability to pause and resume the audio sink from blink. Add state to support pausing a web audio device such that it can be restarted when the frame is returned to be visible. BUG=907125 Change-Id: I01aef9c19c81e35e68ee1e299e16cd6c9946ebde Reviewed-on: https://chromium-review.googlesource.com/c/1344265 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Rick Byers <rbyers@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#611881} [modify] https://crrev.com/6fc7aad563a27d9dd1bf96eea820b27e5655df45/content/renderer/media/renderer_webaudiodevice_impl.cc [modify] https://crrev.com/6fc7aad563a27d9dd1bf96eea820b27e5655df45/content/renderer/media/renderer_webaudiodevice_impl.h [modify] https://crrev.com/6fc7aad563a27d9dd1bf96eea820b27e5655df45/third_party/blink/public/platform/web_audio_device.h [modify] https://crrev.com/6fc7aad563a27d9dd1bf96eea820b27e5655df45/third_party/blink/renderer/modules/webaudio/audio_context_autoplay_test.cc [modify] https://crrev.com/6fc7aad563a27d9dd1bf96eea820b27e5655df45/third_party/blink/renderer/modules/webaudio/audio_context_test.cc [modify] https://crrev.com/6fc7aad563a27d9dd1bf96eea820b27e5655df45/third_party/blink/renderer/platform/audio/audio_destination.cc [modify] https://crrev.com/6fc7aad563a27d9dd1bf96eea820b27e5655df45/third_party/blink/renderer/platform/audio/audio_destination.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0eff6da41449ce9799de7413e1f9eaa5dd46ce63 commit 0eff6da41449ce9799de7413e1f9eaa5dd46ce63 Author: Dave Tapuska <dtapuska@chromium.org> Date: Tue Dec 04 22:14:56 2018 Remove argument on DispatchBeforeUnloadEvent Sometimes the View is null and we can't get a ChromeClient. Change the API to take the ChromeClient as a ptr, which also implies the auto_cancel field. BUG=907125 Change-Id: I123845c2294ec2c4f155500012280a48ff623c86 Reviewed-on: https://chromium-review.googlesource.com/c/1359056 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#613721} [modify] https://crrev.com/0eff6da41449ce9799de7413e1f9eaa5dd46ce63/third_party/blink/renderer/core/dom/document.cc [modify] https://crrev.com/0eff6da41449ce9799de7413e1f9eaa5dd46ce63/third_party/blink/renderer/core/dom/document.h [modify] https://crrev.com/0eff6da41449ce9799de7413e1f9eaa5dd46ce63/third_party/blink/renderer/core/frame/local_frame.cc [modify] https://crrev.com/0eff6da41449ce9799de7413e1f9eaa5dd46ce63/third_party/blink/renderer/core/loader/frame_loader.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5bf98137c3126d2787a12a5881eb404fa5147e72 commit 5bf98137c3126d2787a12a5881eb404fa5147e72 Author: Dave Tapuska <dtapuska@chromium.org> Date: Mon Dec 10 01:35:30 2018 PausableObject cleanup - MediaRecorder MediaRecorder doesn't need to be a pausable object because it uses a kDOMManupulation task queue that gets paused. Remove this redundant code because the tasks selected to run already get paused. BUG=907125 Change-Id: I474f58a3c8937e199b77c820ec459fb98cc11021 Reviewed-on: https://chromium-review.googlesource.com/c/1368311 Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#615026} [modify] https://crrev.com/5bf98137c3126d2787a12a5881eb404fa5147e72/third_party/blink/renderer/modules/mediarecorder/media_recorder.cc [modify] https://crrev.com/5bf98137c3126d2787a12a5881eb404fa5147e72/third_party/blink/renderer/modules/mediarecorder/media_recorder.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df0477e9ca0423600017a6e6fb566ff5784c7667 commit df0477e9ca0423600017a6e6fb566ff5784c7667 Author: Dave Tapuska <dtapuska@chromium.org> Date: Mon Dec 10 16:31:24 2018 Pausable Object Cleanup - XMLHttpRequest The events dispatched by the XMLHttpRequestEventThrottle are attached to the kNetwork TaskQueue which is a pausable task queue. Verified progress events aren't received while an alert dialog is present. BUG=907125 Change-Id: I93d8bbf8151753c5ddfc14bbfdd067697f6fe01e Reviewed-on: https://chromium-review.googlesource.com/c/1368462 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#615143} [modify] https://crrev.com/df0477e9ca0423600017a6e6fb566ff5784c7667/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc [modify] https://crrev.com/df0477e9ca0423600017a6e6fb566ff5784c7667/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.h [modify] https://crrev.com/df0477e9ca0423600017a6e6fb566ff5784c7667/third_party/blink/renderer/core/xmlhttprequest/xml_http_request_progress_event_throttle.cc [modify] https://crrev.com/df0477e9ca0423600017a6e6fb566ff5784c7667/third_party/blink/renderer/core/xmlhttprequest/xml_http_request_progress_event_throttle.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/869255859135c13bf164e9d92d98ceea13aa0cc2 commit 869255859135c13bf164e9d92d98ceea13aa0cc2 Author: Dave Tapuska <dtapuska@chromium.org> Date: Mon Dec 10 22:15:52 2018 Pausable Object cleanup - FontFaceSet FontFaceSet doesn't need to be a pausable object to avoid dispatching events when paused since: - workers don't pause objects - events queued in the kInternalDefault queue are already pausable. BUG=907125 Change-Id: I3dc4c392ecad42f2f008837298ed5e7f7afb274d Reviewed-on: https://chromium-review.googlesource.com/c/1368448 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615277} [modify] https://crrev.com/869255859135c13bf164e9d92d98ceea13aa0cc2/third_party/blink/renderer/core/css/font_face_set.cc [modify] https://crrev.com/869255859135c13bf164e9d92d98ceea13aa0cc2/third_party/blink/renderer/core/css/font_face_set.h [modify] https://crrev.com/869255859135c13bf164e9d92d98ceea13aa0cc2/third_party/blink/renderer/core/css/font_face_set_document.cc [modify] https://crrev.com/869255859135c13bf164e9d92d98ceea13aa0cc2/third_party/blink/renderer/core/css/font_face_set_worker.cc [modify] https://crrev.com/869255859135c13bf164e9d92d98ceea13aa0cc2/third_party/blink/web_tests/http/tests/activedomobject/media-expected.txt [modify] https://crrev.com/869255859135c13bf164e9d92d98ceea13aa0cc2/third_party/blink/web_tests/http/tests/activedomobject/media.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2579767e2d7d463702ff2ab71fc3e23ac602e30a commit 2579767e2d7d463702ff2ab71fc3e23ac602e30a Author: Dave Tapuska <dtapuska@chromium.org> Date: Thu Dec 13 17:37:48 2018 Remove PausableObjects from rtc peerconnection code. RTCDataChannel used a timer to pause/resume. The timer is hooked up to the kNetwork task queue which is the loading task queue. Likewise the RTCPeerConnection object used a Async method runner which wasn't necessary because it also uses the kNetwork task queue which is pausable itself. BUG=907125 Change-Id: I3cac8f9143aa4bfb7557f348cff052dc886b2c01 Reviewed-on: https://chromium-review.googlesource.com/c/1372224 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#616355} [modify] https://crrev.com/2579767e2d7d463702ff2ab71fc3e23ac602e30a/third_party/blink/renderer/modules/peerconnection/rtc_data_channel.cc [modify] https://crrev.com/2579767e2d7d463702ff2ab71fc3e23ac602e30a/third_party/blink/renderer/modules/peerconnection/rtc_data_channel.h [modify] https://crrev.com/2579767e2d7d463702ff2ab71fc3e23ac602e30a/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc [modify] https://crrev.com/2579767e2d7d463702ff2ab71fc3e23ac602e30a/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22c376553dec79232fa419954f7fd741df0a92f8 commit 22c376553dec79232fa419954f7fd741df0a92f8 Author: Dave Tapuska <dtapuska@chromium.org> Date: Thu Dec 13 17:42:17 2018 Pausable Object Cleanup - MediaDevices Media devices are using the kMediaElementEvent task queue and this task queue is already pausable so it isn't necessary that the object implements pausing the tasks as well. BUG=907125 Change-Id: I8ea61fad9fb85ec0b29009c5da527156773dbd01 Reviewed-on: https://chromium-review.googlesource.com/c/1372230 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#616356} [modify] https://crrev.com/22c376553dec79232fa419954f7fd741df0a92f8/third_party/blink/renderer/modules/mediastream/media_devices.cc [modify] https://crrev.com/22c376553dec79232fa419954f7fd741df0a92f8/third_party/blink/renderer/modules/mediastream/media_devices.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f82a5d35e2cef6c5532ebd233de8e193b7c724a3 commit f82a5d35e2cef6c5532ebd233de8e193b7c724a3 Author: Dave Tapuska <dtapuska@chromium.org> Date: Fri Dec 14 18:02:34 2018 Revert "Pausable Object Cleanup - XMLHttpRequest" This reverts commit df0477e9ca0423600017a6e6fb566ff5784c7667. Reason for revert: Workers don't support paused task queues Original change's description: > Pausable Object Cleanup - XMLHttpRequest > > The events dispatched by the XMLHttpRequestEventThrottle are attached > to the kNetwork TaskQueue which is a pausable task queue. > > Verified progress events aren't received while an alert dialog is present. > > BUG=907125 > > Change-Id: I93d8bbf8151753c5ddfc14bbfdd067697f6fe01e > Reviewed-on: https://chromium-review.googlesource.com/c/1368462 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615143} TBR=haraken@chromium.org,dtapuska@chromium.org,altimin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 907125 Change-Id: Idd2b19aa6d935a3c1e51bf1e03ebd34e0ae8dbd2 Reviewed-on: https://chromium-review.googlesource.com/c/1378198 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#616738} [modify] https://crrev.com/f82a5d35e2cef6c5532ebd233de8e193b7c724a3/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc [modify] https://crrev.com/f82a5d35e2cef6c5532ebd233de8e193b7c724a3/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.h [modify] https://crrev.com/f82a5d35e2cef6c5532ebd233de8e193b7c724a3/third_party/blink/renderer/core/xmlhttprequest/xml_http_request_progress_event_throttle.cc [modify] https://crrev.com/f82a5d35e2cef6c5532ebd233de8e193b7c724a3/third_party/blink/renderer/core/xmlhttprequest/xml_http_request_progress_event_throttle.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73c524e6ab08093bc2a65fadf7c6386c41c4f673 commit 73c524e6ab08093bc2a65fadf7c6386c41c4f673 Author: Dave Tapuska <dtapuska@chromium.org> Date: Mon Dec 17 16:01:19 2018 Pausable Object cleanup - ScriptedTaskQueue Remove usage of pausable object in the scripted task queue. The experimental web scheduler queues that are created already are frame specific pausable queues. Confirmed this with the author of this code as this code was duplicated from the idle task runner which isn't a frame specific queue. BUG=907125 Change-Id: Ibb1aaff62c2a6f2b482a3a7a190cb71baeea3b6c Reviewed-on: https://chromium-review.googlesource.com/c/1378237 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#617130} [modify] https://crrev.com/73c524e6ab08093bc2a65fadf7c6386c41c4f673/third_party/blink/renderer/core/dom/scripted_task_queue.cc [modify] https://crrev.com/73c524e6ab08093bc2a65fadf7c6386c41c4f673/third_party/blink/renderer/core/dom/scripted_task_queue.h [modify] https://crrev.com/73c524e6ab08093bc2a65fadf7c6386c41c4f673/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1eb2d22874249cebe5620253b02fe9a4f551a420 commit 1eb2d22874249cebe5620253b02fe9a4f551a420 Author: Dave Tapuska <dtapuska@chromium.org> Date: Wed Dec 19 15:01:54 2018 Pausing Worker Task Scheduler support With the cleanup of Pausable objects it was discovered that workers don't pause their event queues like the main thread does. Add support to pause certain tasks (that match the main thread event queue). Worker tasks that are pausable (import & evaluate) are moved to the kDOMManipulation queue from the kInternalWorker queue. The kDOMManipulation is to be used for the connect message; see https://html.spec.whatwg.org/multipage/workers.html#worker-processing-model The kDOMManipulation queue is pausable whereas kInternalWorker is not. This fixes an ordering issues that pausing the queues generates and also will allow us in the future to remove the paused task list in the worker global scope. BUG=907125 Change-Id: I21d30323107244f04e6a8fe179f2a8ebb3dad144 Reviewed-on: https://chromium-review.googlesource.com/c/1377347 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#617833} [modify] https://crrev.com/1eb2d22874249cebe5620253b02fe9a4f551a420/third_party/blink/renderer/core/inspector/worker_thread_debugger.cc [modify] https://crrev.com/1eb2d22874249cebe5620253b02fe9a4f551a420/third_party/blink/renderer/core/workers/worker_thread.cc [modify] https://crrev.com/1eb2d22874249cebe5620253b02fe9a4f551a420/third_party/blink/renderer/platform/scheduler/public/frame_scheduler.h [modify] https://crrev.com/1eb2d22874249cebe5620253b02fe9a4f551a420/third_party/blink/renderer/platform/scheduler/public/worker_scheduler.h [modify] https://crrev.com/1eb2d22874249cebe5620253b02fe9a4f551a420/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_task_queue.cc [modify] https://crrev.com/1eb2d22874249cebe5620253b02fe9a4f551a420/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_task_queue.h [modify] https://crrev.com/1eb2d22874249cebe5620253b02fe9a4f551a420/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler.cc [modify] https://crrev.com/1eb2d22874249cebe5620253b02fe9a4f551a420/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3af3724413663ad2b21ae57c1f90d17248425353 commit 3af3724413663ad2b21ae57c1f90d17248425353 Author: Dave Tapuska <dtapuska@chromium.org> Date: Wed Dec 19 17:49:18 2018 Move DOMTimer to not be a subclass of PausableTimer Timers are already scheduled using the kJavascriptTimer task queue which gets paused. So there is no need to iterate pausable objects cancelling them and rescheduling them. BUG=907125 Change-Id: I3831a1b6530bb1ab7c9b0ed80eb073dd468e38bf Reviewed-on: https://chromium-review.googlesource.com/c/1377132 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#617870} [modify] https://crrev.com/3af3724413663ad2b21ae57c1f90d17248425353/third_party/blink/renderer/core/frame/dom_timer.cc [modify] https://crrev.com/3af3724413663ad2b21ae57c1f90d17248425353/third_party/blink/renderer/core/frame/dom_timer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4c34f516bf8d02ea0c4ec797344b57dbbb920bd commit b4c34f516bf8d02ea0c4ec797344b57dbbb920bd Author: Dave Tapuska <dtapuska@chromium.org> Date: Wed Dec 19 18:01:45 2018 Reland "Pausable Object Cleanup - XMLHttpRequest" This is a reland of df0477e9ca0423600017a6e6fb566ff5784c7667 Now that Workers pause correctly this change can be relanded. Original change's description: > Pausable Object Cleanup - XMLHttpRequest > > The events dispatched by the XMLHttpRequestEventThrottle are attached > to the kNetwork TaskQueue which is a pausable task queue. > > Verified progress events aren't received while an alert dialog is present. > > BUG=907125 > > Change-Id: I93d8bbf8151753c5ddfc14bbfdd067697f6fe01e > Reviewed-on: https://chromium-review.googlesource.com/c/1368462 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615143} TBR=haraken@chromium.org,altimin@chromium.org Bug: 907125 Change-Id: Ie6b7f8be11eb436a23456dc563b6dfacf26ac703 Reviewed-on: https://chromium-review.googlesource.com/c/1384652 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#617875} [modify] https://crrev.com/b4c34f516bf8d02ea0c4ec797344b57dbbb920bd/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc [modify] https://crrev.com/b4c34f516bf8d02ea0c4ec797344b57dbbb920bd/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.h [modify] https://crrev.com/b4c34f516bf8d02ea0c4ec797344b57dbbb920bd/third_party/blink/renderer/core/xmlhttprequest/xml_http_request_progress_event_throttle.cc [modify] https://crrev.com/b4c34f516bf8d02ea0c4ec797344b57dbbb920bd/third_party/blink/renderer/core/xmlhttprequest/xml_http_request_progress_event_throttle.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4cbb3dc56028a69f05f22bcc5fa3a3ba7b3a978 commit b4cbb3dc56028a69f05f22bcc5fa3a3ba7b3a978 Author: Dave Tapuska <dtapuska@chromium.org> Date: Thu Dec 20 17:21:17 2018 Make ScriptPromiseResolver a ContextLifecycleObserver Pausing and Resuming wasn't necessary for the ScriptPromiseResolver because it uses the microtask queue to schedule tasks for later. If a task is resolved during paused state it instead schedules a task for the micro task queue. BUG=907125 Change-Id: I6f292200bb7ec6045f2ead2292006d2a0beee723 Reviewed-on: https://chromium-review.googlesource.com/c/1370384 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#618255} [modify] https://crrev.com/b4cbb3dc56028a69f05f22bcc5fa3a3ba7b3a978/third_party/blink/renderer/bindings/core/v8/script_promise_resolver.cc [modify] https://crrev.com/b4cbb3dc56028a69f05f22bcc5fa3a3ba7b3a978/third_party/blink/renderer/bindings/core/v8/script_promise_resolver.h [modify] https://crrev.com/b4cbb3dc56028a69f05f22bcc5fa3a3ba7b3a978/third_party/blink/renderer/bindings/core/v8/script_promise_resolver_test.cc [modify] https://crrev.com/b4cbb3dc56028a69f05f22bcc5fa3a3ba7b3a978/third_party/blink/renderer/modules/audio_output_devices/html_media_element_audio_output_device.cc [modify] https://crrev.com/b4cbb3dc56028a69f05f22bcc5fa3a3ba7b3a978/third_party/blink/renderer/modules/crypto/crypto_result_impl.cc [modify] https://crrev.com/b4cbb3dc56028a69f05f22bcc5fa3a3ba7b3a978/third_party/blink/renderer/modules/encryptedmedia/html_media_element_encrypted_media.cc [modify] https://crrev.com/b4cbb3dc56028a69f05f22bcc5fa3a3ba7b3a978/third_party/blink/renderer/modules/webmidi/midi_access_initializer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3f210770a6dab0bb02bf84da38e3c286d9cca58 commit a3f210770a6dab0bb02bf84da38e3c286d9cca58 Author: Dave Tapuska <dtapuska@chromium.org> Date: Thu Dec 20 23:43:15 2018 Pausable Object Cleanup - Workers Remove the paused_calls vector on WorkerGlobalScope because all the calls executed occur on pausable task queues after http://crrev.com/1eb2d22. BUG=907125 Change-Id: I42ad827eb1131f643158f9c6e565d69886896ccc Reviewed-on: https://chromium-review.googlesource.com/c/1385015 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#618379} [modify] https://crrev.com/a3f210770a6dab0bb02bf84da38e3c286d9cca58/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc [modify] https://crrev.com/a3f210770a6dab0bb02bf84da38e3c286d9cca58/third_party/blink/renderer/core/workers/dedicated_worker_object_proxy.cc [modify] https://crrev.com/a3f210770a6dab0bb02bf84da38e3c286d9cca58/third_party/blink/renderer/core/workers/shared_worker_global_scope.cc [modify] https://crrev.com/a3f210770a6dab0bb02bf84da38e3c286d9cca58/third_party/blink/renderer/core/workers/shared_worker_global_scope.h [modify] https://crrev.com/a3f210770a6dab0bb02bf84da38e3c286d9cca58/third_party/blink/renderer/core/workers/worker_global_scope.cc [modify] https://crrev.com/a3f210770a6dab0bb02bf84da38e3c286d9cca58/third_party/blink/renderer/core/workers/worker_global_scope.h [modify] https://crrev.com/a3f210770a6dab0bb02bf84da38e3c286d9cca58/third_party/blink/renderer/core/workers/worker_thread.cc [modify] https://crrev.com/a3f210770a6dab0bb02bf84da38e3c286d9cca58/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.cc [modify] https://crrev.com/a3f210770a6dab0bb02bf84da38e3c286d9cca58/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbd6c0c85e6f51839ef4c736dfee72df8e5b51ac commit bbd6c0c85e6f51839ef4c736dfee72df8e5b51ac Author: Dave Tapuska <dtapuska@chromium.org> Date: Fri Dec 21 17:54:39 2018 Pausable Object Cleanup - IDBRequest IDBRequest doesn't need to be a pausable object since it doesn't use any PausableObject behaviour and can just be a ContextLifecycleObserver. BUG=907125 Change-Id: Ief75293c6bced70f781f0c716f1d121fe39f2e3b Reviewed-on: https://chromium-review.googlesource.com/c/1387546 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#618552} [modify] https://crrev.com/bbd6c0c85e6f51839ef4c736dfee72df8e5b51ac/third_party/blink/renderer/modules/indexeddb/idb_open_db_request.cc [modify] https://crrev.com/bbd6c0c85e6f51839ef4c736dfee72df8e5b51ac/third_party/blink/renderer/modules/indexeddb/idb_request.cc [modify] https://crrev.com/bbd6c0c85e6f51839ef4c736dfee72df8e5b51ac/third_party/blink/renderer/modules/indexeddb/idb_request.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/080fe8b4e00fb689ce026d721d8d36eb7b9564e3 commit 080fe8b4e00fb689ce026d721d8d36eb7b9564e3 Author: Dave Tapuska <dtapuska@chromium.org> Date: Fri Dec 21 17:54:45 2018 Pausable Object Cleanup - SourceBuffer SourceBuffer doesn't need to be a pausable object since it uses the kMediaElementEvent task queue which is pausble. BUG=907125 Change-Id: I55eab8742c8a3177b3bc658e753b8cee19036980 Reviewed-on: https://chromium-review.googlesource.com/c/1387162 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#618553} [modify] https://crrev.com/080fe8b4e00fb689ce026d721d8d36eb7b9564e3/third_party/blink/renderer/modules/mediasource/source_buffer.cc [modify] https://crrev.com/080fe8b4e00fb689ce026d721d8d36eb7b9564e3/third_party/blink/renderer/modules/mediasource/source_buffer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b32c781e4e5f990f1f71f2facad19bed07929e38 commit b32c781e4e5f990f1f71f2facad19bed07929e38 Author: Dave Tapuska <dtapuska@chromium.org> Date: Fri Dec 21 17:55:43 2018 Pausable Object Cleanup - Lock Lock doesn't need to be a pausable object since it doesn't use any PausableObject behaviour and can just be a ContextLifecycleObserver. BUG=907125 Change-Id: If2914dbef4e763f928877294f309ad65ad9da377 Reviewed-on: https://chromium-review.googlesource.com/c/1387163 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#618554} [modify] https://crrev.com/b32c781e4e5f990f1f71f2facad19bed07929e38/third_party/blink/renderer/modules/locks/lock.cc [modify] https://crrev.com/b32c781e4e5f990f1f71f2facad19bed07929e38/third_party/blink/renderer/modules/locks/lock.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d720337ae9fc981e05ba10d86920050e385f66e commit 4d720337ae9fc981e05ba10d86920050e385f66e Author: Dave Tapuska <dtapuska@chromium.org> Date: Tue Jan 08 14:17:18 2019 Pausable Workers - Remove usage of kInternalWorker for Timezone change Switching the timezone can be a pausable activity so switch the task type to be kInternalDefault which is pausable. BUG=907125 Change-Id: I9f8e069b580355d32c2839e981d4494a034d0e6c Reviewed-on: https://chromium-review.googlesource.com/c/1387126 Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#620705} [modify] https://crrev.com/4d720337ae9fc981e05ba10d86920050e385f66e/third_party/blink/renderer/core/workers/worker_thread.h [modify] https://crrev.com/4d720337ae9fc981e05ba10d86920050e385f66e/third_party/blink/renderer/modules/time_zone_monitor/time_zone_monitor_client.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be838d5cb54395e1ed0783ab3932e282c7e9744a commit be838d5cb54395e1ed0783ab3932e282c7e9744a Author: Dave Tapuska <dtapuska@chromium.org> Date: Thu Jan 10 20:22:49 2019 Pausable Object Cleanup - PausableScriptExecutor Remove PausableScriptExecutor from inheriting PausableTimer. It wasn't necessary for this object to inherit from PausableTimer since kJavascriptTimer is already a pausable task. BUG=907125 Change-Id: Iab43584381ceb20f52103a340c30688b15a7d257 Reviewed-on: https://chromium-review.googlesource.com/c/1388708 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#621726} [modify] https://crrev.com/be838d5cb54395e1ed0783ab3932e282c7e9744a/third_party/blink/renderer/core/exported/web_frame_test.cc [modify] https://crrev.com/be838d5cb54395e1ed0783ab3932e282c7e9744a/third_party/blink/renderer/core/frame/pausable_script_executor.cc [modify] https://crrev.com/be838d5cb54395e1ed0783ab3932e282c7e9744a/third_party/blink/renderer/core/frame/pausable_script_executor.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1eec3d5e6fd1da94b367f8af1cd93f7e28a9c84d commit 1eec3d5e6fd1da94b367f8af1cd93f7e28a9c84d Author: Dave Tapuska <dtapuska@chromium.org> Date: Thu Jan 10 23:20:18 2019 PausableObject Cleanup - PostMessageTimer The PostMessageTimer used to send postMessage between same process documents and uses the kPostedMessage task queue (which is pausable). There is no need for a separate timer based object to just do a PostTask. BUG=907125 Change-Id: I0720a9c2f5f81547aa85be25fea8328146d4244e Reviewed-on: https://chromium-review.googlesource.com/c/1387671 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#621796} [modify] https://crrev.com/1eec3d5e6fd1da94b367f8af1cd93f7e28a9c84d/third_party/blink/renderer/core/frame/local_dom_window.cc [modify] https://crrev.com/1eec3d5e6fd1da94b367f8af1cd93f7e28a9c84d/third_party/blink/renderer/core/frame/local_dom_window.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/989a1edc768777f14ac1cea40101a4b7e655921d commit 989a1edc768777f14ac1cea40101a4b7e655921d Author: Dave Tapuska <dtapuska@chromium.org> Date: Fri Jan 11 17:04:28 2019 Pausable Object Cleanup - IntersectionObserverController IntersectionObserver is using kInternalIntersectionObserver which is a pausable task queue. BUG=907125 Change-Id: I63fd26c407f32e64996f8e8a9af4ee860fc4daf6 Reviewed-on: https://chromium-review.googlesource.com/c/1388297 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#622035} [modify] https://crrev.com/989a1edc768777f14ac1cea40101a4b7e655921d/third_party/blink/renderer/core/intersection_observer/intersection_observer_controller.cc [modify] https://crrev.com/989a1edc768777f14ac1cea40101a4b7e655921d/third_party/blink/renderer/core/intersection_observer/intersection_observer_controller.h [modify] https://crrev.com/989a1edc768777f14ac1cea40101a4b7e655921d/third_party/blink/renderer/core/intersection_observer/intersection_observer_test.cc [modify] https://crrev.com/989a1edc768777f14ac1cea40101a4b7e655921d/third_party/blink/web_tests/http/tests/activedomobject/media-expected.txt [modify] https://crrev.com/989a1edc768777f14ac1cea40101a4b7e655921d/third_party/blink/web_tests/http/tests/activedomobject/media.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6b07146616e8ed1097a6e476354918aa8b62482 commit d6b07146616e8ed1097a6e476354918aa8b62482 Author: Dave Tapuska <dtapuska@chromium.org> Date: Fri Jan 11 19:09:03 2019 Pausable Object Cleanup - PausableTask Make PausableTask not inherit PausableTimer. There is no need to schedule a timer since the kJavascriptTimer task queue already is pausable. This class has no real user yet; Devlin claims that the extension code will be using it soon. BUG=907125 Change-Id: I270ef5d8e7f67c32d2377d8f8785ec56e941c204 Reviewed-on: https://chromium-review.googlesource.com/c/1378233 Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#622083} [modify] https://crrev.com/d6b07146616e8ed1097a6e476354918aa8b62482/third_party/blink/renderer/core/exported/web_frame_test.cc [modify] https://crrev.com/d6b07146616e8ed1097a6e476354918aa8b62482/third_party/blink/renderer/core/frame/pausable_task.cc [modify] https://crrev.com/d6b07146616e8ed1097a6e476354918aa8b62482/third_party/blink/renderer/core/frame/pausable_task.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3fb24af58d849f8141546e7292d01742a226f8a commit f3fb24af58d849f8141546e7292d01742a226f8a Author: Dave Tapuska <dtapuska@chromium.org> Date: Fri Jan 11 20:33:30 2019 Remove PausableTimer It is no longer used. All other classes have mitigated to using CancelableTasks and ContextLifecycleObservers directly. BUG=907125 Change-Id: I9bfa406836e842b1dfc2b14a9144758e3edd55d1 Reviewed-on: https://chromium-review.googlesource.com/c/1407094 Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#622125} [modify] https://crrev.com/f3fb24af58d849f8141546e7292d01742a226f8a/third_party/blink/renderer/core/frame/BUILD.gn [modify] https://crrev.com/f3fb24af58d849f8141546e7292d01742a226f8a/third_party/blink/renderer/core/frame/pausable_task.h [delete] https://crrev.com/187f4c9551bac0c7b38047d41772f262fc4267d3/third_party/blink/renderer/core/frame/pausable_timer.cc [delete] https://crrev.com/187f4c9551bac0c7b38047d41772f262fc4267d3/third_party/blink/renderer/core/frame/pausable_timer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ac2d62a551ffcd54df8adbf6b0d081543649e51 commit 2ac2d62a551ffcd54df8adbf6b0d081543649e51 Author: Dave Tapuska <dtapuska@chromium.org> Date: Mon Jan 14 14:47:27 2019 Update leak_detector to latest PausableObject changes FontFaceSet pausable object was removed in: https://crrev.com/869255859135c13bf164e9d92d98ceea13aa0cc2 I'm not certain when the PausableTimer was removed from the DocumentLoader but PausableTimer no longer exists so it is gone anyways. BUG=907125 Change-Id: I85da3db3a96e9952d54ba5060d21346b29a0a819 Reviewed-on: https://chromium-review.googlesource.com/c/1407664 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#622451} [modify] https://crrev.com/2ac2d62a551ffcd54df8adbf6b0d081543649e51/content/shell/browser/web_test/leak_detector.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69738b80d28975e7573981da7bafdc8fa53f8c79 commit 69738b80d28975e7573981da7bafdc8fa53f8c79 Author: Dave Tapuska <dtapuska@chromium.org> Date: Mon Jan 14 15:08:28 2019 Remove unused imports In preparation for renaming PausableObject remove unused imports. BUG=907125 Change-Id: Id6cdc2561d1df04313ac6f16edea81d0b45445f3 Reviewed-on: https://chromium-review.googlesource.com/c/1407650 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#622457} [modify] https://crrev.com/69738b80d28975e7573981da7bafdc8fa53f8c79/third_party/blink/renderer/core/css/font_face_set_document.h [modify] https://crrev.com/69738b80d28975e7573981da7bafdc8fa53f8c79/third_party/blink/renderer/core/css/font_face_set_worker.h [modify] https://crrev.com/69738b80d28975e7573981da7bafdc8fa53f8c79/third_party/blink/renderer/core/workers/dedicated_worker.h [modify] https://crrev.com/69738b80d28975e7573981da7bafdc8fa53f8c79/third_party/blink/renderer/core/workers/worker_global_scope.cc [modify] https://crrev.com/69738b80d28975e7573981da7bafdc8fa53f8c79/third_party/blink/renderer/modules/mediarecorder/media_recorder.h [modify] https://crrev.com/69738b80d28975e7573981da7bafdc8fa53f8c79/third_party/blink/renderer/modules/mediastream/user_media_request.h [modify] https://crrev.com/69738b80d28975e7573981da7bafdc8fa53f8c79/third_party/blink/renderer/modules/sensor/sensor.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34181304bd765bbd22f621fd3834cc1cd9881e06 commit 34181304bd765bbd22f621fd3834cc1cd9881e06 Author: Dave Tapuska <dtapuska@chromium.org> Date: Mon Jan 14 19:39:59 2019 Remove tests expectations for PausableObjects that no longer fail BUG=907125,661182,506754 Change-Id: I511b0f8f35d6030b7b9609432dc13f9351846c19 Reviewed-on: https://chromium-review.googlesource.com/c/1409483 Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#622551} [modify] https://crrev.com/34181304bd765bbd22f621fd3834cc1cd9881e06/third_party/blink/web_tests/LeakExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2cb051b10b43c16be97fd54b657dad8eb40b8b10 commit 2cb051b10b43c16be97fd54b657dad8eb40b8b10 Author: Dave Tapuska <dtapuska@chromium.org> Date: Wed Jan 16 16:39:24 2019 Rename Pause/Unpaused to ContextPaused/ContextUnpaused. Add a enumeration state of the type of pausing of tasks the ExecutionContext has. kPaused is the state where only tasks are paused. kFrozen is the state where all things on the page should be paused including media. BUG=907125 Change-Id: Id72209f25bdc7d512d6cc41b02636c2bdadb54a3 Reviewed-on: https://chromium-review.googlesource.com/c/1409812 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#623256} [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/bindings/core/v8/script_promise_resolver_test.cc [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/core/BUILD.gn [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/core/dom/BUILD.gn [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/core/dom/context_lifecycle_notifier.cc [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/core/dom/context_lifecycle_notifier.h [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/core/dom/document.cc [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/core/dom/scripted_idle_task_controller.cc [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/core/dom/scripted_idle_task_controller.h [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/core/execution_context/BUILD.gn [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/core/execution_context/execution_context.cc [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/core/execution_context/execution_context.h [rename] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/core/execution_context/pausable_object.cc [rename] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/core/execution_context/pausable_object.h [rename] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/core/execution_context/pausable_object_test.cc [add] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/core/execution_context/pause_state.h [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/core/html/media/html_media_element.h [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/core/inspector/worker_thread_debugger.cc [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/core/loader/frame_loader.cc [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/modules/battery/battery_manager.cc [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/modules/battery/battery_manager.h [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/modules/permissions/permission_status.cc [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/modules/permissions/permission_status.h [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/modules/presentation/presentation_availability.cc [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/modules/presentation/presentation_availability.h [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/modules/vr/vr_display.cc [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/modules/vr/vr_display.h [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/modules/webaudio/base_audio_context.h [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/modules/websockets/dom_websocket.cc [modify] https://crrev.com/2cb051b10b43c16be97fd54b657dad8eb40b8b10/third_party/blink/renderer/modules/websockets/dom_websocket.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a353ebdb7753a3fbeb401c4c0e0f3358ccbb90b commit 3a353ebdb7753a3fbeb401c4c0e0f3358ccbb90b Author: Dave Tapuska <dtapuska@chromium.org> Date: Wed Jan 16 19:10:18 2019 Support pausing media when a context is frozen. Media is resumed when the context is unpaused. This feature will be used for bfcache and pausing iframes feature policy. BUG=907125 Change-Id: Ic3925ea1a4544242b7bf0b9ad8c9cb9f63976bbd Reviewed-on: https://chromium-review.googlesource.com/c/1410126 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#623319} [modify] https://crrev.com/3a353ebdb7753a3fbeb401c4c0e0f3358ccbb90b/third_party/blink/renderer/core/html/media/html_media_element.cc [modify] https://crrev.com/3a353ebdb7753a3fbeb401c4c0e0f3358ccbb90b/third_party/blink/renderer/core/html/media/html_media_element.h [modify] https://crrev.com/3a353ebdb7753a3fbeb401c4c0e0f3358ccbb90b/third_party/blink/renderer/core/html/media/html_media_element_test.cc [modify] https://crrev.com/3a353ebdb7753a3fbeb401c4c0e0f3358ccbb90b/third_party/blink/renderer/modules/webaudio/audio_context_test.cc [modify] https://crrev.com/3a353ebdb7753a3fbeb401c4c0e0f3358ccbb90b/third_party/blink/renderer/modules/webaudio/audio_destination_node.h [modify] https://crrev.com/3a353ebdb7753a3fbeb401c4c0e0f3358ccbb90b/third_party/blink/renderer/modules/webaudio/base_audio_context.cc [modify] https://crrev.com/3a353ebdb7753a3fbeb401c4c0e0f3358ccbb90b/third_party/blink/renderer/modules/webaudio/base_audio_context.h [modify] https://crrev.com/3a353ebdb7753a3fbeb401c4c0e0f3358ccbb90b/third_party/blink/renderer/modules/webaudio/default_audio_destination_node.cc [modify] https://crrev.com/3a353ebdb7753a3fbeb401c4c0e0f3358ccbb90b/third_party/blink/renderer/modules/webaudio/default_audio_destination_node.h [modify] https://crrev.com/3a353ebdb7753a3fbeb401c4c0e0f3358ccbb90b/third_party/blink/renderer/modules/webaudio/offline_audio_destination_node.cc [modify] https://crrev.com/3a353ebdb7753a3fbeb401c4c0e0f3358ccbb90b/third_party/blink/renderer/modules/webaudio/offline_audio_destination_node.h
Comment 1 by dtapu...@chromium.org
, Nov 20