New issue
Advanced search Search tips

Issue 907113 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Yesterday
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Exposing webrtc metric called number of audio jitter buffer flushes in blink via webrtc getStats API

Project Member Reported by kuddai@google.com, Nov 20

Issue description

Feature description:

Exposing webrtc metric called number of audio jitter buffer flushes in blink via webrtc getStats API

This is experimental feature hidden under origin trial. It will potentially help to determine appropriate size of audio jitter buffer which can result into better performance.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 23

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/8af889659637e347eb3dc8b80295160cd323b676

commit 8af889659637e347eb3dc8b80295160cd323b676
Author: Ruslan Burakov <kuddai@google.com>
Date: Fri Nov 23 11:41:43 2018

Expose jitter buffer flushes metric in new getStats api.

Origin trial experiment proposal (new statistic part):
https://docs.google.com/document/d/1stYIZhEmDZ7NJF9gjjsM66eLFJUdc-14a3QutrFbIwI/edit?ts=5bf5535c#

Bug:  chromium:907113 
Change-Id: I1d005291f9b47665f70c26148dbdcbb55564bef8
Reviewed-on: https://webrtc-review.googlesource.com/c/111505
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Jonas Olsson <jonasolsson@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Ruslan Burakov <kuddai@google.com>
Cr-Commit-Position: refs/heads/master@{#25768}
[modify] https://crrev.com/8af889659637e347eb3dc8b80295160cd323b676/api/stats/rtcstats.h
[modify] https://crrev.com/8af889659637e347eb3dc8b80295160cd323b676/api/stats/rtcstats_objects.h
[modify] https://crrev.com/8af889659637e347eb3dc8b80295160cd323b676/audio/audio_receive_stream.cc
[modify] https://crrev.com/8af889659637e347eb3dc8b80295160cd323b676/call/audio_receive_stream.h
[modify] https://crrev.com/8af889659637e347eb3dc8b80295160cd323b676/media/base/mediachannel.h
[modify] https://crrev.com/8af889659637e347eb3dc8b80295160cd323b676/media/engine/webrtcvoiceengine.cc
[modify] https://crrev.com/8af889659637e347eb3dc8b80295160cd323b676/modules/audio_coding/acm2/acm_receiver.cc
[modify] https://crrev.com/8af889659637e347eb3dc8b80295160cd323b676/modules/audio_coding/include/audio_coding_module_typedefs.h
[modify] https://crrev.com/8af889659637e347eb3dc8b80295160cd323b676/pc/rtcstats_integrationtest.cc
[modify] https://crrev.com/8af889659637e347eb3dc8b80295160cd323b676/pc/rtcstatscollector.cc
[modify] https://crrev.com/8af889659637e347eb3dc8b80295160cd323b676/pc/rtcstatscollector_unittest.cc
[modify] https://crrev.com/8af889659637e347eb3dc8b80295160cd323b676/stats/rtcstats_objects.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b554f6af88760872fd7785eda47bc5c4d62e8ae

commit 9b554f6af88760872fd7785eda47bc5c4d62e8ae
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Sun Nov 25 16:07:22 2018

Roll src/third_party/webrtc b357e54dd5b2..f1c194decd51 (10 commits)

https://webrtc.googlesource.com/src.git/+log/b357e54dd5b2..f1c194decd51


git log b357e54dd5b2..f1c194decd51 --date=short --no-merges --format='%ad %ae %s'
2018-11-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d298cced6c..7579fcbc1c (610627:610728)
2018-11-23 oprypin@webrtc.org Roll chromium_revision f9be7d3d66..d298cced6c (610432:610627)
2018-11-23 aleloi@webrtc.org Revert "Replace the IceConnectionState implementation."
2018-11-23 sprang@webrtc.org Remove use of CodecSpecificInfo.codec_name
2018-11-23 jonasolsson@webrtc.org Replace the IceConnectionState implementation.
2018-11-23 srte@webrtc.org Adds stable bandwidth estimate to GoogCC.
2018-11-23 ssilkin@webrtc.org Don't buffer encoded frames.
2018-11-23 srte@webrtc.org Moves ProbeBitrateEstimator from DelayBasedBwe.
2018-11-23 mbonadei@webrtc.org Decouple //rtc_base:rtc_base_tests_utils from gunit.
2018-11-23 kuddai@google.com Expose jitter buffer flushes metric in new getStats api.


Created with:
  gclient setdep -r src/third_party/webrtc@f1c194decd51

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:906803,chromium:None,chromium:907113
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Idf6801287f38d7f2ac2d87e8d3b387e98918b8a1
Reviewed-on: https://chromium-review.googlesource.com/c/1350353
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610733}
[modify] https://crrev.com/9b554f6af88760872fd7785eda47bc5c4d62e8ae/DEPS

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1453b541569db2355138127aa40863ee305581e

commit e1453b541569db2355138127aa40863ee305581e
Author: Ruslan Burakov <kuddai@google.com>
Date: Tue Nov 27 18:07:42 2018

Expose any non-standardized statistics if a known WebRTC Origin Trial is running.

Currently there is only one non-standardized statistics "jitterBufferFlushes which will be exposed under the following origin trial:
https://docs.google.com/document/d/1stYIZhEmDZ7NJF9gjjsM66eLFJUdc-14a3QutrFbIwI/edit?ts=5bf5535c#

However, note that any other non-standardized statistics added later would be also exposed under this origin trial.

Bug:  chromium:907113 
Change-Id: I4036dd1fceae3b68d33f9ae2666a0e2d942fb345
Reviewed-on: https://chromium-review.googlesource.com/c/1344433
Commit-Queue: Ruslan Burakov <kuddai@google.com>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611189}
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/content/renderer/media/webrtc/fake_rtc_rtp_transceiver.cc
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/content/renderer/media/webrtc/fake_rtc_rtp_transceiver.h
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/content/renderer/media/webrtc/rtc_peer_connection_handler.cc
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/content/renderer/media/webrtc/rtc_peer_connection_handler.h
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/content/renderer/media/webrtc/rtc_peer_connection_handler_unittest.cc
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/content/renderer/media/webrtc/rtc_rtp_receiver.cc
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/content/renderer/media/webrtc/rtc_rtp_receiver.h
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/content/renderer/media/webrtc/rtc_rtp_receiver_unittest.cc
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/content/renderer/media/webrtc/rtc_rtp_sender.cc
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/content/renderer/media/webrtc/rtc_rtp_sender.h
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/content/renderer/media/webrtc/rtc_rtp_sender_unittest.cc
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/content/renderer/media/webrtc/rtc_stats.cc
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/content/renderer/media/webrtc/rtc_stats.h
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/content/renderer/media/webrtc/rtc_stats_unittest.cc
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/third_party/blink/public/platform/web_rtc_peer_connection_handler.h
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/third_party/blink/public/platform/web_rtc_rtp_receiver.h
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/third_party/blink/public/platform/web_rtc_rtp_sender.h
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/third_party/blink/public/platform/web_rtc_stats.h
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/third_party/blink/renderer/modules/peerconnection/rtc_rtp_receiver.cc
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.cc
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/third_party/blink/renderer/modules/peerconnection/rtc_stats_report.cc
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/third_party/blink/renderer/modules/peerconnection/rtc_stats_report.h
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/third_party/blink/renderer/platform/testing/testing_platform_support_with_web_rtc.cc
[modify] https://crrev.com/e1453b541569db2355138127aa40863ee305581e/third_party/blink/renderer/platform/testing/testing_platform_support_with_web_rtc.h

Labels: Pri-2
Setting defect without priority to default.

Comment 5 by kuddai@google.com, Yesterday (42 hours ago)

Status: Fixed (was: Assigned)

Sign in to add a comment