New issue
Advanced search Search tips

Issue 907093 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 21
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug-Regression

Blocking:
issue 495204



Sign in to add a comment

dawn breaks win/cross build

Project Member Reported by thakis@chromium.org, Nov 20

Issue description

https://logs.chromium.org/logs/chromium/bb/chromium.clang/linux-win_cross-rel/4688/+/recipes/steps/compile/0/stdout

../../third_party/dawn/src/dawn_native/d3d12/DeviceD3D12.cpp(19,10):  fatal error: 'dawn_native/D3D12backend.h' file not found
#include "dawn_native/D3D12backend.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
Note: including file: ../../third_party/dawn/src/dawn_native/d3d12/BindGroupD3D12.h
1 error generated.

The file is called D3D12Backend.h with a capital B, which matters on case-sensitive file systems.

(see https://chromium.googlesource.com/chromium/src/+show/master/docs/win_cross.md for details)
 
Blocking: 495204
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://dawn.googlesource.com/dawn/+/63997221d7d880d8d1783abe326b90cd95cd92d2

commit 63997221d7d880d8d1783abe326b90cd95cd92d2
Author: Corentin Wallez <cwallez@chromium.org>
Date: Tue Nov 20 15:40:04 2018

Fix #include casing breaking linux->windows cross compilation

TBR=kainino@chromium.org
BUG= chromium:907093 

Change-Id: I616f774e70871bf3e728178d8d41c18a488b6901
Reviewed-on: https://dawn-review.googlesource.com/c/2580
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/63997221d7d880d8d1783abe326b90cd95cd92d2/src/dawn_native/d3d12/DeviceD3D12.cpp

Status: Fixed (was: Assigned)
This was fixed as shown in this run: https://logs.chromium.org/logs/chromium/bb/chromium.clang/linux-win_cross-rel/4700/+/recipes/steps/compile/0/stdout

However the compiler is now crashing on some other source file.
Thanks!

Sign in to add a comment