New issue
Advanced search Search tips

Issue 907079 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Poor performance when running catapult

Project Member Reported by mlippautz@chromium.org, Nov 20

Issue description

time tools/perf/run_benchmark v8.browsing_desktop --browser=exact --browser-executable=out/Release/chrome --story-filter=browse:news:nytimes$ --pageset-repeat=1 --reset-results

Took 10mins+ on X840 desktop.

After reverting the change in https://chromium-review.googlesource.com/c/chromium/src/+/1208955/ the benchmark finishing in ~2.5min.

Is this expected/known?
 
Cc: primiano@chromium.org
Ran again on ToT (chromium: b7b1fc005998a4209e8979081305608e8e85c8ed).

time testing/xvfb.py tools/perf/run_benchmark v8.browsing_desktop --browser=exact --browser-executable=out/Release/chrome  --results-label=TOT  --story-filter=browse:news:nytimes$ --pageset-repeat=1  --show-stdout --reset-results 

with Perfetto:
real	5m54.444s
user	9m48.484s
sys	0m52.373s

without Perfetto:
real	4m25.603s
user	7m1.338s
sys	0m40.395s

That's a 25% regression.
Cc: skyos...@chromium.org eseckler@chromium.org
I believe perfetto splits all trace events into two (start / end). The original backend could reduce TRACE_EVENT_PHASE_COMPLETE events into a single entry in the json, so the resulting json file with perfetto may be larger and thus slower to parse and analyze. Dunno if we can work around that somehow?

Is that the only possible reason for the benchmark script to have gotten slower?
Started a bisect on a huge regression visible here: https://chromeperf.appspot.com/report?sid=e004cacde6bdf79bede350d6ddaa6a806449b1c37e948afe086f719127a2ad1c&start_rev=606619&end_rev=609968

I thought that was Perfetto but cannot see it in the logs; maybe I was just mistaken... 

I actually sped up the metrics computation by rolling V8 from M57 to M70 but it still feels very slow.
📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/1464ba20140000
📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/12105b0fe40000
We discussed a few alternatives to splitting the _COMPLETE events, but none seem super feasible. Switching from JSON to proto in the future should more than compensate for this, though.
 mlippautz: Can you retry this after http://crrev.com/612360 please?
Happy to check once it has relanded. Thanks for following up on these issues!

Sign in to add a comment