New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 907059 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression: [Remote NTP] 'RTL' is not applied on Add shortcut overlay.

Reported by sanyam.g...@etouch.net, Nov 20

Issue description

Chrome Version: 71.0.3578.62 (Official Build) Revision	b1fa6dee27746dd62414ffad95ea3a7acf51ef16-refs/branch-heads/3578@{#760} 32/64-bit
OS:Win(7,8,8.1,10) ,Linux(14.04 LTS) and Mac(10.13.1 , 10.13.6 , 10.14.2) OS

Steps to reproduce:
1. Launch chrome and navigate to chrome://flags.
2. Set 'Force UI direction' to Right-to-left, 'Enable RTL' to Enable and relaunch browser.
3. Click on Add Shortcut to open the overlay and observe.

Actual  : 'RTL' is not applied on Add shortcut overlay.
Expected: 'RTL' should be applied on Add shortcut overlay.

This is a regression issue, broken in 'M-70', and below is the bisect info:
Good Build: 70.0.3537.0 (Revision: 587303)
Bad Build : 70.0.3538.0 (Revision: 587811)

Change-Log URL:

https://chromium.googlesource.com/chromium/src/+log/70.0.3537.0..70.0.3538.0?pretty=fuller&n=10000

Suspecting: r587802 ?

@sweilun: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1.Unable to provide 'per-revision' bisect as it shows "We don't have enough builds to bisect" error message,Tried on other machines but still getting the same error again.
2.Unable to perform 'chromium bisect' script as issue is not reproducible on chromium builds, hence providing suspect through Manual change-log.
3.Above issue is specific to remote NTP.

Thank You..!
 
 
Actual_Result.mov
1.1 MB View Download
Expected_result.mov
854 KB View Download
Cc: ramyan@chromium.org
Labels: -Pri-1 -Target-70 -Target-71 AddToRemoteNTP KR-NTP-MD2-Polish O-Polish-Birthday-Features Pri-3
Owner: kristip...@chromium.org
Verified that this actually occurs on an RTL language (attached screenshot), but only on the remote ntp.
crbug907059Hebrew.png
182 KB View Download
Labels: small
Labels: zine-triaged
Fixed in cl/226219038, will close this bug once it has been pushed to prod.

Comment 5 by kristip...@chromium.org, Jan 18 (4 days ago)

Status: Fixed (was: Assigned)

Sign in to add a comment