New issue
Advanced search Search tips

Issue 907057 link

Starred by 1 user
Status: Fixed
Owner:
aee@chromium.org
Closed: Nov 21
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug-Regression

Blocking:
issue 853957



Sign in to add a comment

Regression: Dual focus is seen 'Turn off sync and sign out?' overlay after Tap/Touch.

Reported by pranjali...@etouch.net, Nov 20 
Chrome Version:71.0.3578.62 (Official Build) Revision b1fa6dee27746dd62414ffad95ea3a7acf51ef16-refs/branch-heads/3578@{#760}(32/64 bit)

OS: Win-10 Touch.

Precondition: Sign into chrome with valid username and password.

Steps to reproduce:
1. Launch chrome and navigate to 'chrome://settings/'.
2. Click on 'Turn Off' button such that 'Turn off sync and sign out?' overlay appears.
3. Now Tap/Touch on Toggle button 2-3 times and observe.

Actual  : Dual focus is seen 'Turn off sync and sign out?' overlay after Tap/Touch.
Expected: Dual focus should not be seen 'Turn off sync and sign out?' overlay after Tap/Touch.

This is Regression issue seen in M-70, and will soon update other info.
Good Build: 70.0.3521.0
Bad Build: 70.0.3522.0

Narrow Bisect:

CHANGE-LOG URL:

https://chromium.googlesource.com/chromium/src/+log/dfa4c566937074580ab6b4abfcbe547210cb8283..24bc6198d5553fc0659da2a37580df516527400c

Suspecting: https://chromium.googlesource.com/chromium/src/+/7d6f04d4a269351dcb2597a1712d100c001a3c28

@aee: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1. Issue is Win 10 (Touch Device) specific and is not seen on Win(7,8,8.1,10), Mac(10.12.6,10.13.1,10.13.6,10.14.1) and Linux(14.04 LTS) OS.
2. Unable to provide 'per-revision' bisect as it shows "RuntimeError : We don't have enough builds to bisect..." error message for above range. 
3. Hence provided suspect through 'Chromium bisect'.

Kindly refer the attached screen-cast.

Thank You!
Actual Result.mp4
341 KB View Download
Expected Result.mp4
458 KB View Download

Comment 1 by dpa...@chromium.org, Nov 20

Blocking: 853957
Labels: -Pri-1 Pri-3

Comment 2 by dpa...@chromium.org, Nov 20 

This is a known (low-priority) issue. See more details at issue 853957.

Comment 3 by aee@chromium.org, Nov 20

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/beb23137fbabd6434b19319a0c0183b7c6e954c8

commit beb23137fbabd6434b19319a0c0183b7c6e954c8
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Wed Nov 21 19:38:30 2018

Settings WebUI: move cursor pointer style to label

When a div has its cursor style set to pointer, it is highlighted when
clicked. This can be replicated on desktop using the dev tools device
toolbar. When expand button does not have a label, the expand button
is highlighted. The actionable attribute is used set the cursor style
to pointer. The label div has has 0 dimensions when no label is slotted.
Moving the actionable attribute down to the label div works for both
when a label is present and missing.

Bug:  907057 
Change-Id: I23a0950b789c842739997554a3232c1805b3089e
Reviewed-on: https://chromium-review.googlesource.com/c/1344819
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610170}
[modify] https://crrev.com/beb23137fbabd6434b19319a0c0183b7c6e954c8/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html

Comment 5 by aee@chromium.org, Nov 21

Status: Fixed (was: Started)

Comment 6 by pranjali...@etouch.net, Nov 22

Labels: TE-Verified-M72 TE-Verified-72.0.3618.0
Update:
Rechecked the above issue on latest canary #72.0.3618.0 on Win-10 touch and issue is fixed.
Please refer attached screencast for reference.

Thank You...
Canary Behaviour.mp4
350 KB View Download
►

Sign in to add a comment