Regression : Person name text box stays empty and does not restore back to default person name.
Reported by
avsha...@etouch.net,
Nov 20
|
|||
Issue descriptionChrome Version : 72.0.3616.0 (Official Build) 95ce71356251517776e712f9815217c46c767dcc-refs/branch-heads/3616@{#1} 32/64 bit OS : Mac(10.13.6, 10.13.1, 10.14.2), Linux(14.04 LTS), Windows(7,8,8.1,10) What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://settings page. 2. Click on ‘Chrome name and picture’ option (Chrome navigates to ‘Edit person’ subpage). 3. Clear the existing person name from text box and click on back arrow icon. 4. Again navigate to ‘Edit person’ subpage and observe the person name text box. Actual Result : Person name text box stays empty and does not restore back to default person name even after navigating back & forth. Expected Result : Person name should restore to default name after step 4. This is a regression issue broken in M-72 and below is the bisect information: Good Build : 72.0.3582.0 (Revision : 599848) Bad Build : 72.0.3583.0 (Revision : 600163) CHANGE-LOG URL: https://chromium.googlesource.com/chromium/src/+log/e525f7cabf63e659eebd885cf2e71fc44582f1de..7a4d9c87dd8b9a4446ffd34d3932101f85a40d76 Suspect: https://chromium.googlesource.com/chromium/src/+/7a4d9c87dd8b9a4446ffd34d3932101f85a40d76 @Esmael: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. Issue is reproducible in Dev build #72.0.3610.2 Thank you..!
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea7257f1161e6c34762a49133280ef4a7a45e5fc commit ea7257f1161e6c34762a49133280ef4a7a45e5fc Author: Esmael El-Moslimany <aee@chromium.org> Date: Wed Nov 21 20:42:34 2018 Settings WebUI: manage-profile update profile name on route change, cr-input skip validation when old and new values are both falsy After validation, if the input value is invalid, the red underline will be drawn under the input. When initializing the cr-input, the value switches from undefined to '' and then it is updated to new values from there. This causes an issue because the underline opacity and width have transition. So if the value is valid after initialization, the underline will appear blue and then transition away (the color change is instant). This CL addresses this by skipping validation until a real value has been set. Bug: 907022 Change-Id: I2369cb41467c3d6ee9b3b30004188579df107906 Reviewed-on: https://chromium-review.googlesource.com/c/1345415 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#610200} [modify] https://crrev.com/ea7257f1161e6c34762a49133280ef4a7a45e5fc/chrome/browser/resources/settings/people_page/manage_profile.js [modify] https://crrev.com/ea7257f1161e6c34762a49133280ef4a7a45e5fc/ui/webui/resources/cr_elements/cr_input/cr_input.js
,
Nov 21
,
Nov 22
Update: Rechecked this issue on Mac(10.13.6, 10.13.1, 10.14.2), Linux(14.04 LTS) and Windows(7,8,8.1,10) machines using latest Canary #72.0.3618.0 and issue is fixed. Hence adding TE-Verified labels. please refer the attached screen-cast for reference. Thank you. |
|||
►
Sign in to add a comment |
|||
Comment 1 by aee@chromium.org
, Nov 20