New issue
Advanced search Search tips

Issue 907004 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 809539



Sign in to add a comment

Provide replacement API for SigninManager::DiagnosticsObserver::NotifySigninValueChanged

Project Member Reported by sdefresne@chromium.org, Nov 20

Issue description

Some code uses this API, so there should be a replacement in IdentityManager::DiagnosticsObserver (or something like this).
 
Status: Available (was: Untriaged)
Cc: svil...@igalia.com
Labels: -Pri-3 Proj-Servicification-VendorBug Pri-1
This can go into IdentityManager::DiagnosticsObserver.
Blocking: 809539
Owner: svil...@igalia.com
Status: Started (was: Available)
Working on this
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2da1b80de574746633024349f86976b9deba16dd

commit 2da1b80de574746633024349f86976b9deba16dd
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Mon Dec 10 10:05:08 2018

Replace SigninManager::DiagnosticsObserver::NotifySigninValueChanged API

Clients should use the new equivalent API in
IdentityManager::DiagnosticsObserver.

Bug:  907004 
Change-Id: Ic9b69820fdc8974bdade256eadd08eeb64acbb72
Reviewed-on: https://chromium-review.googlesource.com/c/1361066
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#615074}
[modify] https://crrev.com/2da1b80de574746633024349f86976b9deba16dd/chrome/browser/signin/about_signin_internals_factory.cc
[modify] https://crrev.com/2da1b80de574746633024349f86976b9deba16dd/chrome/browser/signin/dice_response_handler_unittest.cc
[modify] https://crrev.com/2da1b80de574746633024349f86976b9deba16dd/components/signin/core/browser/about_signin_internals.cc
[modify] https://crrev.com/2da1b80de574746633024349f86976b9deba16dd/components/signin/core/browser/about_signin_internals.h
[modify] https://crrev.com/2da1b80de574746633024349f86976b9deba16dd/ios/chrome/browser/signin/about_signin_internals_factory.cc
[modify] https://crrev.com/2da1b80de574746633024349f86976b9deba16dd/services/identity/public/cpp/DEPS
[modify] https://crrev.com/2da1b80de574746633024349f86976b9deba16dd/services/identity/public/cpp/identity_manager.cc
[modify] https://crrev.com/2da1b80de574746633024349f86976b9deba16dd/services/identity/public/cpp/identity_manager.h

Status: Fixed (was: Started)

Sign in to add a comment