Issue metadata
Sign in to add a comment
|
Regression : Unnecessary 'PIN must be atleast 6 digits' error message is seen in 'Confirm your PIN' overlay of chrome://settings/lockScreen page |
||||||||||||||||||||||
Issue descriptionChrome Version: 72.0.3612.0/11278.0.0 dev-channel Kip,Reks and Daisy OS: Chrome What steps will reproduce the problem? 1)Sign into User -> Go to chrome://settings/lockScreen -> At 'screen lock options' section select 'PIN or Password' option by clicking on 'SET UP PIN'-> click on 'SET UP PIN' ->In 'Enter your PIN' overlay enter any 6 digits -> click on 'Continue' (2)Now In 'Confirm your PIN' observe unnecessary error message 'PIN must be atleast 6 digits' (Please refer Video and Screenshot) Expected: Unnecessary error message 'PIN must be atleast 6 digits' should not be seen in 'Confirm your PIN' overlay Actual: Instead unnecessary error message 'PIN must be atleast 6 digits' is seen This is a Regression issue as same is working fine on 72.0.3609.3/11264.0.0 dev-channel Kip
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/924da3ba93abef2063a3b6bfdebe4ad802f39f77 commit 924da3ba93abef2063a3b6bfdebe4ad802f39f77 Author: Sammie Quon <sammiequon@google.com> Date: Wed Nov 28 02:16:18 2018 cros: Fix regression with pin message persistent in confirm stage. Partial reverted the cl which introduced this regression. I will reopen the original bug and try a better fix later. Test: manual Bug: 881756 , 907002 Change-Id: Idbe3a587caad485968d78b0b4841f1bfa0105366 Reviewed-on: https://chromium-review.googlesource.com/c/1344221 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#611517} [modify] https://crrev.com/924da3ba93abef2063a3b6bfdebe4ad802f39f77/ui/webui/resources/cr_components/chromeos/quick_unlock/setup_pin_keyboard.js
,
Dec 3
,
Dec 3
[Auto-generated comment by a script] We noticed that this issue is targeted for M-72; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-72 label, otherwise remove Merge-TBD label. Thanks.
,
Dec 3
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sammiequon@chromium.org
, Nov 20Owner: sammiequon@chromium.org
Status: Started (was: Untriaged)